Skip to content

dismiss keyboard on Choose SSO or MagicCode page #33421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldo-expensify merged 3 commits into from
Jan 3, 2024
Merged

dismiss keyboard on Choose SSO or MagicCode page #33421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ff321
dismiss keyboard on Choose SSO or MagicCode page
mkhutornyi Dec 21, 2023
2b4d20d
Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Fronte…
mkhutornyi Jan 3, 2024
034e93d
fix redundant dismiss call when keyboard is not shown
mkhutornyi Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/pages/signin/ChooseSSOOrMagicCode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import PropTypes from 'prop-types';
import React from 'react';
import {View} from 'react-native';
import React, {useEffect} from 'react';
import {Keyboard, View} from 'react-native';
import {withOnyx} from 'react-native-onyx';
import _ from 'underscore';
import Button from '@components/Button';
import FormHelpMessage from '@components/FormHelpMessage';
import Text from '@components/Text';
import useKeyboardState from '@hooks/useKeyboardState';
import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useThemeStyles from '@hooks/useThemeStyles';
Expand Down Expand Up @@ -54,10 +55,19 @@ const defaultProps = {

function ChooseSSOOrMagicCode({credentials, account, setIsUsingMagicCode}) {
const styles = useThemeStyles();
const {isKeyboardShown} = useKeyboardState();
const {translate} = useLocalize();
const {isOffline} = useNetwork();
const {isSmallScreenWidth} = useWindowDimensions();

// This view doesn't have a field for user input, so dismiss the device keyboard if shown
useEffect(() => {
Comment thread
mkhutornyi marked this conversation as resolved.
if (!isKeyboardShown) {
return;
}
Keyboard.dismiss();
}, [isKeyboardShown]);

return (
<>
<View>
Expand Down