Fix oldCreated date format when the created date was changed by wlegolas · Pull Request #33688 · Expensify/App

wlegolas · 2023-12-28T02:56:43Z

Details

Fix the wrong behavior when formatting the oldCreated date without the timezone information
Add Unit Tests to validate the changes

Fixed Issues

$ #33248
PROPOSAL: #33248 (comment)

Tests

Navigate to https://dev.new.expensify.com:8082/
Log in
Navigate to the created expense details page (or create one)
Click on the date
Change it once
Verify the date is changed, and a proper message is added, e.g. changed the date to 2023-12-27 (previously 2023-12-26)

Verify that no errors appear in the JS console

Offline tests

Navigate to https://dev.new.expensify.com:8082/
Log in
Navigate to the created expense details page (or create one)
Turn off your network connection
Click on the date
Change it once
Verify the date is changed, and a proper message is added, e.g. changed the date to 2023-12-27 (previously 2023-12-26)

Verify that no errors appear in the JS console

QA Steps

Navigate to https://staging.new.expensify.com/
Log in
Navigate to the created expense details page (or create one)
Click on the date
Change it once
Verify the date is changed, and a proper message is added, e.g. changed the date to 2023-12-27 (previously 2023-12-26)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

evidence-Android-Native.mov

Android: mWeb Chrome

evidence-Android-mWeb-Chrome.mov

iOS: Native

evidence-iOS-Native.mov

iOS: mWeb Safari

evidence-iOS-mWeb-Safari.mov

MacOS: Chrome / Safari

Chrome

evidence-MacOS-Chrome.mp4

Safari

evidence-MacOS-Safari.mp4

MacOS: Desktop

evidence-MacOS-Desktop.mp4

melvin-bot · 2023-12-28T03:00:02Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-01-05T20:51:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-08.at.9.20.18.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-08.at.8.29.25.PM.mov

iOS: Native

Screen.Recording.2024-01-08.at.8.31.09.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-06.at.2.06.26.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-08.at.9.32.04.PM.mov

getusha · 2024-01-05T21:22:17Z

@wlegolas I am not able to reproduce the issue on staging can you confirm?

wlegolas · 2024-01-06T01:35:23Z

@wlegolas I am not able to reproduce the issue on staging can you confirm?

Hi @getusha, I tested it here on staging and it's still happening.

staging-error.mov

I don't know if it's your case but usually, people east of GMT (most non-US) may not see this bug because new Date() moves the timezone forward for their local time, so the date may not change. In my case, my GMT is -03:00.

getusha

thanks! lgtm!

wlegolas · 2024-01-09T00:18:51Z

Hi @youssef-lr if you have any questions or suggestions, please let me know.

youssef-lr · 2024-01-09T14:49:05Z

-            changeFragments,
-        );
-    }
+    buildMessageFragmentForCreated(setFragments, removalFragments, changeFragments, reportActionOriginalMessage);


Q: what was the need for extracting this logic into a function? I can't see this function used more than once so I'm not sure it's necessary

I just extracted the code block responsible for building the message for the property created to this function. My idea was to decrease the complexity of the parent function getForReportAction, but if you disagree I can move the code from the buildMessageFragmentForCreated function and put it here.

Yeah I think as that logic is not really reusable there's no need to extract it to a function, I think it helps for readability if it stays there, instead of making the reader jump to a different location. Thanks!

Sure I understood your points, I'll change here.

Done: 326f61d

…he removed method

youssef-lr

LGTM

OSBotify · 2024-01-12T03:38:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-15T11:57:20Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-17T01:15:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

wlegolas added 2 commits December 27, 2023 22:35

Fix oldCreated date format when the created date was changed

d0f440a

Remove JSDoc comments that are redundant with TypeScript

3ac64a7

wlegolas marked this pull request as ready for review December 28, 2023 02:59

wlegolas requested a review from a team as a code owner December 28, 2023 02:59

melvin-bot Bot removed the request for review from a team December 28, 2023 03:00

melvin-bot Bot requested a review from getusha December 28, 2023 03:00

wlegolas mentioned this pull request Dec 28, 2023

[HOLD for payment 2024-01-24] [$500] IOU - The date does not change and a message with incorrect dates is added #33248

Closed

6 tasks

Merge branch 'main' into bugfix/issue-33248

36f43ae

getusha approved these changes Jan 8, 2024

View reviewed changes

melvin-bot Bot requested a review from youssef-lr January 8, 2024 19:05

youssef-lr reviewed Jan 9, 2024

View reviewed changes

Remove inner method and put its content in the place where is using t…

326f61d

…he removed method

wlegolas requested a review from youssef-lr January 11, 2024 23:39

youssef-lr approved these changes Jan 12, 2024

View reviewed changes

youssef-lr merged commit b6a18b1 into Expensify:main Jan 12, 2024

wlegolas deleted the bugfix/issue-33248 branch January 12, 2024 17:39

github-actions Bot mentioned this pull request Jan 15, 2024

Deploy Checklist: New Expensify 2024-01-15 #34493

Closed

83 tasks

Conversation

wlegolas commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 28, 2023

Uh oh!

getusha commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Jan 5, 2024

Uh oh!

wlegolas commented Jan 6, 2024

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

wlegolas commented Jan 9, 2024

Uh oh!

youssef-lr Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

wlegolas Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wlegolas Jan 11, 2024

Choose a reason for hiding this comment

Uh oh!

wlegolas Jan 11, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 12, 2024

Uh oh!

OSBotify commented Jan 15, 2024

Uh oh!

OSBotify commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wlegolas commented Dec 28, 2023 •

edited

Loading

getusha commented Jan 5, 2024 •

edited

Loading

youssef-lr Jan 11, 2024 •

edited

Loading