fix crash attachment by namhihi237 · Pull Request #34030 · Expensify/App

namhihi237 · 2024-01-05T15:26:12Z

Details

This PR is to try to fix regression from PR

Fixed Issues

$ #34016
$ #33985
PROPOSAL:

Tests

Case 1:

Go to workspace chat
Click + > Request money > Distance
Create a distance request and verify that no console error 404 after creating a distance request

Case 2:

Go to any room or profile details page
Open the room or profile picture verify that the app does not crash and show the picture

Verify that no errors appear in the JS console

Offline tests

The same test

QA Steps

The same test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-05.at.22.38.47.mov

Android: mWeb Chrome

Screen.Recording.2024-01-05.at.22.42.37.mov

iOS: Native

Screen.Recording.2024-01-05.at.22.35.53.mov

iOS: mWeb Safari

Screen.Recording.2024-01-05.at.22.37.29.mov

MacOS: Chrome / Safari

webb.mp4

MacOS: Desktop

desk.mp4

melvin-bot · 2024-01-05T16:02:29Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiroslav

Code looks good. Testing

0xmiroslav · 2024-01-05T16:05:41Z

    }

-    const isLocalFile = typeof path === 'number' || path.startsWith('blob:') || path.startsWith('file:');
+    const isLocalFile = typeof path === 'number' || path.startsWith('blob:') || path.startsWith('file:') || path === ReceiptGeneric;


what is type of ReceiptGeneric?

Ah it's string.

ok confirmed string on web, number on native.
So Case 1 bug is supposed to happen only on web

Hmm doesn't this apply to all paths that have a local file then?

Yes, I think if we check isLocalFile we should use this, currently I see we build the isLocalFile only in this function getThumbnailAndImageURIs

Can we apply a more hollistic approach to isLocalFile though? I imagine in the future we'll have more web assets we pass into getThumbnailAndImageURIs and ideally we don't just add an if check for each path. Maybe we can check if it starts with '/'? What do you think

Hmm, I think it is good, we can modify it like that to cover all we assets' path:

const isLocalFile = ... path.startsWith('/');

0xmiroslav · 2024-01-05T16:17:51Z

Open the room or profile picture verify that the app does not crash and show the picture

@namhihi237 this doesn't work correctly

Screen.Recording.2024-01-05.at.5.17.10.pm.mov

namhihi237 · 2024-01-05T16:25:56Z

Seem it does not relative this PR

namhihi237 · 2024-01-05T16:26:15Z

I test on production and this issue still happen

0xmiroslav · 2024-01-05T16:26:35Z

I test on production and this issue still happen

ok then out of scope

0xmiroslav · 2024-01-05T16:37:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

0xmiroslav

@thienlnam this needs CP'ed

sobitneupane · 2024-01-05T18:25:50Z

@namhihi237 Is this issue also a regression? Will it be handled by the PR?

namhihi237 · 2024-01-05T18:27:04Z

I will test this

namhihi237 · 2024-01-05T18:32:22Z

I can not reproduce on the main, anyone can reproduce? I test it to work on main and this PR.

0xmiroslav · 2024-01-05T18:33:11Z

I can not reproduce on the main, anyone can reproduce? I test it to work on main and this PR.

same

namhihi237 · 2024-01-05T18:37:37Z

Maybe PR will fix this issue #34049

sobitneupane · 2024-01-05T18:49:22Z

@namhihi237 Let's make sure #34049 issue is also handled by this PR.

namhihi237 · 2024-01-05T18:50:14Z

Testing on it

namhihi237 · 2024-01-05T18:53:07Z

Tested and was cover

sobitneupane · 2024-01-05T19:00:41Z

Thank you @namhihi237 for quick response. Let's keep an eye open for probable deploy blockers.

namhihi237 · 2024-01-08T03:51:06Z

@thienlnam PR updated

namhihi237 · 2024-01-08T03:55:00Z

Screen.Recording.2024-01-08.at.10.51.41.mov

Screen.Recording.2024-01-08.at.10.53.16.mov

Screen.Recording.2024-01-08.at.10.55.37.mov

thienlnam

Lovely, thanks!

OSBotify · 2024-01-08T05:16:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix crash attachment (cherry picked from commit cfdd159)

OSBotify · 2024-01-08T06:17:08Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.22-3 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-09T05:21:23Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra · 2024-02-02T03:17:25Z

    }

-    const isLocalFile = typeof path === 'number' || path.startsWith('blob:') || path.startsWith('file:');
+    const isLocalFile = typeof path === 'number' || path.startsWith('blob:') || path.startsWith('file:') || path.startsWith('/');


This PR created a problem with eReceipts that have pending waypoints. Issue #34287

fix set source and check local file

295ae98

namhihi237 mentioned this pull request Jan 5, 2024

[Awaiting Payment 26th Jane] [$500] PDF receipt doesn't load in the receipt modal #33412

Closed

6 tasks

namhihi237 marked this pull request as ready for review January 5, 2024 16:02

namhihi237 requested a review from a team as a code owner January 5, 2024 16:02

melvin-bot Bot requested review from 0xmiroslav and removed request for a team January 5, 2024 16:02

0xmiroslav approved these changes Jan 5, 2024

View reviewed changes

melvin-bot Bot requested a review from thienlnam January 5, 2024 16:05

0xmiroslav reviewed Jan 5, 2024

View reviewed changes

0xmiroslav approved these changes Jan 5, 2024

View reviewed changes

sobitneupane mentioned this pull request Jan 5, 2024

[$500] Distance - Receipt thumbnail is blank and is not clickable when request is made offline #34049

Closed

6 tasks

thienlnam mentioned this pull request Jan 8, 2024

[HOLD for payment 2024-01-17] Distance - 404 error appears in console after creating distance request #33985

Closed

6 tasks

fix condition check assets web

d9e75d5

thienlnam approved these changes Jan 8, 2024

View reviewed changes

thienlnam merged commit cfdd159 into Expensify:main Jan 8, 2024

OSBotify pushed a commit that referenced this pull request Jan 8, 2024

Merge pull request #34030 from namhihi237/fix-crash-attachment

6d0f75d

fix crash attachment (cherry picked from commit cfdd159)

github-actions Bot mentioned this pull request Jan 8, 2024

Deploy Checklist: New Expensify 2024-01-04 #33973

Closed

74 tasks

melvin-bot Bot mentioned this pull request Jan 10, 2024

[HOLD for payment 2024-01-17] Profile - Something went wrong error when trying to open a room/profile picture #34016

Closed

6 tasks

shubham1206agra reviewed Feb 2, 2024

View reviewed changes

shubham1206agra mentioned this pull request Feb 2, 2024

[HOLD for payment 2024-02-01] [$500] IOU – The receipt route image is blank after adding a stop in offline mode #34287

Closed

6 tasks

Conversation

namhihi237 commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 5, 2024

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xmiroslav commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024

Uh oh!

0xmiroslav commented Jan 5, 2024

Uh oh!

0xmiroslav commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

sobitneupane commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

namhihi237 commented Jan 5, 2024

Uh oh!

0xmiroslav commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobitneupane commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 5, 2024

Uh oh!

sobitneupane commented Jan 5, 2024

Uh oh!

namhihi237 commented Jan 8, 2024

Uh oh!

namhihi237 commented Jan 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 8, 2024

Uh oh!

OSBotify commented Jan 8, 2024

Uh oh!

OSBotify commented Jan 9, 2024

Uh oh!

namhihi237 commented Jan 5, 2024 •

edited

Loading

0xmiroslav commented Jan 5, 2024 •

edited

Loading

namhihi237 commented Jan 5, 2024 •

edited

Loading

namhihi237 commented Jan 5, 2024 •

edited

Loading

namhihi237 commented Jan 8, 2024 •

edited

Loading