Check if the policy contains only errors by WojtekBoman · Pull Request #35801 · Expensify/App

WojtekBoman · 2024-02-05T10:16:34Z

Details

This PR fixes the crash when we go to Settings/Overview page of a workspace we don't have access to.

Fix:

Screen.Recording.2024-02-05.at.12.27.21.mov

Fixed Issues

$ #35631
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Try to open this URL and check if the not-found page appears.
Verify that when you return to the workspace list screen, RBR on the Workspaces button is only visible if RBR is present on any workspace on the list.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

The video presenting the fix is attached in the details section.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-02-05T15:44:35Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2024-02-06T15:57:31Z

 function hasGlobalWorkspaceSettingsRBR(policies: OnyxCollection<Policy>, policyMembers: OnyxCollection<PolicyMembers>) {
-    const cleanPolicies = Object.fromEntries(Object.entries(policies ?? {}).filter(([, policy]) => !!policy));
+    // Check only valid policies
+    const cleanPolicies = Object.fromEntries(Object.entries(policies ?? {}).filter(([, policy]) => !!policy && policy.id));


How about replacing !!policy && policy.id with policy?.id ？
BTW, could you please explain if this change is necessary to fix the issue. 😂

@ntdiary Good point! I've added a more detailed explanation :D Could you please check this PR again?

ntdiary · 2024-02-07T15:14:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

35801-android-native.mp4

Android: mWeb Chrome

35801-android-chrome.mp4

iOS: Native

35801-ios-native.mp4

iOS: mWeb Safari

35801-ios-safari.mp4

MacOS: Chrome / Safari

35801-web.mp4

MacOS: Desktop

35801-desktop.mp4

ntdiary · 2024-02-07T15:20:32Z

@WojtekBoman, the final small thing, could you please add steps in Tests section and screenshots in Screenshots/Videos section ? I will fill the checklist soon. :)

WojtekBoman · 2024-02-07T16:30:51Z

@WojtekBoman, the final small thing, could you please add steps in Tests section and screenshots in Screenshots/Videos section ? I will fill the checklist soon. :)

The Tests section has already been filled out, I also added a video showing the fix in the details section and mentioned it in the Screenshots/Videos. Is this sufficient or should I attach a video for every platform?

ntdiary · 2024-02-07T17:08:16Z

@WojtekBoman, the final small thing, could you please add steps in Tests section and screenshots in Screenshots/Videos section ? I will fill the checklist soon. :)

The Tests section has already been filled out, I also added a video showing the fix in the details section and mentioned it in the Screenshots/Videos. Is this sufficient or should I attach a video for every platform?

@WojtekBoman, my bad, I missed them 😅. I'm new to the Ideal Nav feature, so I don't know much about it. And when I tested it on the mobile web, I found that the navigation can only be switched back and forth between the not found page and the workspace list page. However, this may be a separate issue that is beyond the scope of this PR. :)

35801-ios-safari.mp4

hayata-suenaga · 2024-02-08T16:26:02Z

@WojtekBoman could you link an issue on the OP?

WojtekBoman · 2024-02-12T10:05:00Z

@WojtekBoman could you link an issue on the OP?

Issue has been already linked in the PR description. Is it sufficient or should I link it elsewhere?

hayata-suenaga

non-blocking change requests to make comments more clear

hayata-suenaga

🟢

OSBotify · 2024-02-15T05:24:16Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

WojtekBoman added 2 commits February 5, 2024 11:13

Add checking if a policy contains only errors

ed1eee4

Fix hasGlobalWorkspaceSettingsRBR

34e4cba

WojtekBoman marked this pull request as ready for review February 5, 2024 15:44

WojtekBoman requested a review from a team as a code owner February 5, 2024 15:44

melvin-bot Bot removed the request for review from a team February 5, 2024 15:44

melvin-bot Bot requested a review from ntdiary February 5, 2024 15:44

ntdiary reviewed Feb 6, 2024

View reviewed changes

WojtekBoman added 2 commits February 7, 2024 10:15

Add docs to WorkspacesSettingsUtils

1d5db3f

Fix formattedCurrency checks

9cdc096

ntdiary approved these changes Feb 7, 2024

View reviewed changes

melvin-bot Bot requested a review from hayata-suenaga February 7, 2024 17:11

Merge branch 'main' into ideal-nav/workspace-not-found-fix

67a62b5

hayata-suenaga reviewed Feb 12, 2024

View reviewed changes

Comment thread src/libs/WorkspacesSettingsUtils.ts Outdated

hayata-suenaga reviewed Feb 12, 2024

View reviewed changes

Comment thread src/libs/WorkspacesSettingsUtils.ts Outdated

hayata-suenaga reviewed Feb 12, 2024

View reviewed changes

Comment thread src/pages/workspace/WorkspacePageWithSections.tsx Outdated

hayata-suenaga reviewed Feb 12, 2024

View reviewed changes

Refactor comments

c8e93e2

hayata-suenaga approved these changes Feb 13, 2024

View reviewed changes

hayata-suenaga merged commit e824f7d into Expensify:main Feb 13, 2024

github-actions Bot mentioned this pull request Feb 13, 2024

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

hayata-suenaga mentioned this pull request Feb 23, 2024

[Awaiting Payment] [Wave Collect] [Ideal Nav] App crashes when navigating to Settings/Overview page of a non-existent workspace #35631

Closed

6 tasks

Conversation

WojtekBoman commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 5, 2024

Uh oh!

ntdiary Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

WojtekBoman Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntdiary commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ntdiary commented Feb 7, 2024

Uh oh!

WojtekBoman commented Feb 7, 2024

Uh oh!

ntdiary commented Feb 7, 2024

Uh oh!

hayata-suenaga commented Feb 8, 2024

Uh oh!

WojtekBoman commented Feb 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WojtekBoman commented Feb 5, 2024 •

edited

Loading

WojtekBoman Feb 7, 2024 •

edited

Loading

ntdiary commented Feb 7, 2024 •

edited

Loading