Block edit assignee and mark as complete simultaneously #39397

tienifr · 2024-04-02T10:36:15Z

Details

Tapping assignee then marking the task as complete at the same time navigates to not found page. This PR applies singleExecution to those functions.

Fixed Issues

$ #38577
PROPOSAL: #38577 (comment)

Tests

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-02.at.17.37.04-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-04-02.at.17.38.32-compressed.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-04-04T02:31:31Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-04-04T22:32:14Z

@tienifr Can we please have videos for all platforms? I know this isn't reproducible on others, especially difficult on Web and Desktop.

mananjadhav

Waiting on screencasts for all platforms. Rest it works well.

tienifr · 2024-04-05T04:37:57Z

@mananjadhav @rlinoz Please hold up. I just found a critical issue when applying singleExecution context to the whole ReportScreen. Note that useWaitForNavigation should only be used when navigating by react-navigation:

App/src/hooks/useWaitForNavigation.ts

Lines 6 to 10 in 860998b

    
           /** 
        
            * Returns a promise that resolves when navigation finishes. 
        
            * Only use when navigating by react-navigation 
        
            */ 
        
           export default function useWaitForNavigation(): UseWaitForNavigation {

For functions that do not, the promise returned by waitForNavigate never resolves, causing isExecuting to always be true and thus disable all other MenuItem.

App/src/components/MenuItem.tsx

Line 447 in 860998b

disabled={disabled || isExecuting}

This issue only happens when one instance of singleExecution is shared between all components inside ReportScreen. Let me handle that and notify for review once ready.

mananjadhav · 2024-04-05T04:39:19Z

Thanks for notifying @tienifr.

mananjadhav · 2024-04-06T14:24:05Z

@tienifr any updates?

tienifr · 2024-04-08T11:02:47Z

I tried introducing a new prop shouldWaitForNavigation for MenuItem to denote whether to use waitForNavigate but what if inside onPress we conditionally use react-navigation. I think the best solution here is to move waitForNavigate out of MenuItem and just use it where needed.

App/src/components/MenuItem.tsx

Lines 411 to 412 in 860998b

    
           singleExecution( 
        
               waitForNavigate(() => {

But it takes time to find all the related places.

tienifr · 2024-04-10T10:42:36Z

@mananjadhav I pushed the changes and retested well. Please take a look.

mananjadhav · 2024-04-10T17:25:32Z

Thanks I'll check this tomorrow.

rlinoz · 2024-04-15T11:45:54Z

Hey @mananjadhav did you get a chance to check the latest updates here?

I will also review this today.

mananjadhav · 2024-04-15T12:02:37Z

I reviewed the changes, need to work on the checklist which I'll finish today.

mananjadhav · 2024-04-16T09:34:47Z

@rlinoz Can you please trigger the adhoc builds again? especially for Android.

github-actions · 2024-04-16T14:20:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39397/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39397/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39397/NewExpensify.dmg	https://39397.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz · 2024-04-16T15:09:21Z

In android native I'm not being able to hide the keyboard when pressing the back button on the description screen, but I think it is not related to this PR..

mananjadhav · 2024-04-16T15:09:51Z

Thanks for the builds. Testing it now.

mananjadhav · 2024-04-16T15:37:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-assignee-single-execution.mp4

Android: mWeb Chrome

mweb-chrome-assignee-single-execution.mp4

iOS: Native

ios-assignee-single-execution.mp4

iOS: mWeb Safari

mweb-safari-assign-single-execution.mp4

MacOS: Chrome / Safari

web-assign-single-execution.mov

MacOS: Desktop

desktop-assign-single-execution.mov

mananjadhav · 2024-04-16T15:59:26Z

In android native I'm not being able to hide the keyboard when pressing the back button on the description screen, but I think it is not related to this PR..

@rlinoz Yeah I came across this too. @tienifr Did you get this? Because I tested on production and it didn't have this behavior.

tienifr · 2024-04-17T08:55:53Z

@mananjadhav I pulled main and couldn't reproduce it. @rlinoz Could you trigger another build to verify if that issue disappeared?

github-actions · 2024-04-17T13:15:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39397/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://39397.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

rlinoz · 2024-04-17T13:26:30Z

Let me try again.

github-actions · 2024-04-17T13:58:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39397/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39397/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39397/NewExpensify.dmg	https://39397.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz · 2024-04-17T20:18:09Z

Looks like it is working fine in this last version.

rlinoz

Tests well, thanks

rlinoz · 2024-04-18T16:40:05Z

@mananjadhav can you complete the checklist, please?

mananjadhav · 2024-04-18T18:36:58Z

@rlinoz Just did. all yours.

OSBotify · 2024-04-18T18:47:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2024-04-22T20:44:31Z

This PR failing in mWeb with the existing fixed issue #38577
https://platform.applause.com/services/links/v1/external/a61dee551e4fca449c1fa289425e5960392f67e6cf923e20ea831945ef642758

rlinoz · 2024-04-22T21:33:11Z

Reverted the PR because I could reproduce the issue above and it was causing another blocker.

OSBotify · 2024-04-23T23:42:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

block executing assignee and mark as complete at the same time

3d12941

tienifr changed the title ~~Block executing assignee and mark as complete simultaneously~~ Block edit assignee and mark as complete simultaneously Apr 2, 2024

Merge branch 'main' into fix/38577

8f29eb8

tienifr marked this pull request as ready for review April 4, 2024 02:31

tienifr requested a review from a team as a code owner April 4, 2024 02:31

melvin-bot bot requested review from mananjadhav and removed request for a team April 4, 2024 02:31

mananjadhav approved these changes Apr 4, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz April 4, 2024 22:48

tienifr added 3 commits April 10, 2024 11:38

Merge branch 'main' of https://github.com/tienifr/App into fix/38577

cbc9857

Merge branch 'main' of https://github.com/tienifr/App into fix/38577

aea1f5a

use waitForNavigate where neccesary

34f0411

rlinoz added the Ready To Build label Apr 15, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' of https://github.com/tienifr/App into fix/38577

7a9ad47

Merge branch 'main' of https://github.com/tienifr/App into fix/38577

6ad3b7a

rlinoz approved these changes Apr 18, 2024

View reviewed changes

rlinoz merged commit e662e00 into Expensify:main Apr 18, 2024

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

ZhenjaHorbach mentioned this pull request Apr 22, 2024

[HOLD for payment 2024-05-02] Task - "Mark as complete' button grays out briefly when selecting Delete/Pin #40720

Closed

6 tasks

rlinoz mentioned this pull request Apr 22, 2024

[CP Staging] Revert "Block edit assignee and mark as complete simultaneously" #40729

Merged

50 tasks

Block edit assignee and mark as complete simultaneously #39397

Block edit assignee and mark as complete simultaneously #39397

Uh oh!

Conversation

tienifr commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 4, 2024

Uh oh!

mananjadhav commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Apr 5, 2024

Uh oh!

mananjadhav commented Apr 6, 2024

Uh oh!

tienifr commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Apr 10, 2024

Uh oh!

mananjadhav commented Apr 10, 2024

Uh oh!

rlinoz commented Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Apr 15, 2024

Uh oh!

This comment has been minimized.

mananjadhav commented Apr 16, 2024

Uh oh!

github-actions bot commented Apr 16, 2024

Uh oh!

rlinoz commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Apr 16, 2024

Uh oh!

mananjadhav commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Apr 16, 2024

Uh oh!

tienifr commented Apr 17, 2024

Uh oh!

github-actions bot commented Apr 17, 2024

Uh oh!

rlinoz commented Apr 17, 2024

Uh oh!

github-actions bot commented Apr 17, 2024

Uh oh!

rlinoz commented Apr 17, 2024

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Apr 18, 2024

Uh oh!

mananjadhav commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

kavimuru commented Apr 22, 2024

Uh oh!

rlinoz commented Apr 22, 2024

tienifr commented Apr 2, 2024 •

edited

Loading

mananjadhav commented Apr 4, 2024 •

edited

Loading

tienifr commented Apr 5, 2024 •

edited

Loading

tienifr commented Apr 8, 2024 •

edited

Loading

rlinoz commented Apr 15, 2024 •

edited

Loading

rlinoz commented Apr 16, 2024 •

edited

Loading

mananjadhav commented Apr 16, 2024 •

edited

Loading