Skip to content

[NoQA] Use periods at the end of error messages with ESLint check #39988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 19 commits into from
Apr 30, 2024
Merged

[NoQA] Use periods at the end of error messages with ESLint check #39988

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
53e97e3
Use periods at the end of error messages
ShridharGoel Apr 10, 2024
4a3822e
Use periods at the end of error messages
ShridharGoel Apr 10, 2024
f76a57d
Update package-lock.json
ShridharGoel Apr 10, 2024
b11176e
Update package.json
ShridharGoel Apr 10, 2024
fa80eac
Update to use 2.0.45
ShridharGoel Apr 10, 2024
981c453
Update en.ts
ShridharGoel Apr 10, 2024
36d3036
Update es.ts
ShridharGoel Apr 10, 2024
37b608b
Merge branch 'main' of https://github.com/Expensify/App into eslint_dots
ShridharGoel Apr 15, 2024
ced7a43
Merge branch 'eslint_dots' of https://github.com/ShridharGoel/Expensi…
ShridharGoel Apr 15, 2024
9b2fa94
Update
ShridharGoel Apr 15, 2024
4a8ff63
Update en.ts
ShridharGoel Apr 19, 2024
36549a8
Update es.ts
ShridharGoel Apr 19, 2024
5df30ad
Merge
ShridharGoel Apr 19, 2024
eac61ee
Enable
ShridharGoel Apr 19, 2024
2373860
Update
ShridharGoel Apr 19, 2024
83ba368
Merge branch 'main' into eslint_dots
ShridharGoel Apr 29, 2024
8133745
Update en.ts
ShridharGoel Apr 30, 2024
d4de57d
Update en.ts
ShridharGoel Apr 30, 2024
748a529
Fix lint
ShridharGoel Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@
"electron-builder": "24.13.2",
"eslint": "^7.6.0",
"eslint-config-airbnb-typescript": "^17.1.0",
"eslint-config-expensify": "^2.0.46",
"eslint-config-expensify": "^2.0.45",
Copy link
Contributor

@getusha getusha Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-config-expensify": "^2.0.45",
"eslint-config-expensify": "^2.0.46",

i think this should be 2.0.46 based on Expensify/eslint-config-expensify#88 (comment)

"eslint-config-prettier": "^8.8.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jest": "^24.1.0",
Expand Down
5 changes: 0 additions & 5 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,11 +941,6 @@ export default {
currentPassword: 'Current password',
newPassword: 'New password',
newPasswordPrompt: 'New password must be different than your old password, have at least 8 characters, 1 capital letter, 1 lowercase letter, and 1 number.',
error: {
currentPassword: 'Current password is required.',
newPasswordSameAsOld: 'New password must be different than your old password.',
newPassword: 'Your password must have at least 8 characters, 1 capital letter, 1 lowercase letter, and 1 number.',
},
},
twoFactorAuth: {
headerTitle: 'Two-factor authentication',
Expand Down
5 changes: 0 additions & 5 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,11 +939,6 @@ export default {
currentPassword: 'Contraseña actual',
newPassword: 'Nueva contraseña',
newPasswordPrompt: 'La nueva contraseña debe ser diferente de la antigua, tener al menos 8 caracteres, 1 letra mayúscula, 1 letra minúscula y 1 número.',
error: {
currentPassword: 'Contraseña actual es requerido.',
newPasswordSameAsOld: 'La nueva contraseña tiene que ser diferente de la antigua.',
newPassword: 'Su contraseña debe tener al menos 8 caracteres, 1 letra mayúscula, 1 letra minúscula y 1 número.',
},
},
twoFactorAuth: {
headerTitle: 'Autenticación de dos factores',
Expand Down