Fix app crash with optional chaining by Nodebrute · Pull Request #41293 · Expensify/App

Nodebrute · 2024-04-30T03:56:39Z

Details

Fixed Issues

$ #40481
PROPOSAL: #40481 (comment)

Tests

Test 1

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
In the URL, modify the workspace ID to an invalid string.

Test 2

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on Settings
In the URL, modify the workspace ID to an invalid string.

Test 3

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
Click on a rate, and the Edit Rate page will open.
In the URL, modify the workspace ID to an invalid string.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Test 1

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates Settings' and click on any distance rate to open the Right-Hand Panel.
In the URL, modify the workspace ID to an invalid string.

Test 2

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on Settings
In the URL, modify the workspace ID to an invalid string.

Test 3

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
Click on a rate, and the Edit Rate page will open.
In the URL, modify the workspace ID to an invalid string.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-04-30.at.9.40.35.AM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-04-30.at.9.28.01.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-30.at.9.01.37.AM.mov

Screen.Recording.2024-04-30.at.9.01.06.AM.mov

MacOS: Desktop

melvin-bot · 2024-04-30T03:56:44Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nodebrute · 2024-05-02T09:31:57Z

@ishpaul777 gentle bump

ishpaul777 · 2024-05-03T11:14:57Z

I will complete this today : )

ishpaul777 · 2024-05-03T11:15:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-09.at.12.04.06.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-05-08.at.11.21.38.PM.mov

iOS: Native

Screen.Recording.2024-05-05.at.12.02.23.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-05.at.12.26.46.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-04.at.11.mp4

MacOS: Desktop

Screen.Recording.2024-05-08.at.11.58.18.PM.mov

ishpaul777 · 2024-05-04T18:24:09Z

@Nodebrute can you please merge main

ishpaul777 · 2024-05-04T19:13:31Z

Bug: When using a random distance rate id in url it shows unusable page while it should show a not found page

Screen.Recording.2024-05-05.at.12.33.57.AM.mov

Nodebrute · 2024-05-05T12:31:33Z

@ishpaul777 Do you think we should fix this here? I feel it's unrelated to this ticket.

Nodebrute · 2024-05-05T12:34:02Z

@Nodebrute can you please merge main

Done.

ishpaul777 · 2024-05-05T20:39:56Z

Hey @Nodebrute How much effort do you think this would take to have not-found, i believe it should be straightforward isn't it? if we deliver it as it is, it will defintly caught while QA and might be considered a regression so if you think its straightforward lets fix it within the scope of this PR

Nodebrute · 2024-05-06T01:03:10Z

@ishpaul777 Apologies, I've fixed the issue on two pages PolicyDistanceRateDetailsPage and PolicyDistanceRateEditPage. Could you please test to see if there are any other bugs?

ishpaul777 · 2024-05-08T18:48:13Z

This bug is repro on main also so I dont think this is within the scope of this issue but when i go to random policy id on any WS setting page there is weird error which has a different root cause (this started happening recently)

Screen.Recording.2024-05-09.at.12.14.41.AM.mov

ishpaul777

otherwise LGTM!

OSBotify · 2024-05-13T21:10:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:13:23Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-05-16T20:02:53Z

Bug #40481 is still reproducible in web mweb and android

https://platform.applause.com/services/links/v1/external/ad1419479349fde42b6c3c5f18f5381f9711465e1ff34dfd2218435e66af1065

https://platform.applause.com/services/links/v1/external/a2a5351bcd459e38f9860b19b7b8479ea027bd196d50632932dc58504a5368f1

ishpaul777 · 2024-05-16T20:17:18Z

@Nodebrute Can you please take a look ^, its weird becuase it was working fine on dev

ishpaul777 · 2024-05-16T20:26:50Z

I can confirm this was fixed in this PR but this PR reintroduced it I think it should be a new issue @kavimuru

AndrewGable · 2024-05-20T21:41:10Z

I think we can just implement this as a follow up issue to the original issue

OSBotify · 2024-05-22T23:58:24Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix app crash with optional chaining

584ce1e

Nodebrute requested a review from a team as a code owner April 30, 2024 03:56

melvin-bot Bot removed the request for review from a team April 30, 2024 03:56

melvin-bot Bot requested a review from ishpaul777 April 30, 2024 03:56

npm run prettier

e4a0074

Nodebrute mentioned this pull request Apr 30, 2024

[$250] WS - App crashes when changing workspace ID to invalid ID while distance rate RHP is open #40481

Closed

6 tasks

This comment was marked as resolved.

Sign in to view

Merge branch 'Expensify:main' into invalidworkspace

ab8153c

Nodebrute added 2 commits May 6, 2024 05:46

show not found page on invalid id

a68edd2

on edit page show not found on invalid rate

165e181

lint fix

cd23f73

ishpaul777 approved these changes May 8, 2024

View reviewed changes

melvin-bot Bot requested a review from AndrewGable May 8, 2024 18:48

AndrewGable approved these changes May 13, 2024

View reviewed changes

AndrewGable merged commit c04628a into Expensify:main May 13, 2024

github-actions Bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

ishpaul777 mentioned this pull request May 22, 2024

Filter out rate with pending action #41997

Merged

50 tasks

Nodebrute deleted the invalidworkspace branch September 16, 2024 00:43

Conversation

Nodebrute commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 30, 2024

Uh oh!

Nodebrute commented May 2, 2024

Uh oh!

ishpaul777 commented May 3, 2024

Uh oh!

ishpaul777 commented May 3, 2024 • edited by AndrewGable Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

ishpaul777 commented May 4, 2024

Uh oh!

ishpaul777 commented May 4, 2024

Uh oh!

Nodebrute commented May 5, 2024

Uh oh!

Nodebrute commented May 5, 2024

Uh oh!

ishpaul777 commented May 5, 2024

Uh oh!

Nodebrute commented May 6, 2024

Uh oh!

ishpaul777 commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 13, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

kavimuru commented May 16, 2024

Uh oh!

ishpaul777 commented May 16, 2024

Uh oh!

ishpaul777 commented May 16, 2024

Uh oh!

AndrewGable commented May 20, 2024

Uh oh!

OSBotify commented May 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nodebrute commented Apr 30, 2024 •

edited

Loading

ishpaul777 commented May 3, 2024 •

edited by AndrewGable

Loading

ishpaul777 commented May 8, 2024 •

edited

Loading