Fix mark message from notification by wildan-m · Pull Request #41484 · Expensify/App

wildan-m · 2024-05-02T07:44:27Z

@ishpaul777

Details

Fix chat item not marked as read when clicked from desktop notification

Fixed Issues

$ #34829
PROPOSAL: #34829 (comment)

Tests

Open Access App
Login as User A
From the second device with account of User B sent a message to User A
User A received Notification
Wait until Notification goes to the Notification center
Open Notification center and click on this received notification
Verify chat item being marked after the chat opened

Important

In Development, mWeb and Native do not show notifications, we can only ensure the chat is marked as read after being opened (Step 6-7)

Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Kapture.2024-05-02.at.14.29.43.mp4

iOS: Native

Kapture.2024-05-02.at.14.32.40.mp4

iOS: mWeb Safari

Kapture.2024-05-02.at.14.16.48.mp4

MacOS: Chrome / Safari

Kapture.2024-05-02.at.14.13.21.mp4

MacOS: Desktop

Kapture.2024-05-02.at.14.06.19.mp4

…x-34829-mark-message-from-notification

melvin-bot · 2024-05-02T07:44:32Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-05-07T20:00:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

not affected

Android: mWeb Chrome

not affected

iOS: Native

not afftected

iOS: mWeb Safari

not affected

MacOS: Chrome / Safari

Screen.Recording.2024-05-08.at.1.54.46.AM.mov

MacOS: Desktop

Screen.Recording.2024-05-08.at.1.38.39.AM.mov

ishpaul777 · 2024-05-07T20:33:42Z

+            // On desktop, when the notification center is displayed, Visibility.isVisible() will return false.
+            // Currently, there's no programmatic way to dismiss the notification center panel.
+            // To handle this, we use the 'referrer' parameter to check if the current navigation is triggered from a notification.        const isFromNotification = (route?.params as {referrer?: string})?.referrer === 'notification';
+            const isFromNotification = (route?.params as {referrer?: string})?.referrer === 'notification';


can you please add referrer in route param type here

App/src/libs/Navigation/types.ts

Lines 52 to 56 in cec7224

[SCREENS.REPORT]: {

reportActionID: string;

reportID: string;

openOnAdminRoom?: boolean;

};

Sure. done.

we dont need type assertion anymore can you please remove it

Suggested change

const isFromNotification = (route?.params as {referrer?: string})?.referrer === 'notification';

const isFromNotification = route?.params?.referrer === 'notification';

Also can you please use constant for 'notification'

sure, done.

Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>

…x-34829-mark-message-from-notification

ishpaul777

LGTM!

blimpich · 2024-05-08T22:21:54Z

LGTM, going to hold until merge freeze is over though.

…x-34829-mark-message-from-notification

wildan-m · 2024-05-13T01:15:16Z

@blimpich where can we track if the merge freeze is over? Or is there an ETA?

ishpaul777 · 2024-05-13T14:00:37Z

We can merge this today when @blimpich is online

OSBotify · 2024-05-13T16:23:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:13:32Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-05-16T20:05:48Z

#34829 is still repro in iOS

https://platform.applause.com/services/links/v1/external/3721dcd6cea5badccfaf86de54e7a6dbcefa20e00257c0048d4529cfb2e9d73a

ishpaul777 · 2024-05-16T20:35:35Z

The PR never intended to fix this IOS, from the starting we asssumed (issue title and reproduced platforms was only Desktop) and specifically decided to fix for desktop.

wildan-m · 2024-05-17T00:53:47Z

@kavimuru agree with @ishpaul777.

Does it also occur on Android?

The same solution might work for iOS by adding this iOS-specific code, but I'm not sure how to test the native notification in development.

src/libs/actions/navigateFromNotification/index.ios.ts

import Navigation from '@libs/Navigation/Navigation';
import CONST from '@src/CONST';
import ROUTES from '@src/ROUTES';

const navigateFromNotification = (reportID: string) => {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID, undefined, CONST.REFERRER.NOTIFICATION));
};

export default navigateFromNotification;

If the above code is not working, the root cause might be different. Since that was not specified earlier, I believe the native issue should be handled separately.

kavimuru · 2024-05-17T13:57:44Z

I will ask the tester to test in android too who got the fail result in iOS. Android was tester by another tester.

chiragsalian · 2024-05-22T20:18:52Z

Checking off this issue in the checklist since the solution here is specific to desktop. If the issue exists elsewhere please create an issue we can discuss specific solutions.

OSBotify · 2024-05-22T23:58:33Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-08-22T18:13:14Z

+            if ((Visibility.isVisible() || isFromNotification) && scrollingVerticalOffset.current < MSG_VISIBLE_THRESHOLD) {
                Report.readNewestAction(report.reportID);
+                Navigation.setParams({referrer: undefined});


Coming from #45093 we should only set navigation param referrer to undefined when user is linked through notification

ZhenjaHorbach · 2024-09-06T13:32:58Z

+            // Currently, there's no programmatic way to dismiss the notification center panel.
+            // To handle this, we use the 'referrer' parameter to check if the current navigation is triggered from a notification.
+            const isFromNotification = route?.params?.referrer === CONST.REFERRER.NOTIFICATION;
+            if ((Visibility.isVisible() || isFromNotification) && scrollingVerticalOffset.current < MSG_VISIBLE_THRESHOLD) {


Coming from this issue
In most cases, Visibility.isVisible() returns the value that the app is not visible (inactive). It happens because of the leverage of outdated value.
As result chat is not marked as read (chat is bold) on LHN when opening a new message via notification and navigating to another chat.

So the more preferable value is to use isVisible in this screen

wildan-m added 8 commits April 25, 2024 12:51

Fix issue message unread from notification center panel

6023e76

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

d633d44

…x-34829-mark-message-from-notification

create specific platform file for navigateFromNotification

2d65227

fix prettier

4172369

fix typecheck

bed6027

make isFromNotification more readable

1a806f1

Add comment about referrer param

05cadb2

restore accidentally removed code

97c81cf

wildan-m requested a review from a team as a code owner May 2, 2024 07:44

melvin-bot Bot removed the request for review from a team May 2, 2024 07:44

melvin-bot Bot requested a review from ishpaul777 May 2, 2024 07:44

wildan-m mentioned this pull request May 2, 2024

[HOLD for payment 2024-05-30] [$500] Desktop - Chat isn't marked as read if user clicks on notification from Notification Center #34829

Closed

6 tasks

wildan-m added 3 commits May 2, 2024 15:09

fix typecheck

f58c570

fix prettier and typecheck

484249d

restore accidentaly removed code

df6fddb

ishpaul777 reviewed May 7, 2024

View reviewed changes

Comment thread src/pages/home/report/ReportActionsList.tsx Outdated

ishpaul777 reviewed May 7, 2024

View reviewed changes

wildan-m and others added 5 commits May 8, 2024 07:11

Update src/pages/home/report/ReportActionsList.tsx

e66807f

Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>

Add referrer to report screen type

a9a5840

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

4057c0d

…x-34829-mark-message-from-notification

Change 'notification' to const

6b88b0f

run prettier

b2f651b

ishpaul777 approved these changes May 8, 2024

View reviewed changes

melvin-bot Bot requested a review from blimpich May 8, 2024 21:19

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

1ad9964

…x-34829-mark-message-from-notification

blimpich approved these changes May 13, 2024

View reviewed changes

blimpich merged commit 5627349 into Expensify:main May 13, 2024

gedu mentioned this pull request May 14, 2024

[HOLD for payment 2024-07-10] [$500] critical: Chat is not marked as read when receiving a message being in the chat #40152

Closed

6 tasks

github-actions Bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

ishpaul777 reviewed Aug 22, 2024

View reviewed changes

ishpaul777 mentioned this pull request Aug 22, 2024

mWeb - Chat scrolls back to linked message after receiving new message #45093

Closed

6 tasks

ZhenjaHorbach reviewed Sep 6, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Sep 6, 2024

[$250] Android – Chat is not marked as read when open message via notification #46235

Closed

6 tasks

	[SCREENS.REPORT]: {
	reportActionID: string;
	reportID: string;
	openOnAdminRoom?: boolean;
	};

	const isFromNotification = (route?.params as {referrer?: string})?.referrer === 'notification';
	const isFromNotification = route?.params?.referrer === 'notification';

Conversation

wildan-m commented May 2, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 2, 2024

Uh oh!

ishpaul777 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

ishpaul777 May 7, 2024

Choose a reason for hiding this comment

Uh oh!

wildan-m May 8, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 May 8, 2024

Choose a reason for hiding this comment

Uh oh!

wildan-m May 8, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented May 8, 2024

Uh oh!

wildan-m commented May 13, 2024

Uh oh!

ishpaul777 commented May 13, 2024

Uh oh!

OSBotify commented May 13, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

kavimuru commented May 16, 2024

Uh oh!

ishpaul777 commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wildan-m commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kavimuru commented May 17, 2024

Uh oh!

chiragsalian commented May 22, 2024

Uh oh!

OSBotify commented May 22, 2024

Uh oh!

ishpaul777 Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Sep 6, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ishpaul777 commented May 7, 2024 •

edited

Loading

ishpaul777 commented May 16, 2024 •

edited

Loading

wildan-m commented May 17, 2024 •

edited

Loading