[Wave Collect][Xero][Advanced] Bill Payment Account Selector by mananjadhav · Pull Request #41690 · Expensify/App

mananjadhav · 2024-05-06T17:36:21Z

Details

Fixed Issues

$ #39751
$ #41754
PROPOSAL:

Tests

Precondition:

Workspace with Xero connection and has Bank accounts.

Test steps

Go to Workspace > Accounting > Advance > Xero Bill Payment Account.
Verify that you see the accounts from the Xero Bank accounts list.
Click on any bank account.
Verify It displays the correct bank account name under Xero Bill Payment Account in Advance page.

Verify that no errors appear in the JS console

Offline tests

Same as Test steps

QA Steps

Same as Test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-xero-bill-payment-account.mov

Android: mWeb Chrome

mweb-bill-payment-account-selector.mov

iOS: Native

ios-xero-bill-payment-account.mov

iOS: mWeb Safari

mweb-safari-xero-bill-payment-account.mov

MacOS: Chrome / Safari

web-advanced-bill-payment.mov

MacOS: Desktop

desktop-xero-bill-payment-account.mov

mananjadhav · 2024-05-06T19:58:10Z

~~I am going to mark this ready for review as only Android mobile web is pending.~~ Android mWeb is uploaded.

melvin-bot · 2024-05-06T19:58:15Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…bill-payment-account

rushatgabhane · 2024-05-07T07:25:42Z

@Expensify/design please provide design feedback. Thank you! :)

hungvu193 · 2024-05-07T07:34:15Z

+            displayName={XeroBillPaymentAccountSelectorPage.displayName}
+            sections={[{data: xeroSelectorOptions}]}
+            listItem={RadioListItem}
+            shouldBeBlocked={!syncReimbursedReports}


NAB, we should also add more condition here to address the case when Xero is disconnected

const connectedIntegration = accountingIntegrations.find((integration) => !!policy?.connections?.[integration]) ?? connectionSyncProgress?.connectionName; const policyConnectedToXero = connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.XERO;

shouldBeBlocked={!syncReimbursedReports || !policyConnectedToXero}

We can do this as a follow up since we will need to update other screens as well.

Agreed. This is required in all the screens.

hungvu193 · 2024-05-07T07:41:41Z

+    const selectedBillPaymentAccountName = useMemo(() => {
+        const selectedAccount = (bankAccounts ?? []).find((bank) => bank.id === reimbursementAccountID);
+
+        return selectedAccount?.name ?? '';
+    }, [bankAccounts, reimbursementAccountID]);


NAB, both selectedBillPaymentAccountName and selectedBankAccountName have the same logic. Should we reuse it by creating a new function and passing reimbursementAccountID or invoiceCollectionsAccountID as a parameter?

I think it can be like this:

const getSelectedBankAccount = useMemo((bankAccountId) => { const selectedAccount = (bankAccounts ?? []).find((bank) => bank.id === bankAccountId); return selectedAccount?.name ?? ''; }, [bankAccounts]);

Agreed, will update.

I've created an issue for that, and will handle it once this PR gets merged.

Updated to common useMemo

lakchote · 2024-05-07T08:13:06Z

Hola, we need Spanish translations!

English translation:
xeroBillPaymentAccountDescription: "As you've enabled sync reimbursed reports, you will need to select the bank account your reimbursements are coming out of, and we'll create the payment in Xero.",

DeepL spanish translation:
xeroBillPaymentAccountDescription: "Como has activado la sincronización de los informes de reembolso, tendrás que seleccionar la cuenta bancaria de la que saldrán tus reembolsos y crearemos el pago en Xero.",

Does this look correct to you?

hungvu193 · 2024-05-07T08:20:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-07.at.15.29.13.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-05-07.at.15.19.25.mov

iOS: mWeb Safari

Screen.Recording.2024-05-07.at.15.17.33.mov

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desk.mov

shawnborton · 2024-05-07T13:16:17Z

Design-wise I think this looks pretty good!

hungvu193

Only one small change left. Tested well!

melvin-bot · 2024-05-07T13:51:37Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #39751 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…bill-payment-account

mananjadhav · 2024-05-07T15:54:09Z

@hungvu193 @lakchote @hayata-suenaga I've updated the PR and also fixed the Chart of Accounts padding.

mananjadhav · 2024-05-07T15:55:51Z

@pecanoro The translations have been updated. Can you take a final look?

rushatgabhane · 2024-05-08T09:27:49Z

@mananjadhav because of merge freeze, could you please switch the PR target to xero-merge-freeze

mananjadhav · 2024-05-08T09:51:54Z

@rushatgabhane done.

pecanoro · 2024-05-08T14:11:12Z

@lakchote All yours!

hayata-suenaga · 2024-05-08T18:17:56Z

@hungvu193 @lakchote @hayata-suenaga I've updated the PR and also fixed the Chart of Accounts padding.

you fixed this one, right in this PR? thanks!

mananjadhav · 2024-05-08T18:48:50Z

Yes @hayata-suenaga

OSBotify · 2024-05-15T10:14:20Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-22T23:59:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 5 commits May 6, 2024 22:48

feat: screen and nav setup

6a40b76

feat: connect page

9352393

feat: page setup with api call

295cbf2

feat: advanced page current selection

d3ca32f

style: prettier fix

6a0b68b

mananjadhav marked this pull request as ready for review May 6, 2024 19:58

mananjadhav requested a review from a team as a code owner May 6, 2024 19:58

melvin-bot Bot requested review from alitoshmatov and removed request for a team May 6, 2024 19:58

Merge branch 'main' of github.com:mananjadhav/App into xero-advanced-…

b4c8f72

…bill-payment-account

hungvu193 reviewed May 7, 2024

View reviewed changes

pecanoro requested changes May 7, 2024

View reviewed changes

Comment thread src/languages/es.ts Outdated

hungvu193 approved these changes May 7, 2024

View reviewed changes

mananjadhav added 5 commits May 7, 2024 21:08

fix: spanish translation

c839dc8

refactor: merge usememo

d0b31f2

Merge branch 'main' of github.com:mananjadhav/App into xero-advanced-…

dc2e2ce

…bill-payment-account

fix: qbo charge of accounts padding

9281743

refactor: prettier fixes

75145eb

mananjadhav requested review from lakchote and pecanoro May 7, 2024 15:55

mananjadhav mentioned this pull request May 7, 2024

[QBO] Chart of accounts page does not fit in RHP properly #41754

Closed

6 tasks

pecanoro approved these changes May 8, 2024

View reviewed changes

mananjadhav changed the base branch from main to xero-merge-freeze May 8, 2024 09:51

lakchote approved these changes May 9, 2024

View reviewed changes

lakchote merged commit e8df050 into Expensify:xero-merge-freeze May 9, 2024

github-actions Bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

Conversation

mananjadhav commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented May 6, 2024

Uh oh!

rushatgabhane commented May 7, 2024

Uh oh!

hungvu193 May 7, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 7, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 May 7, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 7, 2024

Choose a reason for hiding this comment

Uh oh!

lakchote May 7, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 7, 2024

Choose a reason for hiding this comment

Uh oh!

lakchote commented May 7, 2024

Uh oh!

hungvu193 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

shawnborton commented May 7, 2024

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 7, 2024

Uh oh!

mananjadhav commented May 7, 2024

Uh oh!

mananjadhav commented May 7, 2024

Uh oh!

rushatgabhane commented May 8, 2024

Uh oh!

mananjadhav commented May 8, 2024

Uh oh!

pecanoro commented May 8, 2024

Uh oh!

hayata-suenaga commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented May 8, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

OSBotify commented May 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mananjadhav commented May 6, 2024 •

edited

Loading

mananjadhav commented May 6, 2024 •

edited

Loading

hungvu193 commented May 7, 2024 •

edited

Loading

hayata-suenaga commented May 8, 2024 •

edited

Loading