Send an invoice from an invoice room by VickyStash · Pull Request #41902 · Expensify/App

VickyStash · 2024-05-09T12:38:03Z

Details

The PR enables an invoice sending from an invoice room.

Fixed Issues

$ #41878
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open an existing invoice room where you are an admin of the invoice sender workspace.
Tap "+" button in the chat input, make sure Send invoice feature is available.
Tap Send Invoice -> Enter Amount -> Next.
Make sure you are navigated to the confirmation screen.
To and Send from fields should be filled with Invoice receiver and Invoice sender. It shouldn't be possible to update them.
Tap Send Invoice button, make sure the new invoice is successfully created.
Open an existing invoice room where you are an invoice receiver. Make sure that Send Invoice option is not available for you.

Offline tests

Same as in the Tests section

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

VickyStash · 2024-05-10T08:41:07Z

NOTE: there is a known issue which makes an invoice disappear right after creation

melvin-bot · 2024-05-10T09:40:30Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2024-05-10T14:40:47Z

Can we make the icon for Send invoice in the room create menu match the one in the global create menu?

Global Create	Room Menu (this PR)

Other than that this seems to be looking pretty good and working well.

VickyStash · 2024-05-10T15:16:25Z

@dannymcclain Thank you, done!

shawnborton · 2024-05-13T00:31:19Z

Good catch Danny, I agree with that one.

VickyStash · 2024-05-13T06:28:31Z

@akinwale when can you take a look at this PR?

akinwale · 2024-05-13T06:39:15Z

@akinwale when can you take a look at this PR?

I'll review today.

akinwale · 2024-05-13T12:42:29Z

@VickyStash Please fix merge conflicts.

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

VickyStash · 2024-05-13T13:20:10Z

@akinwale Done

akinwale · 2024-05-14T06:18:57Z

@VickyStash There's another merge conflict that needs to be fixed. I've finished testing and will post the checklist within the next few hours.

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/IOU.ts

VickyStash · 2024-05-14T07:15:26Z

@akinwale conflicts are resolved 🙂

dannymcclain

The compose menu is looking good, and overall this is working well.

One odd thing I found is that when I go to create an invoice from the compose menu, on the creation screen, in the To field, both avatars are hoverable and if I click on the row, the room details open.

CleanShot.2024-05-14.at.09.54.26.mp4

I would expect that row to be completely non-interactive, like the From row is. So no ability to hover over the avatars, no hover state on the row, and no details pane when I click. cc @Expensify/design for a gut check on that though. It just feels a little odd how it is right now?

VickyStash · 2024-05-14T15:09:53Z

@dannymcclain

One odd thing I found is that when I go to create an invoice from the compose menu, on the creation screen, in the To field, both avatars are hoverable and if I click on the row, the room details open.

We have the same behaviour if user Submit Expense from workspace room for example, see the video:

EXAMPLE.mp4

But I'm okay to disable it for invoices if needed 👌

dannymcclain · 2024-05-14T15:13:33Z

Ah ok thanks. If that's how it works for submitting expenses on a workspace let's not mess with that behavior here. It would be better to have an issue specifically to address that behavior in all the different circumstances if we want to change it. I personally don't really think we need to deal with it right this second though.

dannymcclain

Design-wise this looks good. Should definitely still get a solid engineering review though.

shawnborton · 2024-05-14T15:18:11Z

That's a great observation Danny - I agree with where you all landed. I think it's worth having a quick Slack conversation about that behavior, I agree it does feel a bit odd to be able to navigate to the workspace details from here.

VickyStash · 2024-05-14T15:31:51Z

@akinwale kind bump :)

akinwale · 2024-05-14T19:46:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

41902-web.mp4

41902-web-receiver.mp4

MacOS: Desktop

akinwale

LGTM.

OSBotify · 2024-05-15T03:07:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:15:11Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-23T00:00:12Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 4 commits May 9, 2024 14:30

Enable invoice creation from invoice room

acfe833

Fix options display for invoice receiver

c72355e

Fix invoice receivers preview

ecb0955

Display chat as a receiver if user send invoice from existing room

ac74e8d

VickyStash marked this pull request as ready for review May 10, 2024 09:40

VickyStash requested a review from a team as a code owner May 10, 2024 09:40

melvin-bot Bot requested review from akinwale and removed request for a team May 10, 2024 09:40

VickyStash mentioned this pull request May 10, 2024

[HOLD for payment 2024-05-29][$250] [VIP] Send an invoice from an invoice room #41878

Closed

dannymcclain requested a review from a team May 10, 2024 14:38

Update send invoice icon to match global create

6135702

VickyStash added 2 commits May 13, 2024 14:50

Merge branch 'main' into feature/send-invoice-from-room

827b26f

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

Enable invoice room option on the confirmation screen

ac13964

Merge branch 'main' into feature/send-invoice-from-room

0c0952d

# Conflicts: # src/libs/ReportUtils.ts # src/libs/actions/IOU.ts

dannymcclain requested changes May 14, 2024

View reviewed changes

dannymcclain self-requested a review May 14, 2024 15:13

dannymcclain approved these changes May 14, 2024

View reviewed changes

akinwale approved these changes May 14, 2024

View reviewed changes

melvin-bot Bot requested a review from cristipaval May 14, 2024 19:46

cristipaval approved these changes May 15, 2024

View reviewed changes

cristipaval merged commit edd1719 into Expensify:main May 15, 2024

github-actions Bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

Conversation

VickyStash commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash commented May 10, 2024

Uh oh!

melvin-bot Bot commented May 10, 2024

Uh oh!

dannymcclain commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VickyStash commented May 10, 2024

Uh oh!

shawnborton commented May 13, 2024

Uh oh!

VickyStash commented May 13, 2024

Uh oh!

akinwale commented May 13, 2024

Uh oh!

akinwale commented May 13, 2024

Uh oh!

VickyStash commented May 13, 2024

Uh oh!

akinwale commented May 14, 2024

Uh oh!

VickyStash commented May 14, 2024

Uh oh!

dannymcclain left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented May 14, 2024

Uh oh!

dannymcclain commented May 14, 2024

Uh oh!

dannymcclain left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented May 14, 2024

Uh oh!

VickyStash commented May 14, 2024

Uh oh!

akinwale commented May 14, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

OSBotify commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VickyStash commented May 9, 2024 •

edited

Loading

dannymcclain commented May 10, 2024 •

edited

Loading