Skip to content

Playing video is not paused when opening attachment modal. #40735 #42157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiragsalian merged 3 commits into from
May 23, 2024
Merged

Playing video is not paused when opening attachment modal. #40735 #42157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c43bc8e
fix issue
superdev100 May 14, 2024
6b6fbc2
lint check
superdev100 May 14, 2024
03b03d8
update comment
superdev100 May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/components/VideoPlayer/BaseVideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,22 +214,25 @@ function BaseVideoPlayer({
return;
}

// If we are uploading a new video, we want to immediately set the video player ref.
// If we are uploading a new video, we want to pause previous playing video and immediately set the video player ref.
if (currentVideoPlayerRef.current) {
pauseVideo();
}
currentVideoPlayerRef.current = videoPlayerRef.current;
}, [url, currentVideoPlayerRef, isUploading]);
}, [url, currentVideoPlayerRef, isUploading, pauseVideo]);

const isCurrentlyURLSetRef = useRef<boolean>();
isCurrentlyURLSetRef.current = isCurrentlyURLSet;

useEffect(
() => () => {
if (!isCurrentlyURLSetRef.current) {
if (shouldUseSharedVideoElement || !isCurrentlyURLSetRef.current) {
return;
}

setCurrentlyPlayingURL(null);
},
[setCurrentlyPlayingURL],
[setCurrentlyPlayingURL, shouldUseSharedVideoElement],
);
// update shared video elements
useEffect(() => {
Expand Down