Fix canShowHeader logic by janicduplessis · Pull Request #42332 · Expensify/App

janicduplessis · 2024-05-17T04:12:28Z

Details

I noticed that the loading indicator for loading new messages is not displayed.

I traced it back to this commit which refactored the logic to a variable, but incorrectly.

It changed

if (!isOffline && !hasHeaderRendered.current) {

to

const canShowHeader = !isOffline && !hasHeaderRendered.current;
...
if (!canShowHeader) {

The correct change is:

const canShowHeader = isOffline || hasHeaderRendered.current;
...
if (!canShowHeader) {

When testing on iOS I also noticed the scrollingVerticalOffset check was preventing the loading indicator from showing some times. I don't see why it would be needed and didn't seem to introduce any problem when testing loading other chats.

After this the header now shows correctly on 2nd render as the code was meant to do.

Before

Screen.Recording.2024-05-16.at.23.59.11.mov

After

Screen.Recording.2024-05-17.at.00.08.58.mov

Fixed Issues

$ #42331
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Test comment linking and see that loading newer messages now display a loading indicator

Offline tests

QA Steps

Verify that no errors appear in the JS console
Test comment linking and see that loading newer messages now display a loading indicator

Steps to test comment linking:

Go in a long chat and scroll to an old message
Right click and "Copy link"
Go in another chat and paste the link
Clear the cache (Account Settings -> Troubleshoot -> Clear cache and restart)
Go back to the chat with the link and click it
You will be in the middle of a chat and can test loading older / newer messages

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-05-17.at.01.04.44.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-17.at.00.08.58.mov

MacOS: Desktop

melvin-bot · 2024-05-17T04:12:33Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

janicduplessis · 2024-05-17T05:13:03Z

@perunt Would you be able to confirm this change is ok since you wrote that code initially?

janicduplessis · 2024-05-17T05:14:09Z

I also noticed on iOS there seems to be an issue where newer messages don't load initially unless you scroll back up a little, you can see in the video in the screenshots section. I will investigate that in a follow up.

jayeshmangwani · 2024-05-19T21:33:59Z

@janicduplessis Is this a follow-up PR of any other PR?

janicduplessis · 2024-05-20T02:36:32Z

I found the issue while working on #40610, but it is not directly related.

jayeshmangwani · 2024-05-20T13:50:17Z

@rojiphil This PR is somewhat related to this PR #40610, Would you complete the checklist here, or should I start the review?

rojiphil · 2024-05-20T16:40:58Z

I traced it back to this commit which refactored the logic to a variable, but incorrectly.

@janicduplessis From the PR description it looks like the root cause lies elsewhere and is unrelated to PR #40610.

rojiphil · 2024-05-20T16:41:19Z

Would you complete the checklist here, or should I start the review?

@jayeshmangwani Please go ahead if you are available here. I am not sure if I can get to this in the next 2-3 days.

mountiny · 2024-05-20T19:45:36Z

@jayeshmangwani Please go ahead with this PR

jayeshmangwani · 2024-05-21T07:19:05Z

On it...

jayeshmangwani · 2024-05-21T14:12:54Z

@janicduplessis Is there any way to test the Android loader? I have tried with the Steps in the Tests and deep link, but not able to see the Loader for Android native

Android_compressed.mp4

jayeshmangwani · 2024-05-22T13:50:29Z

Is there any way to test the Android loader? I have tried with the Steps in the Tests and deep link, but not able to see the Loader for Android native

@janicduplessis

mountiny · 2024-05-23T10:17:37Z

Running a build @janicduplessis are you able to help @jayeshmangwani please?

github-actions · 2024-05-23T10:50:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42332/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42332/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42332/NewExpensify.dmg	https://42332.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

janicduplessis · 2024-05-23T22:39:57Z

@jayeshmangwani The seems to be another issue on mobile where the newer messages are not loading unless you scroll up some. Does it work if you try to scroll up for about 1-2 screens of height then scroll back down?

janicduplessis · 2024-05-23T22:40:15Z

I will try to look at that issue next.

jayeshmangwani · 2024-05-24T14:56:25Z

Does it work if you try to scroll up for about 1-2 screens of height then scroll back down?

Now, After trying several times, I am able to show the loader a few times

jayeshmangwani · 2024-05-24T15:31:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2024-05-24T15:33:29Z

Code changes looks good, and Tests Well.

NAB: Videos are missing for some platforms

mountiny

Thank you, asking to get this merged!

OSBotify · 2024-05-28T13:54:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:43:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:26:34Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:38:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix canShowHeader logic

7a4dc77

janicduplessis requested a review from a team as a code owner May 17, 2024 04:12

melvin-bot Bot requested review from jayeshmangwani and removed request for a team May 17, 2024 04:12

janicduplessis mentioned this pull request May 17, 2024

Handle pagination errors in chats #40610

Merged

54 tasks

Remove scroll position check

ca83b39

mountiny assigned janicduplessis May 20, 2024

mountiny added the Ready To Build label May 23, 2024

jayeshmangwani approved these changes May 24, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny May 24, 2024 15:31

jayeshmangwani approved these changes May 25, 2024

View reviewed changes

mountiny approved these changes May 28, 2024

View reviewed changes

mountiny merged commit 96425fa into Expensify:main May 28, 2024

github-actions Bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

sonialiap mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-06] [$250] Loading indicator is not shown when loading newer messages #42331

Closed

6 tasks

jayeshmangwani referenced this pull request Jun 6, 2024

move pagination size to getInitialPaginationSize

4f4a2c2

Conversation

janicduplessis commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Before

After

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 17, 2024

Uh oh!

janicduplessis commented May 17, 2024

Uh oh!

janicduplessis commented May 17, 2024

Uh oh!

jayeshmangwani commented May 19, 2024

Uh oh!

janicduplessis commented May 20, 2024

Uh oh!

jayeshmangwani commented May 20, 2024

Uh oh!

rojiphil commented May 20, 2024

Uh oh!

rojiphil commented May 20, 2024

Uh oh!

mountiny commented May 20, 2024

Uh oh!

jayeshmangwani commented May 21, 2024

Uh oh!

jayeshmangwani commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani commented May 22, 2024

Uh oh!

mountiny commented May 23, 2024

Uh oh!

github-actions Bot commented May 23, 2024

Uh oh!

janicduplessis commented May 23, 2024

Uh oh!

janicduplessis commented May 23, 2024

Uh oh!

jayeshmangwani commented May 24, 2024

Uh oh!

jayeshmangwani commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented May 24, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 28, 2024

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

janicduplessis commented May 17, 2024 •

edited

Loading

jayeshmangwani commented May 21, 2024 •

edited

Loading

jayeshmangwani commented May 24, 2024 •

edited

Loading