Search result duplication by gedu · Pull Request #43164 · Expensify/App

gedu · 2024-06-06T09:33:16Z

Details

Fixed Issues

$ #43094
PROPOSAL: #43094 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Case 1:

Create Workspace as Alice
Add couple members including Bob
Create couple rooms on that workspace
Sign into an Bob's account
Search for the rooms created
One rooms should appear, never duplicated

Case 2:

Create a Workspace with any name, like Testin1234
Search for a Room in that workspace
Change the name of the created Workspace, like Testing
Search for the Room again
The workspace name should be updated

PR Author Checklist

Screenshots/Videos

Android: Native

duplicateSearch_android.mp4

Android: mWeb Chrome

duplicateSearch_androidChrome.mp4

iOS: Native

duplicateSearch_ios.mp4

iOS: mWeb Safari

duplicateSearch_iosSafari.mp4

MacOS: Chrome / Safari

duplicateSearch_chrome.mp4

duplicateSearch_safari.mp4

MacOS: Desktop

duplicateSearch_desktop.mp4

…he errors from success

melvin-bot · 2024-06-12T13:14:44Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2024-06-12T16:48:06Z

            value: {
-                errorFields: {
-                    notFound: null,
-                },


I think you commit this change by false.

Yeah, sorry I should add a comment on the PR, this change is because of this discussion: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1717509334788509?thread_ts=1717508731.782149&cid=C05LX9D6E07

I didn't have access to this channel. Is there is any test steps for it?

No, it was a bug that happen to David, and with @mountiny didn't know well how it happens. But it seems that not all the errors were cleaned up successfully.

@gedu this change seems wrong and is incorrectly clearing all report errors. I'm intending on reverting it. I'm not sure which issue you were trying to fix with this change (I don't have access to that slack conversation either) but this is probably not the right way to fix it.

ahmedGaber93 · 2024-06-13T11:44:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

20240613150721241.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

ahmedGaber93 · 2024-06-13T11:48:02Z

@gedu Could you please add tests step?

ahmedGaber93

LGTM!

Beamanator · 2024-06-13T16:30:25Z

Sorry is this still WIP or ready for final review?

ahmedGaber93 · 2024-06-13T19:10:58Z

@Beamanator, it is ready for final review

jasperhuangg · 2024-06-14T02:47:05Z

Hey @ahmedGaber93 @Beamanator @gedu Looks like you're removing a good amount of logic from #40730, let's make sure we repeat the testing steps from that PR to verify we're not causing any regressions 🙇

Open app.

Create a new account

Go to your space

Create a manual track expense

Click on Categorize it

Click on Learn more and create a new workspace

Go to your space and click on Categorize it again

Verify the newly created workspace should show up

Beamanator

Questions about test steps:

Sign into an account off Bob means "Sign in to Bob's account", right?
One rooms should appear -> "One room should appear for each result, never duplicated"
Create a Workspace as Testin1234 -> Is that a specific username or email? Why is that needed? Or is this the name of the workspace? If it's just a random name, maybe say "Create a Workspace with any name, like Testin1234"
I don't see any specific tests for the error message cleanup, is one of the existing tests specifically for making sure the error messages work better?

@gedu I also don't see any videos of you testing other than MacOS: Chrome / Safari.

Also @gedu it looks like your branch https://github.com/callstack-internal/Expensify-App/tree/gedu/43094_duplicate_search_result is 1.5k commits behind E/App main, can you pull in main so we can make sure this is being tested with most up to date code? 🙏

And finally, I agree with @jasperhuangg can we get some more test steps to cover changes from this PR (#40730) so we make sure there's no regressions?

gedu · 2024-06-14T08:54:43Z

Questions about test steps:

Sign into an account off Bob means "Sign in to Bob's account", right?

One rooms should appear -> "One room should appear for each result, never duplicated"

Create a Workspace as Testin1234 -> Is that a specific username or email? Why is that needed? Or is this the name of the workspace? If it's just a random name, maybe say "Create a Workspace with any name, like Testin1234"

I don't see any specific tests for the error message cleanup, is one of the existing tests specifically for making sure the error messages work better?

Yes, Bob's account or any account you have.
Yep, never duplicated
Yes, any name I can rephrase it
For the error not sure how to reproduce it, happen to David once

@gedu I also don't see any videos of you testing other than MacOS: Chrome / Safari.

For Chorme and Safari are there, I will record for the other platforms

Also @gedu it looks like your branch https://github.com/callstack-internal/Expensify-App/tree/gedu/43094_duplicate_search_result is 1.5k commits behind E/App main, can you pull in main so we can make sure this is being tested with most up to date code? 🙏

Yes, on may way

And finally, I agree with @jasperhuangg can we get some more test steps to cover changes from this PR (#40730) so we make sure there's no regressions?

Adding them

gedu · 2024-06-14T11:34:00Z

@Beamanator @jasperhuangg
I was looking into PR, isn't working for me in local but also isn't working on prod:

Screen.Recording.2024-06-14.at.13.32.57.mov

ahmedGaber93 · 2024-06-14T12:52:37Z

I think this PR changes shouldn't case regression here #43164 (comment)

Looks like you're removing a good amount of logic from #40730

we arn't use missingReportIds now because this useEffect will create the whole list items when any count of items are updated/added/removed. this because PR #41636 remove the return early in the useEffect when no item need to updated like add/remove cases, that make it cover updated/added/removed.

@gedu PR just remove the second useEffect as no need for it now (the first useEffect handling its job now) . the only bad effect is the performance and we disscuss it in the issue page and in slack here but not found any way can help us keep the performance before #41636 changes.

ahmedGaber93 · 2024-06-14T13:02:19Z

I confirm @gedu test for #43164 (comment), we have other issue here IOU steps not ask to create a new workspace. (tested in latest main)

20240614155913197.mp4

gedu · 2024-06-14T15:01:12Z

Added videos for all the platforms

ahmedGaber93 · 2024-06-14T19:54:55Z

is 1.5k commits behind E/App main

@gedu Please merge main into your branch

I think we can simplify test steps to

Open the App
Click Account Settings > Workspaces > and create new workspace
Click fab icon > Start chat > Room tab
Fill room name and select the workspace you create it in step 1 then click create room
Open Search page and Verify that the room you created in step 4 appear once in search result
Click Account Settings > Workspaces > open the workspace you create it step 1
Edit the workspace name
Open Search page and verify that workspace name is changed to the new name in workspace item title and in room subtitle.

gedu · 2024-06-17T13:10:09Z

Please merge main into your branch

Done, I though I did it, but never pushed sorry

Beamanator

Nice, looking good! @ahmedGaber93 can you please do another quick test now that main is up to date? 🙏

ahmedGaber93 · 2024-06-18T06:46:40Z

@gedu I think we need to merge main again, because the latest main add some changes after you merge it, and this changes include fix for this issue #43164 (comment).

Also, I think it will be more clear if you use the test steps here #43164 (comment)

ahmedGaber93 · 2024-06-18T06:48:47Z

I merge main into this locally and test this issue #43164 (comment) and it works well.

20240618093040712.mp4

ahmedGaber93 · 2024-06-18T06:57:45Z

I found a bug, but it reproduced also on the main branch.

Logout
login with a new account

App sometimes not load all default reports and just load invalid Concierge chat 'Concierge in unavailable workspace'

20240618093402947.mp4

Beamanator · 2024-06-18T07:19:29Z

Amazing, ok ya @gedu if you could merge main 1 last time, i think we'll be good to merge 🙏

gedu · 2024-06-18T08:51:41Z

@Beamanator updated

OSBotify · 2024-06-18T09:56:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-19T21:52:19Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:17:01Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-19T22:51:00Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.86-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T21:21:38Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Unify useEffect to create the optionList in one place, clearing all t…

6e49019

…he errors from success

gedu mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-06-28] [$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment #43094

Closed

6 tasks

removed console logs

09297b6

gedu marked this pull request as ready for review June 12, 2024 13:14

gedu requested a review from a team as a code owner June 12, 2024 13:14

melvin-bot Bot removed the request for review from a team June 12, 2024 13:14

melvin-bot Bot requested a review from ahmedGaber93 June 12, 2024 13:14

ahmedGaber93 reviewed Jun 12, 2024

View reviewed changes

ahmedGaber93 reviewed Jun 13, 2024

View reviewed changes

Comment thread src/components/OptionListContextProvider.tsx Outdated

Updated comments

89cd42c

ahmedGaber93 reviewed Jun 13, 2024

View reviewed changes

Comment thread src/components/OptionListContextProvider.tsx Outdated

removed extra comment

2dabaac

ahmedGaber93 approved these changes Jun 13, 2024

View reviewed changes

melvin-bot Bot requested a review from Beamanator June 13, 2024 15:03

jasperhuangg changed the title ~~[WIP] Search result duplication~~ Search result duplication Jun 14, 2024

Beamanator requested changes Jun 14, 2024

View reviewed changes

gedu added 2 commits June 17, 2024 15:06

Merge branch 'main' into gedu/43094_duplicate_search_result

b54df89

Merge branch 'main' into gedu/43094_duplicate_search_result

19d862a

Beamanator self-requested a review June 18, 2024 05:39

Beamanator approved these changes Jun 18, 2024

View reviewed changes

Merge branch 'main' into gedu/43094_duplicate_search_result

bf61954

Beamanator merged commit b278b8f into Expensify:main Jun 18, 2024

github-actions Bot mentioned this pull request Jun 19, 2024

Deploy Checklist: New Expensify 2024-06-19 #44047

Closed

59 tasks

Conversation

gedu commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 12, 2024

Uh oh!

ahmedGaber93 Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

gedu Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

gedu Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

arosiclair Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Jun 13, 2024

Uh oh!

ahmedGaber93 commented Jun 13, 2024

Uh oh!

jasperhuangg commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

gedu commented Jun 14, 2024

Uh oh!

gedu commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gedu commented Jun 14, 2024

Uh oh!

ahmedGaber93 commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gedu commented Jun 17, 2024

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Jun 18, 2024

Uh oh!

ahmedGaber93 commented Jun 18, 2024

Uh oh!

ahmedGaber93 commented Jun 18, 2024

Uh oh!

Beamanator commented Jun 18, 2024

Uh oh!

gedu commented Jun 18, 2024

gedu commented Jun 6, 2024 •

edited

Loading

ahmedGaber93 commented Jun 13, 2024 •

edited

Loading

jasperhuangg commented Jun 14, 2024 •

edited

Loading

gedu commented Jun 14, 2024 •

edited

Loading

ahmedGaber93 commented Jun 14, 2024 •

edited

Loading

ahmedGaber93 commented Jun 14, 2024 •

edited

Loading

ahmedGaber93 commented Jun 14, 2024 •

edited

Loading