@szymczak/sage intacct import page#44166
Conversation
| intacct: { | ||
| config: { | ||
| mappings: { | ||
| [mappingName]: mappingValue, |
There was a problem hiding this comment.
Should we set mappings to some values on success? 🤔 I think it should be handled by the data returned from the backend
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
There was a problem hiding this comment.
cc @mananjadhav I believe this is the same as the file here if you want to consolidate around this name: https://expensify.slack.com/archives/C06ML6X0W9L/p1719967769151569?thread_ts=1719965572.991699&cid=C06ML6X0W9L
(I feel like folder-with-papers is a more descriptive and appropriate file name)
| function addSageIntacctUserDimensions( | ||
| policyID: string, | ||
| name: string, | ||
| mapping: typeof CONST.SAGE_INTACCT_CONFIG.MAPPING_VALUE.TAG | typeof CONST.SAGE_INTACCT_CONFIG.MAPPING_VALUE.REPORT_FIELD, |
There was a problem hiding this comment.
Coming from https://expensify.slack.com/archives/C06ML6X0W9L/p1720450316948649?thread_ts=1719447487.162559&cid=C06ML6X0W9L this should be the full dimensions object.
| return {optimisticData, failureData, successData}; | ||
| } | ||
|
|
||
| function addSageIntacctUserDimensions( |
There was a problem hiding this comment.
cc @NikkiWines on this function to make sure your API lines up with what's being sent here and below, or if @SzymczakJ needs to tweak things.
There was a problem hiding this comment.
Sounds like you guys have this one sorted based on this discussion
|
@SzymczakJ Some more conflicts :( |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀
|
| addAUserDefinedDimension: 'Add a user-defined dimension', | ||
| detailedInstructionsLink: 'View detailed instructions', | ||
| detailedInstructionsRestOfSentence: ' on adding user-defined dimensions.', | ||
| userDimensionsAdded: (dimensionsCount: number) => `${dimensionsCount} ${Str.pluralize('UDD', `UDDs`, dimensionsCount)} added`, |
There was a problem hiding this comment.
Just stumbled into this. UDD is a user facing term?
There was a problem hiding this comment.
I believe so. Here's screenshot from Figma:
There was a problem hiding this comment.
Ah ok, thanks! Seemed weird
| title={translate('workspace.intacct.expenseTypes')} | ||
| subtitle={translate('workspace.intacct.expenseTypesDescription')} |
There was a problem hiding this comment.
Case was missed where import type should be dynamic based on export type: #59670
11 participants
Details
Fixed Issues
$ #43533
PROPOSAL:
Tests
and Import page looks like this (Departments Menu Item changed to "Departments")
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
androidweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
iosweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov