Skip to content

[InternalQA] Prevent UI change on VBA flow during data fetch #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 5 commits into from
Aug 11, 2021
Merged

[InternalQA] Prevent UI change on VBA flow during data fetch #4480

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c0c4ea
prevent ui change
luacmartins Aug 6, 2021
f995b9b
use lodashget
luacmartins Aug 6, 2021
22c872c
achData default state
luacmartins Aug 9, 2021
6204947
move comment
luacmartins Aug 9, 2021
e24e3fb
add edge case comment
luacmartins Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/libs/actions/BankAccounts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,12 @@ function fetchUserWallet() {
function fetchFreePlanVerifiedBankAccount(stepToOpen) {
// We are using set here since we will rely on data from the server (not local data) to populate the VBA flow
// and determine which step to navigate to.
Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: true});
Onyx.set(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {
loading: true,

// We temporarily keep the achData state to prevent UI changes while fetching.
Comment thread
marcaaron marked this conversation as resolved.
achData: {state: lodashGet(reimbursementAccountInSetup, 'state', '')},
});
let bankAccountID;

API.Get({
Expand Down Expand Up @@ -403,6 +408,11 @@ function fetchFreePlanVerifiedBankAccount(stepToOpen) {
achData.bankAccountInReview = bankAccount && bankAccount.isVerifying();
achData.domainLimit = 0;

// Adding a default empty state to make sure we override the temporary one we are keeping
// for UI purposes. This covers an edge case in which a user deleted their bank account,
// but would still see Finish Setup in the UI, instead of Get Started.
achData.state = lodashGet(achData, 'state', '');
Comment thread
marcaaron marked this conversation as resolved.

// If the bank account has already been created in the db and is not yet open
// let's show the manual form with the previously added values
achData.subStep = bankAccount && bankAccount.isInSetup()
Expand Down