Dismissing onboarding fix by filip-solecki · Pull Request #45327 · Expensify/App

filip-solecki · 2024-07-12T09:02:00Z

Details

This PR is second attempt to solve this issue. Original PR was reverted due to issues listed below:
#45157
#45196
#44235
#45284

Fixed Issues

$ #44401
PROPOSAL:

Tests

NOTE
While testing on iOS web or Android web the app should not be running in the background on native devices

CASE 1:

Log in to the app as a new user
Onboarding modal should show
Replace onboarding/purpose with eg. settings/profile in the URL
You should still see onboarding Modal

CASE 2:

Log in to the app as existing user
Visit a few pages then log out
Log in as a new user
Try to go back using browser back button
You should see Onboarding Modal all the time you change url

Verify that no errors appear in the JS console

Offline tests

QA Steps

While testing on iOS web or Android web the app should not be running in the background on native devices

Dismissing onboarding test steps

CASE 1:

Log in to the app as a new user
Onboarding modal should show
Replace onboarding/purpose with eg. settings/profile in the URL
You should still see onboarding Modal

CASE 2:

Log in to the app as existing user
Visit a few pages then log out
Log in as a new user
Try to go back using browser back button
You should see Onboarding Modal all the time you change url

Previous regressions fix test steps

CASE 3

Go to https://staging.new.expensify.com/
Log out
Navigate via public room link (my link https://staging.new.expensify.com/r/1353086947735283
)

CASE 4

Log out of NewDot
Navigate to https://staging.new.expensify.com/concierge
Sign-up with a new account
Finish the onboarding flow
You should see explanation message

CASE 5

Try to log in to the app with SSO
You should be logged in

CASE 6

Try to log in to the app with Magic link
You should be logged in

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: mWeb Chrome

android.webm

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-12.at.11.30.39.mp4

MacOS: Chrome / Safari

Web.mov

SSO login issue

SSO.mov

Magic link issue

Magic-link.mov

This reverts commit a094775.

filip-solecki · 2024-07-12T09:44:20Z

cc @allgandalf as you were the reviewer of the original PR - basically I just added one check if the user is authenticated before we do some actions with navigation state.

melvin-bot · 2024-07-12T09:44:30Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-07-12T14:56:33Z

@filip-solecki can you please include all the issues that were identified as test/ qa in the PR?

allgandalf · 2024-07-12T14:58:49Z

This issue #45206 also magically got fixed after the revert (So i assume the offending PR was ours) , so can you also test it out @filip-solecki

dangrous · 2024-07-12T19:05:20Z

Just FYI - #44600 is still open and happening on staging. Calling it out because it says in the description here that the original PR was reverted... So it might not be related?

but if this PR fixes it, great!

mountiny · 2024-07-12T20:51:45Z

It seems like that issue existed before this original pr no?

filip-solecki · 2024-07-15T09:26:43Z

This issue #45206 also magically got fixed after the revert (So i assume the offending PR was ours) , so can you also test it out @filip-solecki

Do you have any idea how can I test it?

filip-solecki · 2024-07-15T09:27:30Z

Just FYI - #44600 is still open and happening on staging. Calling it out because it says in the description here that the original PR was reverted... So it might not be related?

but if this PR fixes it, great!

sorry, my bad - I've made a mistake while copy pasting links - this issue is not fixed here

filip-solecki · 2024-07-15T09:58:14Z

@mountiny I've mentioned all issues I know are fixed here. There is one mentioned by @allgandalf and I don't know how to test it, maybe you have any idea @allgandalf ?
Generally I think the PR is ready to review and the fixes are really small

allgandalf · 2024-07-15T12:44:03Z

I also really don't know how to test that on development, @mountiny do you have any idea what should we do for the issue #45206

mountiny · 2024-07-16T10:51:21Z

@mountiny @filip-solecki sorrg mostly ooo these days

I have triggered a build here

You can test it by intercepting the link to new dot with the shortlived token and change it for localhost or to the adhoc build link

github-actions · 2024-07-16T11:12:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45327/NewExpensify.dmg	https://45327.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-07-16T11:39:02Z

Seems to be solved, thanks @mountiny 🙇

Screen.Recording.2024-07-16.at.5.03.52.PM.mov

allgandalf · 2024-07-16T11:39:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-07-08.at.7.58.51.PM.mov

Screen.Recording.2024-07-08.at.8.05.35.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-08.at.8.17.07.PM.mov

Screen.Recording.2024-07-08.at.8.18.54.PM.mov

Android: Native

Screen.Recording.2024-07-08.at.8.25.22.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-09.at.3.12.41.PM.mov

iOS: Native

Screen.Recording.2024-07-09.at.3.10.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-09.at.3.08.10.PM.mov

allgandalf

I approve off this PR, LGTM, hopefully no issues arise this time 🙏

allgandalf · 2024-07-19T06:00:58Z

@filip-solecki we have conflicts here ;)

filip-solecki · 2024-07-19T06:17:08Z

Resolved
cc @mountiny

mountiny

Thanks for the patience!

OSBotify · 2024-07-19T12:07:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-19T20:13:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-22T13:35:49Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

mvtglobally · 2024-07-22T14:30:47Z

Onboarding still can be skipped by navigating to page with RHP. This PR is failing with the original issue #44401

45327.web.mp4

allgandalf · 2024-07-22T14:35:02Z

@filip-solecki , can you look at this please

OSBotify · 2024-07-23T08:03:25Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

filip-solecki · 2024-07-23T08:05:26Z

@adamgrzybowski is taking a look

WojtekBoman · 2024-07-23T13:50:55Z

Onboarding still can be skipped by navigating to page with RHP. This PR is failing with the original issue #44401

45327.web.mp4

Hi! I'll take a look at it :)

WojtekBoman · 2024-07-24T06:09:31Z

Onboarding still can be skipped by navigating to page with RHP. This PR is failing with the original issue #44401

45327.web.mp4

@mvtglobally Could you recheck it? I tried to reproduce that and it seems to work fine :) I tested it on a local build and on staging, in both cases it behaves correctly.

Screen.Recording.2024-07-24.at.07.34.55.mov

OSBotify · 2024-07-25T03:14:36Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-10-09T19:13:31Z

+        // We reset the URL as the browser sets it in a way that doesn't match the navigation state
+        // eslint-disable-next-line no-restricted-globals
+        history.replaceState({}, '', getPathFromState(state, linkingConfig.config));


history does not exist on native. I am not sure if a real user could land into this code but I got a crash while testing another PR

Yeah, we definetly should make this part platform-specific.

Agree, should we make a issue for this @adamgrzybowski @s77rt ?

Somebody from SWM can take care of this issue if you want

@mountiny Could you please create an issue for this?

s77rt · 2024-12-19T01:19:58Z

+    const initialState = useMemo(() => {
+        if (!user || user.isFromPublicDomain) {
+            return;
+        }


This return is too early and prevented public domain users from using the lastVisitedPath feature.

Repro steps:

Go to settings

Open https://dev.new.expensify.com:8082/

Verify that you land on settings

This only works with private domain users. cc @mountiny

Screen.Recording.2024-12-19.at.2.16.36.AM.mov

filip-solecki added 3 commits July 12, 2024 10:59

Revert "Revert "Fix show onboarding modal functions""

2d791ac

This reverts commit a094775.

Merge branch 'main' into onboarding/dismissing-issue

d3d3791

Fix logging issues

461195d

filip-solecki changed the title ~~Revert "Revert "Fix show onboarding modal functions""~~ Dismissing onboarding fix Jul 12, 2024

filip-solecki marked this pull request as ready for review July 12, 2024 09:44

filip-solecki requested a review from a team as a code owner July 12, 2024 09:44

melvin-bot Bot removed the request for review from a team July 12, 2024 09:44

melvin-bot Bot requested a review from allgandalf July 12, 2024 09:44

filip-solecki mentioned this pull request Jul 12, 2024

Fix show onboarding modal functions #44536

Merged

50 tasks

mountiny assigned filip-solecki Jul 12, 2024

Merge branch 'main' into onboarding/dismissing-issue

125fbad

Fix going to Public room shows onboarding modal

cea572f

mountiny added the Ready To Build label Jul 16, 2024

allgandalf approved these changes Jul 16, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny July 16, 2024 11:44

filip-solecki added 2 commits July 19, 2024 08:11

Merge branch 'main' into onboarding/dismissing-issue

7c3a3ff

Fix wrong merge solving

5ef6d79

mountiny approved these changes Jul 19, 2024

View reviewed changes

mountiny merged commit b8b99d0 into Expensify:main Jul 19, 2024

github-actions Bot mentioned this pull request Jul 19, 2024

Deploy Checklist: New Expensify 2024-07-19 #45794

Closed

mountiny mentioned this pull request Jul 23, 2024

[$250] [HOLD payment 2024-08-09] [CRITICAL] [Guided setup] The onboarding flow can be dismissed by navigating to different route #44401

Closed

nkdengineer mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent #46110

Closed

6 tasks

s77rt reviewed Oct 9, 2024

View reviewed changes

mountiny mentioned this pull request Oct 14, 2024

[PAID] Render Error in android emulator #50713

Closed

s77rt reviewed Dec 19, 2024

View reviewed changes

Conversation

filip-solecki commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

Dismissing onboarding test steps

Previous regressions fix test steps

PR Author Checklist

Screenshots/Videos

Uh oh!

filip-solecki commented Jul 12, 2024

Uh oh!

melvin-bot Bot commented Jul 12, 2024

Uh oh!

mountiny commented Jul 12, 2024

Uh oh!

allgandalf commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jul 12, 2024

Uh oh!

filip-solecki commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filip-solecki commented Jul 15, 2024

Uh oh!

filip-solecki commented Jul 15, 2024

Uh oh!

allgandalf commented Jul 15, 2024

Uh oh!

mountiny commented Jul 16, 2024

Uh oh!

github-actions Bot commented Jul 16, 2024

Uh oh!

allgandalf commented Jul 16, 2024

Uh oh!

allgandalf commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jul 19, 2024

Uh oh!

filip-solecki commented Jul 19, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 22, 2024

Uh oh!

mvtglobally commented Jul 22, 2024

Uh oh!

allgandalf commented Jul 22, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

filip-solecki commented Jul 23, 2024

Uh oh!

WojtekBoman commented Jul 23, 2024

Uh oh!

WojtekBoman commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jul 25, 2024

Uh oh!

s77rt Oct 9, 2024

Choose a reason for hiding this comment

filip-solecki commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024 •

edited

Loading

dangrous commented Jul 12, 2024 •

edited

Loading

filip-solecki commented Jul 15, 2024 •

edited

Loading

allgandalf commented Jul 16, 2024 •

edited

Loading

WojtekBoman commented Jul 24, 2024 •

edited

Loading