Skip to content

Fix ExpensiInput autoFocus & tab Focus #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Aug 12, 2021
Merged

Fix ExpensiInput autoFocus & tab Focus #4593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40b928
fix: ExpensiInput autoFocus & tab Focus
parasharrajat Aug 11, 2021
84a9a10
Update src/components/ExpensiTextInput/BaseExpensiTextInput.js
parasharrajat Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/ExpensiTextInput/BaseExpensiTextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ class BaseExpensiTextInput extends Component {
this.onBlur = this.onBlur.bind(this);
}

componentDidMount() {
// We are manually managing focus to prevent this issue: https://github.com/Expensify/App/issues/4514
if (this.props.autoFocus && this.input) {
Comment thread
parasharrajat marked this conversation as resolved.
this.input.focus();
}
}

onFocus() {
if (this.props.onFocus) { this.props.onFocus(); }
this.setState({isFocused: true});
Expand Down Expand Up @@ -84,13 +91,14 @@ class BaseExpensiTextInput extends Component {
inputStyle,
ignoreLabelTranslateX,
innerRef,
autoFocus,
...inputProps
} = this.props;

const hasLabel = Boolean(label.length);
return (
<View style={[styles.componentHeightLarge, ...containerStyles]}>
<TouchableWithoutFeedback onPress={() => this.input.focus()}>
<TouchableWithoutFeedback onPress={() => this.input.focus()} focusable={false}>
<View
style={[
styles.expensiTextInputContainer,
Expand Down