Skip to content

Fix - Room - Inviting new members to room shows duplicate contact briefly in members list #46331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldo-expensify merged 3 commits into from
Jul 29, 2024
Merged

Fix - Room - Inviting new members to room shows duplicate contact briefly in members list #46331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9320b53
fix duplicate members in room members page
FitseTLT Jul 26, 2024
1d02a66
Added Comment
FitseTLT Jul 29, 2024
a44195d
edited comment
FitseTLT Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/pages/RoomMembersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,13 @@ function RoomMembersPage({report, session, policies}: RoomMembersPageProps) {

participants.forEach((accountID) => {
const details = personalDetails[accountID];
// When adding a new member to a room (whose personal detail does not exist in Onyx), an optimistic personal detail
// is created. However, when the real personal detail is returned from the backend, a duplicate member may appear
// briefly before the optimistic personal detail is deleted. To address this, we filter out the optimistically created
// member here.
const isDuplicateOptimisticDetail = details?.isOptimisticPersonalDetail && participants.some((accID) => accID !== accountID && details.login === personalDetails[accID]?.login);

if (!details) {
if (!details || isDuplicateOptimisticDetail) {
Log.hmmm(`[RoomMembersPage] no personal details found for room member with accountID: ${accountID}`);
return;
}
Expand Down