Fullstory component properties added all children components unmasked by LCOleksii · Pull Request #46568 · Expensify/App

LCOleksii · 2024-07-31T10:38:25Z

Fullstory component properties added all children components unmasked in app views:

HeaderView.tsx
ScreenWrapper.tsx

Details

In order to allow content of all components during the session capture
added fsClass unmask propery at global components.

Fixed Issues

Missing content during session preview for masked components

$ #46579
PROPOSAL:
Unmask components to allow the capture

Tests

Verify that no errors appear in the JS console
Verify that UI-related session data is available in IOs version of the app in Fullstory
Verify that UI-related session data is available in Android version of the app in Fullstory
Verify that UI-related session data is available in Web version of the app in Fullstory

Offline tests

QA Steps

Verify that no errors appear in the JS console
Open app
Log in to start user session
Browse Reposts, Settings, Profile views
Verify that UI-related session data is available in Fullstory related session

PR Author Checklist

Screenshots/Videos

Android: Native

$ https://drive.google.com/file/d/1SElP-7G7O0AD2m2CC-FLPK-sOz0VGa9v/view?usp=drive_link

Android: mWeb Chrome

iOS: Native

$ https://drive.google.com/file/d/1vlef3pWg6WvKETGxg6FoUJC2DbIkc1__/view?usp=drive_link

iOS: mWeb Safari

MacOS: Chrome / Safari

$ https://drive.google.com/file/d/1CR3JoqRkY1sU7YJgyOG8qizZZorSs49A/view?usp=drive_link

MacOS: Desktop

…in app views: - HeaderView.tsx - ScreenWrapper.tsx

melvin-bot · 2024-07-31T10:38:56Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-07-31T12:24:14Z

@LCOleksii can you please link the issue in the OP?

luacmartins

Changes LGTM, but will wait on merging until an issue is linked

anmurali · 2024-07-31T17:34:25Z

@luacmartins - I created an issue for it - #46579

luacmartins · 2024-07-31T21:29:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-07-31T21:30:13Z

Thank you! Added to the OP.

melvin-bot · 2024-07-31T21:30:42Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2024-07-31T21:42:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-02T01:42:53Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lanitochka17 · 2024-08-05T13:21:55Z

Hello
The team is having difficulties with this PR.
Could you explain exactly what we must check in this PR? What are the specific steps to be followed for checking?

LCOleksii · 2024-08-05T13:38:04Z

Hello @lanitochka17
Changes can be only observed in Fullstory UI session replay.
Previously session recordings had masked(blurred all contents and copies) in Fullsorry session preview.
This PR unmasks them and make readable.

mvtglobally · 2024-08-05T13:47:28Z

@luacmartins pls QA this one internally, we do not have access to Fullstory UI session replay

anmurali · 2024-08-05T13:59:39Z

It has to go to production to QA. We don’t send any staging sessions to Fullstory

OSBotify · 2024-08-06T04:03:07Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fullstory component properies added all children components unmasked …

8e4a4b6

…in app views: - HeaderView.tsx - ScreenWrapper.tsx

LCOleksii requested a review from a team as a code owner July 31, 2024 10:38

melvin-bot Bot requested review from luacmartins and removed request for a team July 31, 2024 10:38

luacmartins approved these changes Jul 31, 2024

View reviewed changes

luacmartins merged commit e834e5f into Expensify:main Jul 31, 2024

github-actions Bot mentioned this pull request Aug 2, 2024

Deploy Checklist: New Expensify 2024-08-02 #46687

Closed

50 tasks

melvin-bot Bot mentioned this pull request Aug 6, 2024

[HOLD for payment 2024-08-13] [Fullstory] Unmasking session data in Fullstory #46579

Closed

This was referenced Jan 26, 2025

Unmask the search input field for Fullstory #55766

Merged

[$250] Unmask the search input field for Fullstory #55512

Closed

Conversation

LCOleksii commented Jul 31, 2024 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 31, 2024

Uh oh!

luacmartins commented Jul 31, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

anmurali commented Jul 31, 2024

Uh oh!

luacmartins commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Jul 31, 2024

Uh oh!

melvin-bot Bot commented Jul 31, 2024

Uh oh!

OSBotify commented Jul 31, 2024

Uh oh!

OSBotify commented Aug 2, 2024

Uh oh!

lanitochka17 commented Aug 5, 2024

Uh oh!

LCOleksii commented Aug 5, 2024

Uh oh!

mvtglobally commented Aug 5, 2024

Uh oh!

anmurali commented Aug 5, 2024

Uh oh!

OSBotify commented Aug 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LCOleksii commented Jul 31, 2024 •

edited by luacmartins

Loading

luacmartins commented Jul 31, 2024 •

edited

Loading