Skip to content

#46949: Fix Results, Loading and Empty state Search pages #47164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 6 commits into from
Aug 12, 2024
Merged

#46949: Fix Results, Loading and Empty state Search pages #47164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4906b2
main solution
Guccio163 Aug 9, 2024
3c9df2b
second solution
Guccio163 Aug 9, 2024
400ad62
shifting padding to Skeleton components
Guccio163 Aug 12, 2024
57f7078
margin horizontal refactor
Guccio163 Aug 12, 2024
a4002ef
margin horizontal refactor 2
Guccio163 Aug 12, 2024
b2ce716
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Skeletons/CardRowSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function CardRowSkeleton({shouldAnimate = true, fixedNumItems, gradientOpacityEn
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
gradientOpacityEnabled={gradientOpacityEnabled}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mr3, styles.ml3]}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
renderSkeletonItem={() => (
<>
<Circle
Expand Down
4 changes: 2 additions & 2 deletions src/components/Skeletons/SearchRowSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function SearchRowSkeleton({shouldAnimate = true, fixedNumItems, gradientOpacity
return (
<ItemListSkeletonView
itemViewHeight={CONST.SEARCH_SKELETON_VIEW_ITEM_HEIGHT}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mr3, styles.ml3]}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
gradientOpacityEnabled={gradientOpacityEnabled}
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
Expand Down Expand Up @@ -117,7 +117,7 @@ function SearchRowSkeleton({shouldAnimate = true, fixedNumItems, gradientOpacity
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
gradientOpacityEnabled={gradientOpacityEnabled}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mr3, styles.ml3]}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
renderSkeletonItem={() => (
<>
<Rect
Expand Down
2 changes: 1 addition & 1 deletion src/components/Skeletons/TableRowSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function TableListItemSkeleton({shouldAnimate = true, fixedNumItems, gradientOpa
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
gradientOpacityEnabled={gradientOpacityEnabled}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mr3, styles.ml3]}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
renderSkeletonItem={() => (
<>
<Circle
Expand Down
2 changes: 0 additions & 2 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5109,8 +5109,6 @@ const styles = (theme: ThemeColors) =>
left: 0,
width: '100%',
height: '100%',
paddingRight: 8,
paddingLeft: 8,
},

emptyStateScrollView: {
Expand Down