fix: only dismiss the report attachment modal once by dominictb · Pull Request #47622 · Expensify/App

dominictb · 2024-08-19T05:39:31Z

Details

Fixed Issues

$ #46388
PROPOSAL: #46388 (comment)

Tests

Note: Only test in Desktop app/Desktop browser web app

Upload a pdf in a chat (chat 1) and then open another chat (chat 2)
Open chat 1 again using LHN
Open the pdf attachment
Click Cmd/Ctrl + K

Verify that: the first chat is still shown in the background while the chat search left modal open

Verify that no errors appear in the JS console

Offline tests

QA Steps

Note: Only test in Desktop app/Desktop browser web app

Upload a pdf in a chat (chat 1) and then open another chat (chat 2)
Open chat 1 again using LHN
Open the pdf attachment
Click Cmd/Ctrl + K

Verify that: the first chat is still shown in the background while the chat search left modal open

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

aweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

iosweb.mp4

MacOS: Chrome / Safari

compressed_web.mov.mp4

MacOS: Desktop

compressed_desktop.mov.mp4

melvin-bot · 2024-08-19T05:39:36Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-08-19T09:42:09Z

@dominictb please update the videos on all platforms, for small screens you can just put up a video doing the normal action, we have to follow this from our authors checklist

I ran the tests on all platforms & verified they passed on:

Also state in tests state that we should test this on MacOS web/ desktop only

dominictb · 2024-08-20T11:39:57Z

@allgandalf on it today.

dominictb · 2024-08-20T14:52:09Z

@allgandalf done!

allgandalf · 2024-08-21T12:21:14Z

I will review this today / tomorrow

allgandalf · 2024-08-25T19:19:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Cannot reproduce on small screen

Android: mWeb Chrome

Cannot reproduce on small screen

iOS: Native

Cannot reproduce on small screen

iOS: mWeb Safari

Cannot reproduce on small screen

MacOS: Chrome / Safari

Screen.Recording.2024-08-26.at.1.02.42.AM.mov

MacOS: Desktop

Screen.Recording.2024-08-26.at.1.05.28.AM.mov

allgandalf

Functionally this is great, but i want to get one thing cleared up before we move forward @dominictb

allgandalf · 2024-08-25T19:38:08Z

@@ -1,5 +1,5 @@
 import type {StackScreenProps} from '@react-navigation/stack';
-import React, {useCallback} from 'react';
+import React, {useCallback, useEffect} from 'react';


Suggested change

import React, {useCallback, useEffect} from 'react';

import React, {useCallback, useEffect, useRef} from 'react';

allgandalf · 2024-08-25T19:38:47Z

    const accountID = route.params.accountID;
    const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID || -1}`);
    const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP);
+    const hasDismissedModalRef = React.useRef(false);


Suggested change

const hasDismissedModalRef = React.useRef(false);

const hasDismissedModalRef = useRef(false);

Was there any reason why you didn't import the useRef ? LMK if that was on purpose, I didn't understand the motive here

@allgandalf sorry, maybe the code completion cause this. Fixed in the latest commit

haha, no worries, happens on best of our days 😄

allgandalf

LGTM and works well 🚀

OSBotify · 2024-08-27T17:31:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-28T21:44:27Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-30T18:32:55Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: only dismiss the report attachment modal once

51f0110

dominictb requested a review from a team as a code owner August 19, 2024 05:39

melvin-bot Bot requested review from allgandalf and removed request for a team August 19, 2024 05:39

allgandalf mentioned this pull request Aug 20, 2024

[PAID] [$250] Chat - When opening a PDF and clicking 'Ctrl + K,' the search opens but the page scrolls to the next #46388

Closed

6 tasks

allgandalf reviewed Aug 25, 2024

View reviewed changes

fix: import useRef

c38178b

allgandalf approved these changes Aug 27, 2024

View reviewed changes

melvin-bot Bot requested a review from thienlnam August 27, 2024 05:38

thienlnam approved these changes Aug 27, 2024

View reviewed changes

thienlnam merged commit c9e53f6 into Expensify:main Aug 27, 2024

github-actions Bot mentioned this pull request Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

93 tasks

srikarparsi mentioned this pull request Aug 29, 2024

[HOLD for payment Oct 4][$250] Attachment - Error not displayed when trying to upload corrupted pdf file to chat #48263

Closed

6 tasks

FitseTLT mentioned this pull request Sep 4, 2024

[$250] Key Navigation - Pressing CTRL+K in attachment and closing search, leads to different chat #48113

Closed

6 tasks

	import React, {useCallback, useEffect} from 'react';
	import React, {useCallback, useEffect, useRef} from 'react';

	const hasDismissedModalRef = React.useRef(false);
	const hasDismissedModalRef = useRef(false);

Conversation

dominictb commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 19, 2024

Uh oh!

allgandalf commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Aug 20, 2024

Uh oh!

dominictb commented Aug 20, 2024

Uh oh!

allgandalf commented Aug 21, 2024

Uh oh!

allgandalf commented Aug 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

dominictb Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 27, 2024

Uh oh!

OSBotify commented Aug 28, 2024

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominictb commented Aug 19, 2024 •

edited

Loading

allgandalf commented Aug 19, 2024 •

edited

Loading

allgandalf commented Aug 25, 2024 •

edited

Loading