Fix next button isn't aligned at bottom in switch to expensify reason form page by bernhardoj · Pull Request #47957 · Expensify/App

bernhardoj · 2024-08-24T07:25:39Z

Details

The page has a max height but it's set smaller than it should be, so the button isn't aligned at the bottom. This PR fix it.

Fixed Issues

$ #47280
PROPOSAL: #47280 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open Settings > Switch to Expensify Classic
Select any reason and proceed to the next screen
Verify the next button is aligned at the bottom of the page
Submit the form with an empty response. Verify error is shown
Keep adding new line to the form input until it reaches the maximum height
Verify the input underline, form error, and the next button isn't overlap

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-08-24T07:25:44Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-08-24T07:31:00Z

+            safePaddingBottomStyleValue -
            // Minus the height of the text component
-            textStyle.lineHeight -
+            headerTitleHeight -


One of the reasons the form errors overlaps is because the height of the title here is only a one-line height, but the title could be more than 1 line.

The extra margin value (baseResponseInputContainerStyle.marginTop * 2) calculation below and the vertical margins (40) should be enough to cover the form error, but the form error (Please fix the errors in the form before continuing.) could be more than 1 line too, so I add an extra 20 as the safe value.

rayane-d · 2024-08-27T15:12:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rayane-d · 2024-08-27T19:42:51Z

            // Minus the vertical margins around the form button
-            40,
+            40 -
+            // Minus the extra height for the form error text
+            20,


Can we use dynamic values for these?

…fy-classic-form

rayane-d · 2024-08-30T21:55:38Z

Bug 1: mWeb Safari only - Empty space below the "Next" button when we open the page, and the button does not keep its position above the keyboard

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-30.at.22.50.16.mp4

rayane-d · 2024-08-30T21:59:24Z

Bug 2: iOS native only - When we reach the maximum height, There is an extra space between This field is required and Please fix the errors in the form before continuing error messages.

Screenshot

…fy-classic-form

bernhardoj · 2024-08-31T03:58:39Z

Bug 1: happen on main too
Bug 2: fixed

Android with keyboard:

without keyboard:

iOS with keyboard:

without keyboard:

bernhardoj · 2024-08-31T04:05:30Z

+    // Device safe area top and bottom insets.
+    // When the keyboard is shown, the bottom inset doesn't affect the height, so we take it out from the calculation.
+    const {top: safeAreaInsetsTop, bottom: safeAreaInsetsBottom} = useSafeAreaInsets();
+    const safeAreaInsetsBottomValue = !keyboardHeight ? safeAreaInsetsBottom : 0;


useSafeAreaInsets doesn't affect the height when the keyboard is shown.

bernhardoj · 2024-08-31T04:05:31Z

+    const formPaddingBottomValue = formPaddingBottom || styles.pb5.paddingBottom;
+    // Extra bottom padding in FormAlertWithSubmitButton
+    const safePaddingBottomStyle = useSafePaddingBottomStyle();
+    const safePaddingBottomStyleValue = 'paddingBottom' in safePaddingBottomStyle ? (safePaddingBottomStyle.paddingBottom as number) : 0;


For the recent fix, I add another inset from useStyledSafeAreaInsets to use in the calculation.

The form currently has 3 bottom spacings. 1 from safe area insets (ScreenWrapper), 1 from styled safe area insets,

App/src/components/Form/FormWrapper.tsx

Lines 107 to 110 in 117b961

<FormElement

key={formID}

ref={formContentRef}

style={[style, safeAreaPaddingBottomStyle.paddingBottom ? safeAreaPaddingBottomStyle : styles.pb5]}

and the last 1 is from useSafePaddingBottomStyle.

App/src/components/FormAlertWithSubmitButton.tsx

Lines 99 to 100 in 117b961

<FormAlertWrapper

containerStyles={[styles.justifyContentEnd, safePaddingBottomStyle, containerStyles]}

useSafeAreaInsets is added in ScreenWrapper so it won't overlap with this.

The other 2 just add additional spacing in 2 different places and 2 different values.

FormAlertWithSubmitButton which uses useSafePaddingBottomStyle adds 20px while FormWrapper uses useStyledSafeAreaInsets with the same value as useSafeAreaInsets but multiplied by 0.7 and fallback to 20px if the bottom inset is not available (for Android).

App/src/styles/utils/index.ts

Lines 329 to 332 in 117b961

function getSafeAreaPadding(insets?: EdgeInsets, insetsPercentage: number = variables.safeInsertPercentage): SafeAreaPadding {

return {

paddingTop: insets?.top ?? 0,

paddingBottom: (insets?.bottom ?? 0) * insetsPercentage,

bernhardoj · 2024-08-31T04:08:28Z

+            // Minus the height above the button for the form error text, accounting for 2 lines max.
+            variables.lineHeightNormal * 2 -
+            // Minus the margin between the button and the form error text
+            styles.mb3.marginBottom,


Instead of using 40 to create the effect of both the margin top and bottom, I changed it to use the error text line height multiplied by 2 to account for 2 lines of error and also a margin-bottom that exists between the error text and the button.

The value now becomes (16-21 (scale depends on font size) * 2) + 12 = ~44-54

So, there will still be a small space if the error text is only 1 line

rayane-d

LGTM and tests well 🚀

OSBotify · 2024-09-03T01:11:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-03T23:42:54Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-05T19:16:53Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.29-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add more precise calculation to the max height

6aeba43

bernhardoj requested a review from a team as a code owner August 24, 2024 07:25

melvin-bot Bot requested review from rayane-d and removed request for a team August 24, 2024 07:25

bernhardoj commented Aug 24, 2024

View reviewed changes

lint

68b569b

rayane-d reviewed Aug 27, 2024

View reviewed changes

bernhardoj added 2 commits August 28, 2024 11:34

Merge branch 'main' into fix/47280-extra-spacing-in-switch-to-expensi…

c00afa7

…fy-classic-form

use line height value

3ca16d1

bernhardoj added 2 commits August 31, 2024 09:49

Merge branch 'main' into fix/47280-extra-spacing-in-switch-to-expensi…

a6cc298

…fy-classic-form

correcting more spacing calculation

1ed045a

bernhardoj commented Aug 31, 2024

View reviewed changes

rayane-d approved these changes Sep 2, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 2, 2024 22:28

roryabraham approved these changes Sep 3, 2024

View reviewed changes

roryabraham merged commit 610b9df into Expensify:main Sep 3, 2024

github-actions Bot mentioned this pull request Sep 3, 2024

Deploy Checklist: New Expensify 2024-09-03 #48515

Closed

68 tasks

IuliiaHerets mentioned this pull request Sep 5, 2024

[Hold for payment 2024-10-07][$250] Spacing in error message in Fields for Expensify Page are not consistent #48659

Closed

6 tasks

rayane-d mentioned this pull request Sep 9, 2024

Android - Switch to Expesify classic - Next button has extra padding on 2nd screen of survey #47280

Closed

6 tasks

	<FormElement
	key={formID}
	ref={formContentRef}
	style={[style, safeAreaPaddingBottomStyle.paddingBottom ? safeAreaPaddingBottomStyle : styles.pb5]}

	<FormAlertWrapper
	containerStyles={[styles.justifyContentEnd, safePaddingBottomStyle, containerStyles]}

	function getSafeAreaPadding(insets?: EdgeInsets, insetsPercentage: number = variables.safeInsertPercentage): SafeAreaPadding {
	return {
	paddingTop: insets?.top ?? 0,
	paddingBottom: (insets?.bottom ?? 0) * insetsPercentage,

Conversation

bernhardoj commented Aug 24, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 24, 2024

Uh oh!

bernhardoj Aug 24, 2024

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Aug 30, 2024

Uh oh!

rayane-d commented Aug 30, 2024

Uh oh!

bernhardoj commented Aug 31, 2024

Uh oh!

bernhardoj Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 3, 2024

Uh oh!

OSBotify commented Sep 3, 2024

Uh oh!

OSBotify commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rayane-d commented Aug 27, 2024 •

edited

Loading