[No QA] [Workspace Feeds] Integrate Deactivate_Card API by VickyStash · Pull Request #47986 · Expensify/App

VickyStash · 2024-08-26T07:39:37Z

Details

Integrate Deactivate_Card API

Fixed Issues

$ #44320
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Pre-steps:

Have all betas/workspaceFeed beta enabled

Go to the workspace where Expensify Card feature is enabled and several cards are added.
Open Expensify Card screen from the workspace navigation menu.
Tap on one of the cards from the list to open the details screen.
Press the Deactivate card button. Make sure the Deactivate_Card call is executed and the card isn't displayed anymore.

Offline tests

Same as in the Tests section

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

web1.mp4

melvin-bot · 2024-08-26T08:01:05Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-08-26T13:37:18Z

@mountiny What is the expected behavior when offline? Currently, when users deactivate a card, it gets hidden. Normally, in our app, when an action is performed offline, we grey it out until the API confirms success.

Screen.Recording.2024-08-26.at.20.32.56.mov

mountiny · 2024-08-26T16:20:17Z

@DylanDylann Actually this makes an external API call so I wonder if we should even allow taking this action offline. I will discuss

mountiny · 2024-08-26T16:22:53Z

Asked here

# Conflicts: # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

DylanDylann · 2024-08-27T12:29:51Z

@VickyStash Still get conflict

# Conflicts: # src/libs/actions/Card.ts

VickyStash · 2024-08-27T13:16:44Z

@DylanDylann I've added an offline modal and resolved conflicts, please take a look

mountiny

Tested the PR locally and I was able to deactivate the card successfully 🎉

mountiny · 2024-08-27T14:14:13Z

+    if (!authToken) {
+        return;
+    }


I think we can remove these, I am not sure sure why we started to add it, this should not happen

Suggested change

if (!authToken) {

return;

}

@mountiny I think it's to narrow down the type of authToken, cause the type of authToken also includes undefined

Urgh thats annoying

DylanDylann · 2024-08-27T16:25:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-28.at.17.23.43.mov

Android: mWeb Chrome

Screen.Recording.2024-08-28.at.17.18.49.mov

iOS: Native

Screen.Recording.2024-08-28.at.17.22.16.mov

iOS: mWeb Safari

Screen.Recording.2024-08-28.at.17.16.24.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-28.at.16.59.51.mov

MacOS: Desktop

Screen.Recording.2024-08-28.at.17.12.17.mov

DylanDylann · 2024-08-28T10:04:08Z

    API.write(WRITE_COMMANDS.UPDATE_EXPENSIFY_CARD_LIMIT_TYPE, parameters, {optimisticData, successData, failureData});
 }

+function deactivateCard(workspaceAccountID: number, cardID: number, card?: Card) {


Should we remove cardID param and use card.cardID

mountiny

Thanks

mountiny · 2024-08-28T10:56:24Z

+    if (!authToken) {
+        return;
+    }


Urgh thats annoying

mountiny · 2024-08-28T15:38:01Z

I am going to merge this as we are getting closer to deploy

OSBotify · 2024-08-28T15:55:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-28T21:46:01Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-30T18:34:28Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ZhenjaHorbach · 2025-06-04T20:32:30Z

+            },
+        },
+    ];
+


Came from this issue
We have an edge case that after deactivating Expensify card, Expensify Card link in the system message remains linked, which leads to not here page since we don't update cardID state in onyx

More context here

VickyStash added 2 commits August 26, 2024 08:48

Implements Card_Deactivate API call

fe0b583

Hide deactivated cards

9b4040f

VickyStash changed the title ~~[WIP] [No QA] [Workspace Feeds] Integrate Deactivate_Card API~~ [No QA] [Workspace Feeds] Integrate Deactivate_Card API Aug 26, 2024

VickyStash marked this pull request as ready for review August 26, 2024 08:01

VickyStash requested a review from a team as a code owner August 26, 2024 08:01

melvin-bot Bot requested review from DylanDylann and removed request for a team August 26, 2024 08:01

VickyStash mentioned this pull request Aug 26, 2024

[Workspace Feeds] [External] Integrate Deactivate_Card API #44320

Closed

mountiny assigned VickyStash Aug 26, 2024

mountiny requested review from MariaHCD and mountiny August 26, 2024 16:19

mountiny requested changes Aug 27, 2024

View reviewed changes

VickyStash added 2 commits August 27, 2024 11:43

Merge branch 'refs/heads/main' into feature/44320-deactivate-card

8c445b0

# Conflicts: # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Code improvements

14cac9e

VickyStash added 2 commits August 27, 2024 14:54

Add offline modal

871288d

Merge branch 'refs/heads/main' into feature/44320-deactivate-card

dc83aa6

# Conflicts: # src/libs/actions/Card.ts

mountiny previously approved these changes Aug 27, 2024

View reviewed changes

DylanDylann reviewed Aug 28, 2024

View reviewed changes

Minor improvement

89b6e18

VickyStash dismissed mountiny’s stale review via 89b6e18 August 28, 2024 10:16

DylanDylann approved these changes Aug 28, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny August 28, 2024 10:24

mountiny approved these changes Aug 28, 2024

View reviewed changes

mountiny merged commit eec5e2b into Expensify:main Aug 28, 2024

github-actions Bot mentioned this pull request Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

93 tasks

ZhenjaHorbach reviewed Jun 4, 2025

View reviewed changes

Conversation

VickyStash commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 26, 2024

Uh oh!

DylanDylann commented Aug 26, 2024

Uh oh!

mountiny commented Aug 26, 2024

Uh oh!

mountiny commented Aug 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Aug 27, 2024

Uh oh!

VickyStash commented Aug 27, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny commented Aug 28, 2024

Uh oh!

OSBotify commented Aug 28, 2024

Uh oh!

OSBotify commented Aug 28, 2024

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

ZhenjaHorbach Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Aug 26, 2024 •

edited

Loading

DylanDylann commented Aug 27, 2024 •

edited

Loading