fix: Update Wallet and Generic Folder empty state to use lottie animations. by Krishna2323 · Pull Request #48040 · Expensify/App

Krishna2323 · 2024-08-27T00:35:19Z

Details

Fixed Issues

$ #48013
PROPOSAL: #48013 (comment)

Tests

Go to search page > Select a workspace with no expenses > Verify Folder Empty State Animation is shown
Select Trips from LHS (filters) > Verify Trips Empty State Animation is shown
From FAB select Book travel > Verify Trips Empty State Animation is shown
Open a workspace with no tags, categories
Open policy tags page > Verify Folder Empty State Animation is shown
Open policy categories page > Verify Folder Empty State Animation is shown
Open report fields page > Verify Folder Empty State Animation is shown
Click Add field > Select list as type
Go to list values > Verify Folder Empty State illustration is shown
Go to settings/wallet > Verify Bank Vault animation is shown

Verify that no errors appear in the JS console

Offline tests

Go to search page > Select a workspace with no expenses > Verify Folder Empty State Animation is shown
Select Trips from LHS (filters) > Verify Trips Empty State Animation is shown
From FAB select Book travel > Verify Trips Empty State Animation is shown
Open a workspace with no tags, categories
Open policy tags page > Verify Folder Empty State Animation is shown
Open policy categories page > Verify Folder Empty State Animation is shown
Open report fields page > Verify Folder Empty State Animation is shown
Click Add field > Select list as type
Go to list values > Verify Folder Empty State illustration is shown
Go to settings/wallet > Verify Bank Vault animation is shown

QA Steps

Go to search page > Select a workspace with no expenses > Verify Folder Empty State Animation is shown
Select Trips from LHS (filters) > Verify Trips Empty State Animation is shown
From FAB select Book travel > Verify Trips Empty State Animation is shown
Open a workspace with no tags, categories
Open policy tags page > Verify Folder Empty State Animation is shown
Open policy categories page > Verify Folder Empty State Animation is shown
Open report fields page > Verify Folder Empty State Animation is shown
Click Add field > Select list as type
Go to list values > Verify Folder Empty State illustration is shown
Go to settings/wallet > Verify Bank Vault animation is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…tions. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-08-27T00:35:24Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-08-27T01:27:06Z

@Expensify/design, could you please review the result and let me know if it looks good? The size of the illustration is slightly larger than before. Additionally, for the categories selector page empty state, does the Edit categories button placement look fine? It was previously positioned at the bottom of the page.

Before	After

dubielzyk-expensify · 2024-08-27T01:45:03Z

Quick question for the @Expensify/design team. On desktop and mobile we seem to be using 32px padding on the card here, but in our other empty state card component we go from 32px to 20px on mobile. Do we wanna do the same here. The padding around the button seem a tad big in this screenshot:

shawnborton · 2024-08-27T12:30:58Z

but in our other empty state card component we go from 32px to 20px on mobile.

Can you show me an example of that? I don't feel too strongly here... the 32px keeps things fluffy but I can see where it might feel off given that the workspace cards and other places go from 32px to 20px.

shawnborton · 2024-08-27T12:31:28Z

@Krishna2323 everything is looking good to me, including button placement for categories! I'm going to follow up and get you a smaller version of the folder animation so that it feels more close to the older static version we had.

dannymcclain · 2024-08-27T13:24:49Z

I'd love to see the 20px padding for small viewports/the RHP. I agree with Jon that the padding looks a tad large.

shawnborton · 2024-08-27T14:41:07Z

Updated Lottie file is here: GenericEmptystate-082724-1.json.zip

@roryabraham can you compress that for us when you get a chance? Thanks!

roryabraham · 2024-08-27T16:16:53Z

unfortunately LottieFiles seems to be down this morning and it's not letting me upload anything. I'll have to try again later. I'll set a reminder

shawnborton · 2024-08-27T16:57:54Z

Sounds good, keep us posted!

shawnborton · 2024-08-27T16:59:16Z

@Krishna2323 would it be easy for you to change the padding of this area on mobile:

To be 20px?

Krishna2323 · 2024-08-28T17:37:43Z

@Krishna2323 would it be easy for you to change the padding of this area on mobile

Yes, will do that.

roryabraham · 2024-08-28T18:32:18Z

Updated animation GenericEmptyState animation: GenericEmptyState.lottie.zip

dubielzyk-expensify · 2024-08-28T23:53:11Z

Can you show me an example of that? I don't feel too strongly here... the 32px keeps things fluffy but I can see where it might feel off given that the workspace cards and other places go from 32px to 20px.

@shawnborton :

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-08-29T01:24:18Z

@Expensify/design, I have updated the empty state animation, and it looks correct to me, but I noticed one weird behaviour on the report field list page. When the RHP opens, the animation in the background stops. I’ve been trying to find a solution for that, but I haven't found any clues yet. @hungvu193, do you have any ideas about this?

Monosnap.screencast.2024-08-29.06-48-41.mp4

dubielzyk-expensify · 2024-08-29T04:17:54Z

This screen looks wrong to me and it's duplicating the animation which we don't want.

Maybe it would play if we don't have the animation in the Right Hand Panel as well? cc @Expensify/design

hungvu193 · 2024-08-29T07:12:45Z

. When the RHP opens, the animation in the background stops. I’ve been trying to find a solution for that, but I haven't found any clues yet. @hungvu193, do you have any ideas about this?

It came from #47960, we're hiding lottie view when navigation is not focused.

Screen.Recording.2024-08-29.at.14.11.36.mov

App/src/components/Lottie/index.tsx

Lines 35 to 37 in b9af3d1

    
           const unsubscribeNavigationFocus = navigation.addListener('focus', () => { 
        
               setIsHidden(false); 
        
           });

App/src/components/Lottie/index.tsx

Lines 47 to 49 in b9af3d1

    
           if (targetRouteName !== NAVIGATORS.RIGHT_MODAL_NAVIGATOR) { 
        
               setIsHidden(true); 
        
           }

hungvu193 · 2024-08-29T07:14:45Z

It was aimed to fix #47273. So I think that wont be an issue then? Would love to hear from design team.

shawnborton · 2024-08-29T12:20:18Z

This screen looks wrong to me and it's duplicating the animation which we don't want.

@dubielzyk-expensify why do you think it looks wrong? I guess it's technically an empty list, so we're showing the empty state we use for empty lists there... I don't feel strongly though, I could see using a lighter empty state for this one.

shawnborton · 2024-08-29T12:21:14Z

I think ideally the animation would still play in the background when the RHP is open though... so I would love to solve that if possible.

hungvu193 · 2024-08-29T12:23:57Z

I think ideally the animation would still play in the background when the RHP is open though... so I would love to solve that if possible.

Can you please comment in the original issue that I mentioned above?. It's not related to this PR 😄

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-09-18T12:54:42Z

@shawnborton @dannymcclain, looks better now?

Monosnap.screencast.2024-09-18.18-22-54.mp4

dannymcclain · 2024-09-18T13:05:57Z

I think that's looking pretty good to me! Will wait for Shawn's feedback too.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

shawnborton · 2024-09-18T21:22:28Z

That does feel better, yup.

shawnborton · 2024-09-18T21:24:32Z

Gonna run a test build but let's get this into final review!

github-actions · 2024-09-18T21:52:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48040/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48040/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48040/NewExpensify.dmg	https://48040.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-09-18T22:01:25Z

Hmm I'm definitely not trying to be difficult, but in this case here I would still expect the animation to be 220px tall - it would just be horizontally centered within the available background area. Instead it looks like we are shrinking based on the 400px width that it has:

Perhaps it's a simple fix? Take a look at this:

CleanShot.2024-09-18.at.23.59.26.mp4

Krishna2323 · 2024-09-18T23:08:43Z

Yeah, seems like a easy fix. Let me check.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 · 2024-09-19T09:28:23Z

        emptyStateFolderWebStyles: {
            ...sizing.w100,
-            minWidth: 300,
+            minWidth: 400,


@Krishna2323 Friendly reminder that you need to make sure you test this one on smaller device like iPhone8 or iPhoneSE

Yeah, thanks for the reminder. I tested on the web by resizing, but I still need to test on all platforms.

@hungvu193, tested on all platforms. I think you start reviewing now.

Monosnap.screencast.2024-09-20.04-45-12.mp4

Thanks man! Appreciate it, I'll give it a final review today!

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 · 2024-09-20T03:55:28Z

~~I'm blocked from testing because of this bug~~
Nevermind, force refresh will resolve it

Screen.Recording.2024-09-20.at.10.54.09.mov

hungvu193 · 2024-09-20T06:55:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-20.at.13.53.41.mov

Android: mWeb Chrome

Screen.Recording.2024-09-10.at.17.46.15.mov

iOS: Native

Screen.Recording.2024-09-10.at.16.12.34.mov

iOS: mWeb Safari

Screen.Recording.2024-09-10.at.15.50.42.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-10.at.15.21.33.mov

MacOS: Desktop

Screen.Recording.2024-09-10.at.15.14.28.mov

roryabraham · 2024-09-20T17:44:13Z

 }: EmptyStateComponentProps) {
    const styles = useThemeStyles();
    const [videoAspectRatio, setVideoAspectRatio] = useState(VIDEO_ASPECT_RATIO);
+    const {isSmallScreenWidth} = useResponsiveLayout();


NAB because it seems like all the styles are right in the screen recordings, but I think we might be able to use shouldUseNarrowLayout here, and generally that should be the default go-to instead of isSmallScreenWidth

OSBotify · 2024-09-20T17:55:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:29:05Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MonilBhavsar · 2024-09-27T01:22:08Z

This PR seem to have caused a regression #49744

hungvu193 · 2024-09-27T01:32:48Z

This PR seem to have caused a regression #49744

This PR only updated the lottie animation files so it won't cause that regression. Ideally, the regression will be from one of the PR that updated LottieView recently.

github-actions · 2024-09-27T17:44:00Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Update Wallet and Generic Folder empty state to use lottie anima…

c49cd8f

…tions. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested review from a team as code owners August 27, 2024 00:35

melvin-bot Bot requested review from hungvu193 and removed request for a team August 27, 2024 00:35

Krishna2323 marked this pull request as draft August 27, 2024 00:36

fix IOURequestStepCategory empty state.

8708b2e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 3 commits August 29, 2024 06:33

Merge branch 'Expensify:main' into krishna2323/issue/48013

795eb09

remove redundant code.

38a4e54

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

update GenericEmptyState.lottie file.

6616c56

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add minWidth for empty folder animation.

b9f96d3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix folder animation on other pages.

46ca8c7

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix animation width.

975164b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 reviewed Sep 19, 2024

View reviewed changes

Krishna2323 added 4 commits September 20, 2024 04:14

Merge branch 'Expensify:main' into krishna2323/issue/48013

857a8c5

minor update.

7bf97fa

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix animation width for native devices.

3dda855

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor changes & cleanup.

115b2fc

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 approved these changes Sep 20, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 20, 2024 06:58

roryabraham approved these changes Sep 20, 2024

View reviewed changes

roryabraham merged commit 513e6b3 into Expensify:main Sep 20, 2024

github-actions Bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

daledah mentioned this pull request Sep 25, 2024

feat: update trips empty state view #48060

Merged

50 tasks

MonilBhavsar mentioned this pull request Sep 26, 2024

[HOLD for payment 2024-10-17] [$250] Book travel - Book travel animation becomes blank while RHP is dismissed #49744

Closed

6 tasks

Shahidullah-Muffakir mentioned this pull request Apr 28, 2025

[Due for payment 2025-05-28] [$250] Reports > Trips empty state illustration is too large #60963

Closed

16 tasks

Conversation

Krishna2323 commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 27, 2024

Uh oh!

Krishna2323 commented Aug 27, 2024

Uh oh!

dubielzyk-expensify commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Aug 27, 2024

Uh oh!

shawnborton commented Aug 27, 2024

Uh oh!

dannymcclain commented Aug 27, 2024

Uh oh!

shawnborton commented Aug 27, 2024

Uh oh!

roryabraham commented Aug 27, 2024

Uh oh!

shawnborton commented Aug 27, 2024

Uh oh!

shawnborton commented Aug 27, 2024

Uh oh!

Krishna2323 commented Aug 28, 2024

Uh oh!

roryabraham commented Aug 28, 2024

Uh oh!

dubielzyk-expensify commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Aug 29, 2024

Uh oh!

dubielzyk-expensify commented Aug 29, 2024

Uh oh!

hungvu193 commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 29, 2024

Uh oh!

shawnborton commented Aug 29, 2024

Uh oh!

shawnborton commented Aug 29, 2024

Uh oh!

hungvu193 commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Sep 18, 2024

Uh oh!

dannymcclain commented Sep 18, 2024

Uh oh!

shawnborton commented Sep 18, 2024

Uh oh!

shawnborton commented Sep 18, 2024

Uh oh!

github-actions Bot commented Sep 18, 2024

Uh oh!

shawnborton commented Sep 18, 2024

Uh oh!

Krishna2323 commented Sep 18, 2024

Uh oh!

hungvu193 Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Sep 20, 2024

Krishna2323 commented Aug 27, 2024 •

edited

Loading

dubielzyk-expensify commented Aug 27, 2024 •

edited

Loading

dubielzyk-expensify commented Aug 28, 2024 •

edited

Loading

hungvu193 commented Aug 29, 2024 •

edited

Loading

hungvu193 commented Aug 29, 2024 •

edited

Loading

hungvu193 Sep 19, 2024 •

edited

Loading

hungvu193 commented Sep 20, 2024 •

edited

Loading