[CP Staging] fix undefined is displayed for GL code by nkdengineer · Pull Request #48539 · Expensify/App

nkdengineer · 2024-09-04T10:51:42Z

Details

fix undefined is displayed for GL code

Fixed Issues

$ #48535
PROPOSAL: #48535 (comment)

Tests

Go to Control workspace settings > Categories.
Click 3-dot menu.
Click Import spreadsheet.
Import the following CSV file.
Map Name, Enabled and GL code.
Click Import.
Click on the category that does not have GL code.
Verify that GL code is displayed as empty string

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Go to Control workspace settings > Categories.
Click 3-dot menu.
Click Import spreadsheet.
Import the following CSV file.
Map Name, Enabled and GL code.
Click Import.
Click on the category that does not have GL code.
Verify that GL code is displayed as empty string

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-04.at.17.56.39.mov

Android: mWeb Chrome

Screen.Recording.2024-09-04.at.17.52.54.mov

iOS: Native

Screen.Recording.2024-09-04.at.17.55.37.mov

iOS: mWeb Safari

Screen.Recording.2024-09-04.at.17.42.46.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-04.at.17.35.19.mp4

MacOS: Desktop

Screen.Recording.2024-09-04.at.17.58.43.mov

melvin-bot · 2024-09-04T11:04:04Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Thanks!

rushatgabhane · 2024-09-04T16:03:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

on its way

Android: mWeb Chrome

iOS: Native

on its way

iOS: mWeb Safari

on its way

MacOS: Chrome / Safari

Screen.Recording.2024-09-05.at.13.19.13.mov

MacOS: Desktop

rushatgabhane · 2024-09-04T16:17:59Z

I keep getting this error -

My CSV file -

Department,enabled,Region,Third
test-1,true,abc,123
test-2,false,def,456

Screen.Recording.2024-09-04.at.19.14.52.mov

rushatgabhane · 2024-09-04T16:18:19Z

@nkdengineer can you share your csv file?

nkdengineer · 2024-09-04T16:22:09Z

@rushatgabhane I used the csv file from description of the bug

rushatgabhane · 2024-09-04T16:29:37Z

No luck. Tried with the csv in issue

Screen.Recording.2024-09-04.at.19.26.29.mov

rushatgabhane · 2024-09-04T16:30:46Z

cc @mountiny can you give it a try?

nkdengineer · 2024-09-04T16:47:46Z

@rushatgabhane did you disable the strict mode.

rushatgabhane · 2024-09-05T02:16:19Z

i just tried with strict mode off. no luck

github-actions · 2024-09-05T10:09:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48539/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48539/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48539/NewExpensify.dmg	https://48539.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-09-05T10:14:42Z

It seems to work for me with the file from the linked issue
https://github.com/user-attachments/assets/23070566-a465-4f8d-8267-d3d847a100e9

mountiny

Thanks!

[CP Staging] fix undefined is displayed for GL code (cherry picked from commit 0742aab) (CP triggered by mountiny)

OSBotify · 2024-09-05T10:40:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-05T11:38:22Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.29-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-09-05T19:18:23Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.29-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkdengineer added 3 commits September 4, 2024 17:34

fix undefined is displayed for GL code

aee068c

remove log

8962c7f

remove hard code

6430995

nkdengineer marked this pull request as ready for review September 4, 2024 11:04

nkdengineer requested a review from a team as a code owner September 4, 2024 11:04

melvin-bot Bot requested a review from rushatgabhane September 4, 2024 11:04

melvin-bot Bot removed the request for review from a team September 4, 2024 11:04

nkdengineer mentioned this pull request Sep 4, 2024

[HOLD for payment 2024-09-12][$125] Import categories - GL code field shows undefined when imported category does not have GL code #48535

Closed

6 tasks

mountiny assigned nkdengineer Sep 4, 2024

mountiny changed the title ~~fix undefined is displayed for GL code~~ [CP Staging] fix undefined is displayed for GL code Sep 4, 2024

mountiny self-requested a review September 4, 2024 15:44

mountiny approved these changes Sep 4, 2024

View reviewed changes

mountiny added the Ready To Build label Sep 5, 2024

rushatgabhane approved these changes Sep 5, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny September 5, 2024 10:24

mountiny approved these changes Sep 5, 2024

View reviewed changes

mountiny merged commit 0742aab into Expensify:main Sep 5, 2024

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Sep 5, 2024

OSBotify pushed a commit that referenced this pull request Sep 5, 2024

Merge pull request #48539 from nkdengineer/fix/48535

82e4256

[CP Staging] fix undefined is displayed for GL code (cherry picked from commit 0742aab) (CP triggered by mountiny)

rushatgabhane mentioned this pull request Feb 11, 2025

[PAID 02/19] [Support CSV] Create import flow for tags #47870

Closed

Conversation

nkdengineer commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 4, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Sep 4, 2024

Uh oh!

rushatgabhane commented Sep 4, 2024

Uh oh!

nkdengineer commented Sep 4, 2024

Uh oh!

rushatgabhane commented Sep 4, 2024

Uh oh!

rushatgabhane commented Sep 4, 2024

Uh oh!

nkdengineer commented Sep 4, 2024

Uh oh!

rushatgabhane commented Sep 5, 2024

Uh oh!

github-actions Bot commented Sep 5, 2024

Uh oh!

mountiny commented Sep 5, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 5, 2024

Uh oh!

OSBotify commented Sep 5, 2024

Uh oh!

OSBotify commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Sep 4, 2024 •

edited

Loading

rushatgabhane commented Sep 4, 2024 •

edited

Loading