Skip to content

Fix edit composer isn't focused #48973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youssef-lr merged 2 commits into from
Sep 23, 2024
Merged

Fix edit composer isn't focused #48973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97499db
fix edit composer isn't focused
bernhardoj Sep 11, 2024
3e2b7d6
prettier
bernhardoj Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/libs/focusTextInputAfterAnimation/index.android.ts
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/libs/focusTextInputAfterAnimation/index.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/libs/focusTextInputAfterAnimation/types.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/pages/home/report/ReportActionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
import ControlSelection from '@libs/ControlSelection';
import * as DeviceCapabilities from '@libs/DeviceCapabilities';
import * as ErrorUtils from '@libs/ErrorUtils';
import focusTextInputAfterAnimation from '@libs/focusTextInputAfterAnimation';
import focusComposerWithDelay from '@libs/focusComposerWithDelay';
import ModifiedExpenseMessage from '@libs/ModifiedExpenseMessage';
import Navigation from '@libs/Navigation/Navigation';
import Permissions from '@libs/Permissions';
Expand Down Expand Up @@ -199,7 +199,7 @@ function ReportActionItem({
const [moderationDecision, setModerationDecision] = useState<OnyxTypes.DecisionName>(CONST.MODERATION.MODERATOR_DECISION_APPROVED);
const reactionListRef = useContext(ReactionListContext);
const {updateHiddenAttachments} = useContext(ReportAttachmentsContext);
const textInputRef = useRef<TextInput | HTMLTextAreaElement>();
const textInputRef = useRef<TextInput | HTMLTextAreaElement>(null);
const popoverAnchorRef = useRef<Exclude<ReportActionContextMenu.ContextMenuAnchor, TextInput>>(null);
const downloadedPreviews = useRef<string[]>([]);
const prevDraftMessage = usePrevious(draftMessage);
Expand Down Expand Up @@ -274,7 +274,7 @@ function ReportActionItem({
return;
}

focusTextInputAfterAnimation(textInputRef.current, 100);
focusComposerWithDelay(textInputRef.current)(true);
}, [prevDraftMessage, draftMessage]);

useEffect(() => {
Expand Down