Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135
Merged
Conversation
trying to remove the duplicate FAQ section from the side bar
Updating the FAQ section so it collapses
Christinadobrzyn
requested review from
blimpich
and removed request for
a team
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️ |
Creating a new webpage for workflows
Contributor
|
@Christinadobrzyn can you confirm that your changes worked as expected in the test deploy? #49135 (comment) |
mjasikowski
previously approved these changes
Sep 13, 2024
mjasikowski
dismissed
their stale review
Reviewed without checklist, my bad
mjasikowski
requested changes
Sep 13, 2024
mjasikowski
left a comment
mjasikowski
left a comment
Contributor
There was a problem hiding this comment.
Just one small change, but it would be also great if you could directly link to the slack or GitHub discussion relevant to the issue in the description, so we can see the context.
|
|
||
|
|
||
| # FAQs | ||
| {% include faq-begin.md %} |
Contributor
There was a problem hiding this comment.
You're missing an {% include faq-end.md %} at the end of the FAQ. This in turns makes a stray </div> appear at the end of the page:
Contributor
Author
There was a problem hiding this comment.
Thanks @mjasikowski - do I need to approve the change or submit a new PR, I'm not finding that DIV anywhere in the changes
Contributor
There was a problem hiding this comment.
@Christinadobrzyn can you edit this PR to have {% include faq-end.md %} on line 93 of docs/articles/new-expensify/expenses-&-payments/Send-an-invoice.md? That's what @mjasikowski is saying that we are missing 👍
You added {% include faq-begin.md %} on line 65 but if you add that you also need to include a corresponding {% include faq-end.md %} in order to end the FAQ and have it styled correctly.
Contributor
Author
There was a problem hiding this comment.
Ah yes, done! I added {% include faq-end.md %} to the end of both FAQ edits.
Contributor
Author
|
Gonna try to resolve that checklist error - I added it again in the OP but that didn't resolve it. Going to add it here as a new comment to see if that works. PR Author Checklist
|
Contributor
|
@Christinadobrzyn the failing check is because neither @mjasikowski or I have done the checklist as a reviewer, you're good on the Author side |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
removed <div> from the end of the article (line 56 or something) and added {% include faq-end.md %}
removed <div> and added {% include faq-end.md %} to the end of the article
Added {% include faq-end.md %} to the end of the FAQ section
blimpich
requested changes
Sep 16, 2024
blimpich
left a comment
blimpich
left a comment
Contributor
There was a problem hiding this comment.
Couple more tweaks, getting close.
Comment on lines
-59
to
+58
| </div> | ||
| {% include faq-end.md %} |
Contributor
There was a problem hiding this comment.
Can you revert this? We already have a {% include faq-end.md %} on line 56 here, and we also need the </div> tag in order to close the opening <div> tag from line 5 of this file.
Contributor
There was a problem hiding this comment.
By "revert" I mean add the div tag back and get rid of the {% include faq-end.md %}
Contributor
Author
There was a problem hiding this comment.
Ah okay, I updated the article! TY!
|
|
||
|
|
||
| </div> | ||
| {% include faq-end.md %} |
Contributor
There was a problem hiding this comment.
We don't want to delete the </div>. We have an opening <div> tag on line 5 of this file, and this is its closing tag. Please see this article for an example of what we want.
It should be like this:
{% include faq-end.md %}
</div>
Contributor
Author
There was a problem hiding this comment.
Ah, okay, I updated the article!
added this to the end of the article.
{% include faq-end.md %}
</div>
added this to the end of the article
{% include faq-end.md %}
</div>
blimpich
previously approved these changes
Sep 16, 2024
blimpich
left a comment
blimpich
left a comment
Contributor
There was a problem hiding this comment.
LGTM! All yours @mjasikowski
Related to GH - Expensify/Expensify#427929 Adding images to the article - https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice
blimpich
approved these changes
Sep 16, 2024
Contributor
Author
|
Hi! just a side note that I added two images to this PR as part of this GH https://github.com/Expensify/Expensify/issues/427929 so I don't know if you need to review those additional parts of this PR @blimpich |
Contributor
|
@mjasikowski all yours |
mjasikowski
approved these changes
Sep 20, 2024
Contributor
|
all good! |
67 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.40-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Updating the FAQ section to remove this dupe mention
Also making the Send an Invoice FAQ section collapsable
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.