Animate the paid checkmark when paying expense by bernhardoj · Pull Request #49438 · Expensify/App

bernhardoj · 2024-09-19T06:22:45Z

Details

We want to also animate the checkmark when paying expense.

Fixed Issues

$ #48036
PROPOSAL: #48036 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open your policy expense chat
Submit a request. Approve if needed.
Pay the money request
Verify the pay button animates (as shown [Payment due 08-23]Emphasize completed payments with animation #48036 (comment))

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-09-19T06:22:50Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-09-19T06:31:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

ios.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-09-19T06:32:41Z

@bernhardoj
Could you please run prettier and lint ?

bernhardoj · 2024-09-19T06:57:33Z

Done

ZhenjaHorbach · 2024-09-19T07:29:57Z

#48036 (comment)

I also noticed that we have animation for the header preview on example

ZhenjaHorbach · 2024-09-19T07:37:58Z

Actually also notice that when we have error
The styles are a bit broken
And there is no space between the button and the description

bernhardoj · 2024-09-19T08:28:17Z

Done.

It's quite different though because looks like on the GIF, there are 2 preview messages, 1 fades out, 1 fades in, while in the component, we reuse 1 text only.

a.mp4

ZhenjaHorbach · 2024-09-19T08:40:54Z

We need to fix eslint one more time 😅

ZhenjaHorbach · 2024-09-19T12:57:00Z

Everything is good now
Thanks !

ZhenjaHorbach · 2024-09-19T12:57:58Z

The only thing I would do
I would increase the animation duration !
But it's not critical !

Anyway LGTM !

roryabraham · 2024-09-19T21:39:39Z

        height.value = withDelay(
            totalDelay,
-            withTiming(0, {duration: CONST.ANIMATION_PAY_BUTTON_DURATION}, () => runOnJS(onAnimationFinish)()),
+            withTiming(0, {duration: CONST.ANIMATION_PAID_DURATION}, () => runOnJS(onAnimationFinish)()),


Small thing I'm noticing is that we're just using withTiming, but we could use withSpring and/or withBounce to give these animations a more natural feel.

we talked in slack about using bounce for showing the checkmark

dubielzyk-expensify · 2024-09-20T03:53:25Z

The recording in the original post looks pretty good. Would be cool to delay the checkmark animation about 300ms to ensure it catches the attention a bit more.

bernhardoj · 2024-09-20T04:55:42Z

@roryabraham @dubielzyk-expensify Checkmark Delay 300ms + (Fade replaced with) Bounce (using withSpring)

web.mp4

Shorter bounce duration (200ms)

web.mp4

shawnborton · 2024-09-20T06:42:49Z

Lovely! I am digging the shorter duration version more I think.

dannymcclain · 2024-09-20T13:25:33Z

Same! I am loving the 200ms bounce checkmark.

bernhardoj · 2024-09-20T14:17:05Z

Great, pushed the update

cc: @ZhenjaHorbach @roryabraham

ZhenjaHorbach · 2024-09-20T15:32:14Z

Looks nice and works well !

OSBotify · 2024-09-20T16:53:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:30:17Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-27T17:45:12Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2024-10-23T23:41:45Z


    const iouSettled = ReportUtils.isSettled(iouReportID) || action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;
+    const previewMessageOpacity = useSharedValue(1);
+    const previewMessageStyle = useAnimatedStyle(() => ({


bug: preview does not display checkmark - #50219

for details, see - #50554 (comment).

bernhardoj added 3 commits September 19, 2024 13:16

rename

b9799bf

animate the checkmark

13ee2d7

animate the spacing too

a524085

bernhardoj requested a review from a team as a code owner September 19, 2024 06:22

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team September 19, 2024 06:22

replace withOnyx with useOnyx

a4beb09

lint

aaeef2e

bernhardoj added 2 commits September 19, 2024 15:26

fix missing spacing

b382e0e

animate preview text

5bdbedf

lint

8fc1158

lint

5afcac4

ZhenjaHorbach approved these changes Sep 19, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 19, 2024 12:57

roryabraham requested a review from a team September 19, 2024 18:33

roryabraham reviewed Sep 19, 2024

View reviewed changes

Merge branch 'main' into feat/48036-animate-checkmark

009e2ea

change the checkmark animation to bounce and add delay

a46ffb8

roryabraham approved these changes Sep 20, 2024

View reviewed changes

roryabraham merged commit 0d0fb4e into Expensify:main Sep 20, 2024

Christinadobrzyn mentioned this pull request Sep 23, 2024

[Payment due 08-23]Emphasize completed payments with animation #48036

Closed

github-actions Bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

situchan mentioned this pull request Sep 30, 2024

[PAYMENT 12/25 regression] [$250] Feature Request: Implement to use a 👍icon next to approved report preview #49847

Closed

6 tasks

rushatgabhane reviewed Oct 23, 2024

View reviewed changes

rushatgabhane mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-10-25] [$250] Expense - Expense preview does not display green checkmark when the expense is paid #50219

Closed

6 tasks

Conversation

bernhardoj commented Sep 19, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 19, 2024

Uh oh!

ZhenjaHorbach commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Sep 19, 2024

Uh oh!

bernhardoj commented Sep 19, 2024

Uh oh!

ZhenjaHorbach commented Sep 19, 2024

Uh oh!

ZhenjaHorbach commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 19, 2024

Uh oh!

ZhenjaHorbach commented Sep 19, 2024

Uh oh!

roryabraham Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Sep 20, 2024

Uh oh!

bernhardoj commented Sep 20, 2024

Uh oh!

shawnborton commented Sep 20, 2024

Uh oh!

dannymcclain commented Sep 20, 2024

Uh oh!

bernhardoj commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Sep 20, 2024

Uh oh!

OSBotify commented Sep 24, 2024

Uh oh!

github-actions Bot commented Sep 27, 2024

Uh oh!

rushatgabhane Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ZhenjaHorbach commented Sep 19, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 19, 2024 •

edited

Loading

bernhardoj commented Sep 19, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 19, 2024 •

edited

Loading

roryabraham Sep 19, 2024 •

edited

Loading

bernhardoj commented Sep 20, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 20, 2024 •

edited

Loading

rushatgabhane Oct 23, 2024 •

edited

Loading