Simplify TermsWithLicenses and SignInPageLayout#4964
Merged
Conversation
luacmartins
approved these changes
Sep 1, 2021
luacmartins
left a comment
luacmartins
left a comment
Contributor
There was a problem hiding this comment.
This is great! Thanks for fixing this @roryabraham!
Just a small NAB: I noticed that the LocalePicker has 2 borders. This PR did not introduce this, but would you mind fixing that? Or if you prefer, I can open another issue for it.
Contributor
Author
|
There's another issue already open I believe. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
55 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.0.91-1 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
While fiddling around testing for #4958, I discovered a large amount of duplicate code an unnecessarily divided implementations. This PR does some minor refactoring to simplify some redundant code in the signin/password pages. There's still more that could be done to clean this up, but this is a start.
Fixed Issues
None.
Tests / QA Steps
We just need to do regression testing of the signup/login pages – taking particular note of the Terms and Licenses at the bottom of the screen.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android