Change Fullstory recording start conditions by danieldoglas · Pull Request #50516 · Expensify/App

danieldoglas · 2024-10-09T17:46:20Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/434803
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…sers

melvin-bot · 2024-10-09T17:46:25Z

@paultsimura @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

danieldoglas · 2024-10-09T17:48:40Z

No need for C+ testing here.

danieldoglas · 2024-10-09T18:08:17Z

The lint error is:

308:16 error 'withOnyx' is deprecated. Use useOnyx instead of withOnyx whenever possible.

This is not related to any changes I'm doing in this PR, and I'm not sure how changing those would impact the PR app. @AndrewGable should I implement those either way?

AndrewGable · 2024-10-09T18:10:19Z

Yes I think we are supposed to update any of them that are included in the files changed, is it a big change?

danieldoglas · 2024-10-09T18:12:18Z

Not huge:

App/src/Expensify.tsx

Lines 309 to 333 in e8c4fdc

    
           isCheckingPublicRoom: { 
        
               key: ONYXKEYS.IS_CHECKING_PUBLIC_ROOM, 
        
               initWithStoredValues: false, 
        
           }, 
        
           updateAvailable: { 
        
               key: ONYXKEYS.UPDATE_AVAILABLE, 
        
               initWithStoredValues: false, 
        
           }, 
        
           updateRequired: { 
        
               key: ONYXKEYS.UPDATE_REQUIRED, 
        
               initWithStoredValues: false, 
        
           }, 
        
           isSidebarLoaded: { 
        
               key: ONYXKEYS.IS_SIDEBAR_LOADED, 
        
           }, 
        
           screenShareRequest: { 
        
               key: ONYXKEYS.SCREEN_SHARE_REQUEST, 
        
           }, 
        
           focusModeNotification: { 
        
               key: ONYXKEYS.FOCUS_MODE_NOTIFICATION, 
        
               initWithStoredValues: false, 
        
           }, 
        
           lastVisitedPath: { 
        
               key: ONYXKEYS.LAST_VISITED_PATH, 
        
           },

AndrewGable · 2024-10-09T18:15:58Z

I'd prefer to include it then just to follow our process

danieldoglas · 2024-10-09T18:28:35Z


        // Initialize Fullstory lib
-        FS.init();
+        FS.init(userMetadata);


@AndrewGable We don't need to rerun useLayoutEffect when userMetadata changes since that will be updated through another flow. Will userMetadata be available inside useLayoutEffect if it's not part of the dependencies?

This is giving a warning:

155:8 warning React Hook useLayoutEffect has a missing dependency: 'userMetadata'. Either include it or remove the dependency array react-hooks/exhaustive-deps

Yes I believe it should be available still, however, this function will just be run once on initial render and that's it.

That's fine, the next runs will happen when user_metadata key is updated. Added a linter disable here.

AndrewGable · 2024-10-09T22:03:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

danieldoglas · 2024-10-13T20:39:31Z

bump @AndrewGable, if we can try to merge this today it'd be great!

OSBotify · 2024-10-16T21:49:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:59:26Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:48:16Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2024-10-21T22:34:20Z

-    updateRequired: {
-        key: ONYXKEYS.UPDATE_REQUIRED,
-        initWithStoredValues: false,
-    },


@danieldoglas I think there's a very likely possibility this change has been leading to issues with the updateRequired logic. The intended behavior is that this value will only be true when it is explicitly set to true AFTER the component has mounted. If the value gets stuck on true then the user will get stuck and be unable to upgrade since they'd be on the correct version already, but have out of date Onyx values.

marcaaron · 2024-10-21T22:41:18Z

@AndrewGable I think we should revert the useOnyx() parts of this and CP to staging while we sort out https://github.com/Expensify/Expensify/issues/437830 since it bricks the app for people and is on production.

marcaaron · 2024-10-21T22:45:04Z

Oh I see you can pass {initWithStoredValues: false} to useOnyx(). Let's do that then.

hoangzinh · 2025-07-15T21:21:21Z

    const [lastRoute] = useOnyx(ONYXKEYS.LAST_ROUTE);
+    const [userMetadata] = useOnyx(ONYXKEYS.USER_METADATA);
    const [shouldShowRequire2FAModal, setShouldShowRequire2FAModal] = useState(false);
+    const [isCheckingPublicRoom] = useOnyx(ONYXKEYS.IS_CHECKING_PUBLIC_ROOM);


We should keep the default value of isCheckingPublicRoom = true as previously, there is a hidden bug that cause login page briefly shown when navigate via public room link as anonymous. More details here: #64638 (comment)

danieldoglas added 3 commits October 9, 2024 14:30

fixed web to only record if identified

33cfb76

simplifying web

4259ad8

adjusting mobile to only record if we have a way of identifying our u…

63787c4

…sers

danieldoglas requested a review from AndrewGable October 9, 2024 17:46

danieldoglas self-assigned this Oct 9, 2024

danieldoglas requested a review from a team as a code owner October 9, 2024 17:46

melvin-bot Bot requested a review from paultsimura October 9, 2024 17:46

melvin-bot Bot removed the request for review from a team October 9, 2024 17:46

danieldoglas removed the request for review from paultsimura October 9, 2024 17:48

danieldoglas added 4 commits October 9, 2024 14:55

adjusting session to be passed as a parameter to the FS lib

374d964

Merge branch 'main' into dsilva_fullstoryStartRecordingSettings

fa01ff6

fixing issues with eslint

0c4dc63

fixing last style issue

e8c4fdc

danieldoglas added 3 commits October 9, 2024 15:18

removing withOnyx

3431717

exporting component correctly

1175527

style

741c5c1

danieldoglas commented Oct 9, 2024

View reviewed changes

danieldoglas added 2 commits October 9, 2024 17:26

disable linter

9e481eb

moving value to useEffect

084aaac

AndrewGable previously approved these changes Oct 9, 2024

View reviewed changes

Merge branch 'main' into dsilva_fullstoryStartRecordingSettings

99f6ecf

danieldoglas dismissed AndrewGable’s stale review via 99f6ecf October 12, 2024 19:56

AndrewGable approved these changes Oct 16, 2024

View reviewed changes

AndrewGable merged commit 286212c into main Oct 16, 2024

AndrewGable deleted the dsilva_fullstoryStartRecordingSettings branch October 16, 2024 21:37

github-actions Bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

marcaaron reviewed Oct 21, 2024

View reviewed changes

bernhardoj mentioned this pull request Jun 20, 2025

[Due for payment 2025-07-15] [Due for payment 2025-07-14] [$250] Public room - Login page briefly shown when navigate via public room link as anonymous #64638

Closed

8 tasks

hoangzinh reviewed Jul 15, 2025

View reviewed changes

Conversation

danieldoglas commented Oct 9, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2024

Uh oh!

danieldoglas commented Oct 9, 2024

Uh oh!

danieldoglas commented Oct 9, 2024

Uh oh!

AndrewGable commented Oct 9, 2024

Uh oh!

danieldoglas commented Oct 9, 2024

Uh oh!

AndrewGable commented Oct 9, 2024

Uh oh!

danieldoglas Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

danieldoglas Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

AndrewGable Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

danieldoglas Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

AndrewGable commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

danieldoglas commented Oct 13, 2024

Uh oh!

OSBotify commented Oct 16, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

github-actions Bot commented Oct 18, 2024

Uh oh!

marcaaron Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

marcaaron commented Oct 21, 2024

Uh oh!

marcaaron commented Oct 21, 2024

Uh oh!

hoangzinh Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AndrewGable commented Oct 9, 2024 •

edited

Loading