[QBD] [Import] Chart of accounts page by hoangzinh · Pull Request #50545 · Expensify/App

hoangzinh · 2024-10-10T09:09:17Z

Details

Fixed Issues

$ #49703
PROPOSAL:

Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Import" menu under QuickBooks Desktop connection
Click on "Chart of accounts" menu item
Verify that it opens Chart of accounts page
Verify that there is 2 toggle button

1 toggle button "Import" and it's enabled & locked
1 toggle button "Enabled"

Switch on/ff "Enabled" toggle button
Verify it saves successfully setting to server

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-15.at.16.53.26.android.mov

Android: mWeb Chrome

Screen.Recording.2024-10-15.at.16.54.34.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-15.at.17.03.47.mov

iOS: mWeb Safari

Screen.Recording.2024-10-15.at.16.58.17.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-15.at.16.49.14.web.mov

MacOS: Desktop

Screen.Recording.2024-10-15.at.16.50.38.desktop.mov

melvin-bot · 2024-10-10T09:45:44Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-10-10T18:20:29Z

@hoangzinh
Is it ready for review ?

hoangzinh · 2024-10-10T23:29:04Z

ah yes it's ready @ZhenjaHorbach

hoangzinh · 2024-10-10T23:30:26Z

@ZhenjaHorbach fyi, @lakchote and I had some discussion about this issue here https://new.expensify.com//r/4322790092549381/7849639291558303297

lakchote · 2024-10-11T04:56:00Z

@hoangzinh I've talked again with @francoisl who led the Codat integration for QBD.

There was some confusion about the setting we were talking about. The Enable toggle will not be locked.

However, this is not supported yet in QBD. In the meantime, could you please hide it and put it behind a TODO?

lakchote · 2024-10-11T07:54:37Z

+            <Text style={styles.pv5}>{translate('workspace.qbd.accountsSwitchTitle')}</Text>
+            <ToggleSettingOptionRow
+                title={translate('workspace.common.enabled')}
+                subtitle={translate('workspace.qbd.accountsSwitchDescription')}
+                switchAccessibilityLabel={translate('workspace.accounting.accounts')}
+                shouldPlaceSubtitleBelowSwitch
+                isActive
+                onToggle={() => {}}
+                disabled
+                showLockIcon
+            />


Let's put this behind a TODO.

See #50545 (comment)

Updated in this commit 94eb5b4

lakchote

One comment related to the enabled categories, other than LGTM.

ZhenjaHorbach · 2024-10-11T13:57:20Z

+            featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
+            contentContainerStyle={[styles.pb2, styles.ph5]}
+            connectionName={CONST.POLICY.CONNECTIONS.NAME.QBD}
+            shouldBeBlocked={!canUseNewDotQBD}


Let's add TODO here

Added here 4fd1844

ZhenjaHorbach · 2024-10-11T16:28:39Z

-            action: () => {}, // TODO: [QBD] will be implemented in https://github.com/Expensify/App/issues/49703
+            action: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_CHART_OF_ACCOUNTS.getRoute(policyID)),
            title: translate('workspace.accounting.importAsCategory'),
            subscribedSettings: [CONST.QUICKBOOKS_CONFIG.ENABLE_NEW_CATEGORIES],


Actually, this seems a bit redundant
Since we have nothing to subscribe to at the moment

You;re right. Updated here 73be4e5

ZhenjaHorbach · 2024-10-11T16:33:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2024-10-15.12.58.30.mov

Android: mWeb Chrome

2024-10-15.12.59.16.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

Web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-10-11T17:04:22Z

LGTM !

lakchote · 2024-10-11T20:17:17Z

@hoangzinh the PRs for the enable new categories toggle have been merged.

Could you please adjust code, remove the TODO, and call UpdateQuickbooksDesktopEnableNewCategories with settingValue?

francoisl · 2024-10-11T20:22:42Z

The code for that command won't be deployed until Monday though FYI, tests won't work in the meantime.

hoangzinh · 2024-10-12T05:44:13Z

@hoangzinh the PRs for the enable new categories toggle have been merged.

Could you please adjust code, remove the TODO, and call UpdateQuickbooksDesktopEnableNewCategories with settingValue?

@lakchote Updated. Btw, can you share the Onyx key of this setting? I couldn't find it in the example Onyx data of DD. Is it 'enableNewCategories'?

francoisl · 2024-10-13T20:00:43Z

Btw, can you share the Onyx key of this setting? I couldn't find it in the example Onyx data of DD. Is it 'enableNewCategories'?

Yes that's correct, enableNewCategories.

hoangzinh · 2024-10-14T10:05:06Z

Thank you @francoisl. Please let us know when the PR is deployed.

lakchote · 2024-10-15T07:04:15Z

@hoangzinh PR has been deployed to staging for the API command UpdateQuickbooksDesktopEnableNewCategories.

hoangzinh · 2024-10-15T09:55:35Z

It worked @lakchote

hoangzinh · 2024-10-15T10:06:05Z

Updated test cases and recordings. This PR is ready for re-review. @ZhenjaHorbach do you mind reviewing this PR again? Thank you.

ZhenjaHorbach · 2024-10-15T10:07:01Z

Updated test cases and recordings. This PR is ready for re-review. @ZhenjaHorbach do you mind reviewing this PR again? Thank you.

Yeah
Sure
I will start after 20 minutes

ZhenjaHorbach · 2024-10-15T11:02:58Z

Everything looks good !

ZhenjaHorbach · 2024-10-15T11:03:37Z

@lakchote
All yours !

OSBotify · 2024-10-15T13:54:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:59:35Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:48:25Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh added 2 commits October 10, 2024 16:00

Setup screen & route for QBD import chart of accounts page

a754ea3

Implement QBD chart of accounts page

3e0b832

hoangzinh commented Oct 10, 2024

View reviewed changes

Comment thread src/languages/es.ts

hoangzinh marked this pull request as ready for review October 10, 2024 09:45

hoangzinh requested a review from a team as a code owner October 10, 2024 09:45

melvin-bot Bot requested a review from ZhenjaHorbach October 10, 2024 09:45

melvin-bot Bot removed the request for review from a team October 10, 2024 09:45

lakchote self-requested a review October 11, 2024 04:47

lakchote reviewed Oct 11, 2024

View reviewed changes

hoangzinh added 2 commits October 11, 2024 15:50

Temporary hide enabled button

94eb5b4

Fix eslint

66ae508

ZhenjaHorbach reviewed Oct 11, 2024

View reviewed changes

Add todo comment

4fd1844

ZhenjaHorbach reviewed Oct 11, 2024

View reviewed changes

Remove redundant subscribed settings

73be4e5

ZhenjaHorbach approved these changes Oct 11, 2024

View reviewed changes

melvin-bot Bot requested a review from lakchote October 11, 2024 17:04

hoangzinh added 2 commits October 12, 2024 12:29

Merge branch 'main' into 49703-qbd-chart-of-accounts-page

918fc91

Update QBD enabled new categories setting

3f06ba0

Fix clear QBD error field

6f767e4

hoangzinh added 2 commits October 15, 2024 16:39

Merge branch 'main' into 49703-qbd-chart-of-accounts-page

7583d30

Fix merge main

37dad4c

ZhenjaHorbach approved these changes Oct 15, 2024

View reviewed changes

lakchote approved these changes Oct 15, 2024

View reviewed changes

lakchote merged commit 5730f46 into Expensify:main Oct 15, 2024

github-actions Bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

melvin-bot Bot mentioned this pull request Oct 18, 2024

[HOLD for payment 2024-10-25] [Wave Control] [QBD] [Import] Chart of accounts page #49703

Closed

Conversation

hoangzinh commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 10, 2024

Uh oh!

ZhenjaHorbach commented Oct 10, 2024

Uh oh!

hoangzinh commented Oct 10, 2024

Uh oh!

hoangzinh commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Oct 11, 2024

Uh oh!

lakchote Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Oct 11, 2024

Uh oh!

lakchote commented Oct 11, 2024

Uh oh!

francoisl commented Oct 11, 2024

Uh oh!

hoangzinh commented Oct 12, 2024

Uh oh!

francoisl commented Oct 13, 2024

Uh oh!

hoangzinh commented Oct 14, 2024

Uh oh!

lakchote commented Oct 15, 2024

Uh oh!

hoangzinh commented Oct 15, 2024

Uh oh!

hoangzinh commented Oct 15, 2024

Uh oh!

ZhenjaHorbach commented Oct 15, 2024

Uh oh!

ZhenjaHorbach commented Oct 15, 2024

Uh oh!

ZhenjaHorbach commented Oct 15, 2024

Uh oh!

OSBotify commented Oct 15, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

github-actions Bot commented Oct 18, 2024

Uh oh!

Reviewers

hoangzinh commented Oct 10, 2024 •

edited

Loading

hoangzinh commented Oct 10, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 11, 2024 •

edited

Loading