-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update Payment flow on clicking Pay #50640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristipaval
merged 52 commits into
Expensify:main
from
rezkiy37:feature/45171-invoicing-payment-flow
Mar 19, 2025
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
31823cc
add strings
rezkiy37 3948c12
add invoice case for getBankAccountRoute
rezkiy37 a2d1b9a
add invoice payment menu items
rezkiy37 f4f708a
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 905f8e5
add payment method button
rezkiy37 94647a4
pay invoice command accepts method id
rezkiy37 0080e82
integrate payment logic
rezkiy37 abed35d
pass account type
rezkiy37 e45613d
set add debit card route
rezkiy37 8b081a7
render all payment methods
rezkiy37 1302948
clear todo
rezkiy37 699a035
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 2e05df0
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 16f0136
Revert "set add debit card route"
rezkiy37 dbd3e10
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 4a8928a
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 5168b6f
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 3e5d028
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 ee24a29
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 27edab4
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 38d4636
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 90712f2
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 05209e7
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 6f13e9d
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 529231e
use expensify payment type
rezkiy37 facf112
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 972bd42
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 006cd92
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 e263162
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 64d1807
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 91fcece
fix rulesdir/no-default-id-values
rezkiy37 83ee038
Add logging for invalid policyID and threadReportID in route generation
rezkiy37 fae4377
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 439bc38
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 369b329
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 4b39e70
Refactor SettlementButton component to use named imports for better c…
rezkiy37 5a69e42
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 916976c
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 a27281e
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 95cd4b4
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 b6bf856
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 b7a4859
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 c4edf8b
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 5f094bc
Conditionally show payment methods based on currency support
rezkiy37 0ccfb97
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 ea3896d
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 b4b8fdc
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 a91a7a9
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 572b45d
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 be147e5
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 047c8f8
Refactor payInvoice function calls to simplify parameters in MoneyRep…
rezkiy37 f8629cd
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1513,7 +1513,15 @@ function isPublicAnnounceRoom(report: OnyxEntry<Report>): boolean { | |
| * else since the report is a personal IOU, the route should be for personal bank account. | ||
| */ | ||
| function getBankAccountRoute(report: OnyxEntry<Report>): Route { | ||
| return isPolicyExpenseChat(report) ? ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(report?.policyID) : ROUTES.SETTINGS_ADD_BANK_ACCOUNT; | ||
| if (isPolicyExpenseChat(report)) { | ||
| return ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(report?.policyID); | ||
| } | ||
|
|
||
| if (isInvoiceRoom(report) && report?.invoiceReceiver?.type === CONST.REPORT.INVOICE_RECEIVER_TYPE.BUSINESS) { | ||
| return ROUTES.WORKSPACE_INVOICES.getRoute(report?.invoiceReceiver?.policyID); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👋 Coming from #64585, this has caused an issue when the wrong page opens when clicking "Add bank account" under some circumstances |
||
| } | ||
|
|
||
| return ROUTES.SETTINGS_ADD_BANK_ACCOUNT; | ||
| } | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to pass
iconStyles,iconHeight,andiconWidthhere, otherwise the bank icons are too small. More details: #60579 (comment)