Save VBA flow information as users type#5114
Merged
Merged
Conversation
Jag96
suggested changes
Sep 9, 2021
| })); | ||
| this.setState((prevState) => { | ||
| this.debouncedUpdateReimbursementAccountDraft({hasAcceptedTerms: !prevState.hasAcceptedTerms}); | ||
| return {hasAcceptedTerms: !prevState.hasAcceptedTerms}; |
Contributor
There was a problem hiding this comment.
Looks like this is still duplicated
marcaaron
requested changes
Sep 9, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
Looking good - caught one more thing.
Contributor
Author
|
Updated! |
Contributor
|
@luacmartins conflicts, will review once resolved! |
Contributor
Author
|
Updated! |
marcaaron
reviewed
Sep 9, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
This LGTM but I still need to test. I also had one more small comment.
Contributor
Author
|
Updated! |
marcaaron
approved these changes
Sep 9, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
LGTM and works great. Nice job!
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
|
Thanks for all the feedback @Jag96 and @marcaaron! I really appreciate it! |
10 tasks
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.0.96-1 🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should have their VBA flow information saved as they type, so if they accidentally closed the pane or refresh the page, the data should show up again.
cc @marcaaron
Fixed Issues
$ #5035
Tests
Settings > Select your Workspace > Get StartedSave & Continuein each step).Testing potential Onyx race condition
Beneficial ownersstep, checkSomebody else owns more than 25% of <companyName>. Add 3 additional beneficial owners.Applicationtab and search for thereimbursementAccountDraftkey underlocalStorage.Remove this beneficial ownerand verify that thebeneficialOwnersarray display the 2 remainingbeneficialOwnersand notnull. Repeat the step until you are left with just one owner left.QA Steps
Steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
mWeb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov