Skip to content

Change "Beneficial Owners" to "Additional Information" in VBA flow #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 4 commits into from
Sep 9, 2021
Merged

Change "Beneficial Owners" to "Additional Information" in VBA flow #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff543a4
Use Additional Information as a header instead of Beneficial Owners
mountiny Sep 9, 2021
2825cf2
Remove beneficial owners from translations ass it is no longer used
mountiny Sep 9, 2021
4056c40
Update the copy of the subheader
mountiny Sep 9, 2021
f9f72c3
Remove the bold text
mountiny Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,9 +552,8 @@ export default {
forNextSteps: ' for next steps to finish setting up your bank account.',
},
beneficialOwnersStep: {
beneficialOwners: 'Beneficial owners',
additionalInformation: 'Additional information',
checkAllThatApply: '(check all that apply, otherwise leave blank)',
checkAllThatApply: 'Check all that apply, otherwise leave blank.',
iOwnMoreThan25Percent: 'I own more than 25% of ',
someoneOwnsMoreThan25Percent: 'Somebody else owns more than 25% of ',
additionalOwner: 'Additional beneficial owner',
Expand Down
3 changes: 1 addition & 2 deletions src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,8 @@ export default {
forNextSteps: ' para conocer los próximos pasos para terminar de configurar su cuenta bancaria.',
},
beneficialOwnersStep: {
beneficialOwners: 'Beneficiario efectivo',
additionalInformation: 'Información adicional',
checkAllThatApply: '(marca todos los que apliquen, en caso de que ninguno aplique dejar en blanco)',
checkAllThatApply: 'Marca todos los que apliquen, en caso de que ninguno aplique dejar en blanco.',
iOwnMoreThan25Percent: 'Soy dueño de mas de 25% de ',
someoneOwnsMoreThan25Percent: 'Otra persona es dueña de mas de 25% de ',
additionalOwner: 'Beneficiario efectivo adicional',
Expand Down
5 changes: 1 addition & 4 deletions src/pages/ReimbursementAccount/BeneficialOwnersStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,13 @@ class BeneficialOwnersStep extends React.Component {
return (
<>
<HeaderWithCloseButton
title={this.props.translate('beneficialOwnersStep.beneficialOwners')}
title={this.props.translate('beneficialOwnersStep.additionalInformation')}
onCloseButtonPress={Navigation.dismissModal}
onBackButtonPress={() => goToWithdrawalAccountSetupStep(CONST.BANK_ACCOUNT.STEP.REQUESTOR)}
shouldShowBackButton
/>
<ScrollView style={[styles.flex1, styles.w100, styles.ph5]}>
<Text style={[styles.mb5]}>
<Text style={[styles.textStrong]}>
{`${this.props.translate('beneficialOwnersStep.additionalInformation')}: `}
</Text>
<Text>{this.props.translate('beneficialOwnersStep.checkAllThatApply')}</Text>
</Text>
<CheckboxWithLabel
Expand Down