Skip to content

Revert "Feature: add loading indicator when ReconnectApp is running"#52047

Closed
Julesssss wants to merge 1 commit into
mainfrom
revert-48772-feature/46611
Closed

Revert "Feature: add loading indicator when ReconnectApp is running"#52047
Julesssss wants to merge 1 commit into
mainfrom
revert-48772-feature/46611

Conversation

@Julesssss

Copy link
Copy Markdown
Contributor

Reverts #48772 as deploying this to staging will break HybridApp and prevent testing.

@Julesssss Julesssss self-assigned this Nov 5, 2024
@Julesssss Julesssss requested review from a team as code owners November 5, 2024 14:58
@melvin-bot melvin-bot Bot requested review from dangrous and removed request for a team November 5, 2024 14:59
@melvin-bot

melvin-bot Bot commented Nov 5, 2024

Copy link
Copy Markdown

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52047/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52047/NewExpensify.dmg https://52047.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@Julesssss

Copy link
Copy Markdown
Contributor Author

No need anymore, this is being handled here.

@Julesssss Julesssss closed this Nov 5, 2024
@Julesssss Julesssss deleted the revert-48772-feature/46611 branch November 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant