Fix: Offline indicator is below the text in Auto-sync page#52723
Merged
Conversation
Contributor
|
@twilight2294 Can you please merge with the latest main? |
Contributor
|
Thanks @twilight2294 for the merge. Will review today. |
Contributor
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari52723-web-safari-001.mp4MacOS: Desktop52723-desktop-001.mp4iOS: Native52723-ios-native-001.mp4iOS: mWeb Safari52723-mweb-safari-001.mp4Android: Native52723-android-native-001.mp4Android: mWeb Chrome52723-mweb-chrome-001.mp4 |
rojiphil
approved these changes
Nov 27, 2024
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
@yuwenmemon Changes LGTM and tests well too.
Over to you for review. Thanks.
yuwenmemon
approved these changes
Dec 2, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 tasks
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.70-0 🚀
|
Contributor
|
Performance regression is a false positive and can be ignored as of |
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.70-9 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #52626
PROPOSAL: N/A
Tests
Precondition:
verify that: Offline indicator is at the bottom of the page
Offline tests
Precondition:
verify that: Offline indicator is at the bottom of the page
QA Steps
Precondition:
verify that: Offline indicator is at the bottom of the page
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop