[NO QA] Update build.gradle for hybrid app adhoc builds by jnowakow · Pull Request #53214 · Expensify/App

jnowakow · 2024-11-27T14:00:37Z

Explanation of Change

This change ensures adhoc build doesn't crash.

Fixed Issues

$ #51636
PROPOSAL: N/A

Tests

We will test manually

Offline tests

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

melvin-bot · 2024-11-27T14:00:42Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-11-28T04:40:20Z

@Julesssss @jnowakow This seems to be an Adhoc task. Is there anything I need to do?

jnowakow · 2024-11-28T07:15:26Z

I assume you don't have to do anything but I'm not sure to be honest

Julesssss · 2024-11-28T10:39:09Z

Yeah, I unassigned you. Thanks for commenting!

Julesssss · 2024-11-28T10:41:47Z

+            "android.injected.signing.store.file" => './upload-key.keystore',
+            "android.injected.signing.store.password" => ENV["ANDROID_UPLOAD_KEYSTORE_PASSWORD"],
+            "android.injected.signing.key.alias" => ENV["ANDROID_UPLOAD_KEYSTORE_ALIAS"],
+            "android.injected.signing.key.password" => ENV["ANDROID_UPLOAD_KEY_PASSWORD"],


Do we use the same signing key for HybridApp builds on App? I thought they might be different

I believe so because I copied part of the workflow from deploy.yml where we use that signing key:

Julesssss · 2024-11-28T10:50:29Z

+  # iOS:
+  #   name: Build and deploy iOS for testing
+  #   needs: [validateActor, getBranchRef]
+  #   if: ${{ fromJSON(needs.validateActor.outputs.READY_TO_BUILD) }}
+  #   env:
+  #     DEVELOPER_DIR: /Applications/Xcode_15.2.0.app/Contents/Developer
+  #   runs-on: macos-13-xlarge
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@v4
+  #       with:
+  #         ref: ${{ github.event.pull_request.head.sha || needs.getBranchRef.outputs.REF }}


Can we leave this out of the initial PR please

Julesssss

Running an initial test build as the Android Mobile-Expensify PR has been merged

Julesssss · 2024-12-02T10:41:05Z

I had to dupe with an internal branch to run the action.

jnowakow · 2024-12-02T10:46:25Z

@Julesssss I'm afraid that you can't test this workflow without merging it to main :( You ran old workflow. I've created new one called Build and deploy hybird apps for testing and I think that GH allows you to run only workflows that are on the main branch

Julesssss · 2024-12-02T10:54:51Z

@jnowakow ah, I must misunderstand. I ran the workflow that exists on the spefic branch jules-testHybridBuild (clone). Don't we just need to trigger testBuildHybrid.yml as part of your changes? Or is this because your workflows on trigger other workflows on main?

jnowakow · 2024-12-02T11:10:00Z

Yeah, we have to trigger workflow defined in testBuildHybrid.yml but I'm not sure if you can trigger it manually if it's only on this branch. You ran Build and deploy apps for testing workflow which is defined in testBuild.yml

Please check if you can see Build and deploy hybird apps for testing workflow

Julesssss · 2024-12-02T11:25:30Z

Ah no I can't see that one. I suppose it makes sense we're only seeing the workflows that exist on main.

So we would merge, then test the workflow manually for now?

jnowakow · 2024-12-02T11:33:03Z

Yeah, I think that it's the easiest way to test this out. Not sure if there is option to run this from here :(
It adds new workflow so nothing that was working before shouldn't break. We can revert if it doesn't work

Julesssss · 2024-12-02T11:35:48Z

Sounds good to me. Are these Action errors fixable before we do that?

missing input "DESKTOP" which is required by action "Mark Pull Requests as Deployed" defined at "./.github/actions/javascript/postTestBuildComment". all required inputs are "ANDROID", "DESKTOP", "IOS", "PR_NUMBER", "WEB"

jnowakow · 2024-12-02T13:03:14Z

Yeah, sorry, I missed one element. Should be fixed right now

Julesssss · 2024-12-02T13:31:46Z

-        required: true
+        required: false
    GITHUB_TOKEN:
        description: "Github token for authentication"
        default: "${{ github.token }}"
    ANDROID:
        description: "Android job result ('success', 'failure', 'cancelled', or 'skipped')"
-        required: true
+        required: false
    DESKTOP:
        description: "Desktop job result ('success', 'failure', 'cancelled', or 'skipped')"
-        required: true
+        required: false
    IOS:
        description: "iOS job result ('success', 'failure', 'cancelled', or 'skipped')"
-        required: true
+        required: false
    WEB:
        description: "Web job result ('success', 'failure', 'cancelled', or 'skipped')"
-        required: true
+        required: false


Won't this change will affect our existing builds?

I don't think so. This action is only used in testBuild.yml where all four platforms are passed. I modified the script so it checks if given platform is included so there shouldn't be any problems

Okay thanks. Once last question: If we are now checking for the script elsewhere, why was this change necessary? It seems to me that requiring at the action level is a bit safer than a check deeper within a script.

action.yml is file with metadata and specifies input. I modified the script so not all platforms are required. If input for given platform is not specified there will be N/A in table with statuses and links.

It's probably not ideal but I wanted to reuse already written action

Ah okay. So We are reusing action logic, but need to account for platforms not being provided. It sounds reasonable.

Julesssss

Testing out this new HybridApp Android build flow after merge.

Julesssss · 2024-12-02T15:12:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-12-02T15:22:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-02T22:02:51Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.70-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-03T10:38:59Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2024-12-03T11:14:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	N/A
The QR code can't be generated, because the Android build failed	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

github-actions · 2024-12-04T01:12:05Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.70-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Update build.gradle for hybrid app adhoc builds

7aa7aba

jnowakow requested a review from a team as a code owner November 27, 2024 14:00

melvin-bot Bot requested review from dominictb and removed request for a team November 27, 2024 14:00

jnowakow marked this pull request as draft November 27, 2024 14:30

Add new lane and new workflow

3ed499f

jnowakow mentioned this pull request Nov 28, 2024

Enable HybridApp test builds in App repo #51636

Closed

Julesssss removed the request for review from dominictb November 28, 2024 10:38

Julesssss reviewed Nov 28, 2024

View reviewed changes

jnowakow added 5 commits November 28, 2024 13:26

remove commented ios workflow part

c6bdf0b

Fix workflow

bc599be

Make platforms optional for publishing links

7ad51a8

Action linter

d7a73ca

Fix linter again

17d78c7

Julesssss added the Ready To Build label Dec 2, 2024

Julesssss reviewed Dec 2, 2024

View reviewed changes

jnowakow marked this pull request as ready for review December 2, 2024 10:44

Fix linter

b15d24c

Julesssss reviewed Dec 2, 2024

View reviewed changes

Julesssss approved these changes Dec 2, 2024

View reviewed changes

Julesssss changed the title ~~Update build.gradle for hybrid app adhoc builds~~ [NO QA] Update build.gradle for hybrid app adhoc builds Dec 2, 2024

Julesssss merged commit 8498e71 into Expensify:main Dec 2, 2024

Julesssss mentioned this pull request Dec 2, 2024

[NO QA] Testing HybridApp builds #53372

Merged

50 tasks

github-actions Bot mentioned this pull request Dec 2, 2024

Deploy Checklist: New Expensify 2024-12-02 #53406

Closed

48 tasks

Conversation

jnowakow commented Nov 27, 2024 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 27, 2024

Uh oh!

dominictb commented Nov 28, 2024

Uh oh!

jnowakow commented Nov 28, 2024

Uh oh!

Julesssss commented Nov 28, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Dec 2, 2024

Uh oh!

jnowakow commented Dec 2, 2024

Uh oh!

Julesssss commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnowakow commented Dec 2, 2024

Uh oh!

Julesssss commented Dec 2, 2024

Uh oh!

jnowakow commented Dec 2, 2024

Uh oh!

Julesssss commented Dec 2, 2024

Uh oh!

jnowakow commented Dec 2, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Dec 2, 2024

Uh oh!

github-actions Bot commented Dec 2, 2024

Uh oh!

github-actions Bot commented Dec 3, 2024

Uh oh!

github-actions Bot commented Dec 3, 2024

Uh oh!

github-actions Bot commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

jnowakow commented Nov 27, 2024 •

edited by Julesssss

Loading

Julesssss commented Dec 2, 2024 •

edited

Loading

Julesssss commented Dec 2, 2024 •

edited

Loading