-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Migrated user welcome modal #53225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
puneetlath
merged 29 commits into
Expensify:main
from
ishpaul777:migrated-user-welcome-modal
Dec 8, 2024
Merged
Migrated user welcome modal #53225
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5e64eaf
add the migrated modal
ishpaul777 204bcc2
Merge branch 'main' into migrated-user-welcome-modal
ishpaul777 78ecc38
migrate-modal
ishpaul777 f2fc885
refactor: update animation handling and improve MenuItem rendering
ishpaul777 c9a2d9a
feat: add contentContainerStyles prop to FeatureTrainingModal and upd…
ishpaul777 8b41e2e
Merge branch 'Expensify:main' into migrated-user-welcome-modal
ishpaul777 01323e8
Merge branch 'Expensify:main' into migrated-user-welcome-modal
ishpaul777 349253c
Add modalInnerContainerStyle prop to FeatureTrainingModal and update …
ishpaul777 a1f2ea1
Add animationInnerContainerStyle and animationOuterContainerStyle pro…
ishpaul777 2d54669
Merge branch 'Expensify:main' into migrated-user-welcome-modal
ishpaul777 4e937b6
resolve conflict
ishpaul777 b9cac98
resolve conflict after merge
ishpaul777 0ef0a17
resolve conflict after merge
ishpaul777 3708788
fix animations
ishpaul777 839f0b8
refactor MigratedUserWelcomeModal: remove unused responsive layout ho…
ishpaul777 2c6a5be
refactor FeatureTrainingModal: remove shouldRenderAnimation prop and …
ishpaul777 4860fca
put this behind beta
ishpaul777 13dba9a
refactor dismissProductTrainingElement
ishpaul777 835e8d1
fix typo
ishpaul777 a1eaba1
Update src/ONYXKEYS.ts
ishpaul777 63e04a7
Update src/libs/actions/Welcome/index.ts
ishpaul777 d5a67d5
Update src/libs/actions/Welcome/index.ts
ishpaul777 5db4193
Rename nudgeMigrationWelcomeModal to migratedUserWelcomeModal
ishpaul777 69e5559
Add CONST migratedUserWelcomeModal
ishpaul777 041deab
Add DismissProductTrainingParams type and update API parameters
ishpaul777 0b3ef8d
add padding to modal container
ishpaul777 2e67ea4
Refactor MenuItem and MigratedUserWelcomeModal components to use Icon…
ishpaul777 ba2f51b
translations fix
ishpaul777 4575829
Fix typo in CONST
ishpaul777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
assets/images/simple-illustrations/simple-illustration__flash.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 54 additions & 0 deletions
54
assets/images/simple-illustrations/simple-illustration__mobileapp.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishpaul777 Could you kindly explain the reasoning behind wrapping this logic inside InteractionManager.runAfterInteractions? I’m trying to better understand its purpose in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added so that the modal can be close with sliding down animation on mobile smoothly and then it navigates