Skip to content

Fix: SMS delivery failure sign in flow in homepage #53297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 2 commits into from
Nov 30, 2024
Merged

Fix: SMS delivery failure sign in flow in homepage #53297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26261cb
Fix: SMS delivery failure sign in flow in homepage
nyomanjyotisa Nov 29, 2024
15182a8
minor fix
nyomanjyotisa Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/signin/SMSDeliveryFailurePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function SMSDeliveryFailurePage() {
return Str.isSMSLogin(credentials.login) ? Str.removeSMSDomain(credentials.login) : credentials.login;
}, [credentials?.login]);

const SMSDeliveryFailureMessage = account?.SMSDeliveryFailureStatus?.message;
const SMSDeliveryFailureMessage = account?.smsDeliveryFailureStatus?.message;

useEffect(() => {
if (!isKeyboardShown) {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/signin/SignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ function getRenderOptions({
const isSAMLEnabled = !!account?.isSAMLEnabled;
const isSAMLRequired = !!account?.isSAMLRequired;
const hasEmailDeliveryFailure = !!account?.hasEmailDeliveryFailure;
const hasSMSDeliveryFailure = !!account?.SMSDeliveryFailureStatus?.hasSMSDeliveryFailure;
const hasSMSDeliveryFailure = !!account?.smsDeliveryFailureStatus?.hasSMSDeliveryFailure;

// True, if the user has SAML required, and we haven't yet initiated SAML for their account
const shouldInitiateSAMLLogin = hasAccount && hasLogin && isSAMLRequired && !hasInitiatedSAMLLogin && !!account.isLoading;
Expand Down
2 changes: 1 addition & 1 deletion src/types/onyx/Account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ type Account = {
delegatedAccess?: DelegatedAccess;

/** Indicates SMS delivery failure status and associated information */
SMSDeliveryFailureStatus?: SMSDeliveryFailureStatus;
smsDeliveryFailureStatus?: SMSDeliveryFailureStatus;
};

export default Account;
Expand Down