Dont toggle create menu if we already have a free policy#5394
Merged
Conversation
Contributor
Author
|
I don't think this solution should have to change at all in order for this to work |
Contributor
Author
|
Scratch that it does need to be updated... one sec... |
marcaaron
changed the title
cead22
approved these changes
Sep 22, 2021
iwiznia
approved these changes
Sep 22, 2021
TomatoToaster
approved these changes
Sep 22, 2021
Contributor
|
|
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 23, 2021
…DotRedirect Dont toggle create menu if we already have a free policy (cherry picked from commit 8987627)
This was referenced Sep 23, 2021
Contributor
|
🚀 Cherry-picked to staging by @marcaaron in version: 1.1.1-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
27 tasks
Contributor
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.1.1-9 🚀
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #5392
Tests / QA Steps
Test that global create does not open when creating a policy view OldDot
Test that global create does not open when navigating to a free policy
Test that logging into NewDot with a new account does open the menu
Test that logging into NewDot with a new account does not open the menu
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android