Skip to content

Do not save user password in reimbursementAccountDraft#5429

Merged
Beamanator merged 1 commit into
mainfrom
cmartins-doNotSavePassword
Sep 23, 2021
Merged

Do not save user password in reimbursementAccountDraft#5429
Beamanator merged 1 commit into
mainfrom
cmartins-doNotSavePassword

Conversation

@luacmartins

@luacmartins luacmartins commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Details

We should not save user passwords in reimbursementAccountDraft

Fixed Issues

$ #5428

Tests

  1. Login to an account with a Workspace and without Expensify Cards.
  2. Navigate to Settings > Select Workspace > Expensify Card > Get started to start the VBA flow.
  3. After entering your password in the Company step, open the console and click on the Application tab.
  4. Notice that the password is not saved in the reimbursementAccountDraft key.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins self-assigned this Sep 22, 2021
@luacmartins luacmartins requested a review from a team September 22, 2021 22:16
@luacmartins luacmartins marked this pull request as ready for review September 22, 2021 22:16
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team September 22, 2021 22:16

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! #LGTM

Note: I think you should include screenshots / videos 👍

@Beamanator Beamanator merged commit bc8507c into main Sep 23, 2021
@Beamanator Beamanator deleted the cmartins-doNotSavePassword branch September 23, 2021 10:42
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants