Skip to content

Capitalize Save & Continue#5432

Merged
roryabraham merged 1 commit into
mainfrom
joe-save-continue
Sep 23, 2021
Merged

Capitalize Save & Continue#5432
roryabraham merged 1 commit into
mainfrom
joe-save-continue

Conversation

@Jag96

@Jag96 Jag96 commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Details

Keeps button text consistent

Fixed Issues

Fixes #5421

Tests/QA

Note from Ionatan: this is no QA since we reverted this change

  1. Launch the app
  2. Log in with expensifail account
  3. Click on deeplink https://staging.new.expensify.com/bank-account/contract
  4. Verify "Save and continue" button

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

@Jag96 Jag96 requested a review from roryabraham September 23, 2021 00:05
@Jag96 Jag96 self-assigned this Sep 23, 2021
@Jag96 Jag96 requested a review from a team as a code owner September 23, 2021 00:05
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team September 23, 2021 00:06

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when a plan comes together

@roryabraham roryabraham merged commit 52065e2 into main Sep 23, 2021
@roryabraham roryabraham deleted the joe-save-continue branch September 23, 2021 01:41
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@iwiznia

iwiznia commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

This change is wrong, we should use normal capitalization in all our copy. So, only capitalizing first words, names or acronyms. This is defined here. Sending a revert of the PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VBA - "c " is not capitalized in Save & Continue button

4 participants