Skip to content

[N6 polish] Capitalize Expensify Card in the banner#5444

Merged
chiragsalian merged 1 commit into
mainfrom
vit-n6polishCardCopy
Sep 23, 2021
Merged

[N6 polish] Capitalize Expensify Card in the banner#5444
chiragsalian merged 1 commit into
mainfrom
vit-n6polishCardCopy

Conversation

@mountiny

@mountiny mountiny commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Details

Small copy change. Change Expensify card to Expensify Card.

Fixed Issues

$ #5411

Tests

Go to the workspace and make sure the copy on the banner looks like this:
image

QA Steps

Same as Tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from a team September 23, 2021 12:40
@mountiny mountiny self-assigned this Sep 23, 2021
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 23, 2021 12:40
@mountiny mountiny changed the title Capitalize Expensify Card in the banner [N6 polish] Capitalize Expensify Card in the banner Sep 23, 2021

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 16d8599 into main Sep 23, 2021
@chiragsalian chiragsalian deleted the vit-n6polishCardCopy branch September 23, 2021 19:28
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants