-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: focused background is not updated #54457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import {fireEvent, render, screen} from '@testing-library/react-native'; | ||
| import BaseSelectionList from '@components/SelectionList/BaseSelectionList'; | ||
| import RadioListItem from '@components/SelectionList/RadioListItem'; | ||
| import type {ListItem} from '@components/SelectionList/types'; | ||
| import type Navigation from '@libs/Navigation/Navigation'; | ||
| import CONST from '@src/CONST'; | ||
|
|
||
| type BaseSelectionListSections<TItem extends ListItem> = { | ||
| sections: TItem[]; | ||
| }; | ||
|
|
||
| const mockSections = Array.from({length: 10}, (_, index) => ({ | ||
| text: `Item ${index}`, | ||
| keyForList: `${index}`, | ||
| isSelected: index === 1, | ||
| })); | ||
|
|
||
| jest.mock('@react-navigation/native', () => { | ||
| const actualNav = jest.requireActual<typeof Navigation>('@react-navigation/native'); | ||
| return { | ||
| ...actualNav, | ||
| useIsFocused: jest.fn(), | ||
| useFocusEffect: jest.fn(), | ||
| }; | ||
| }); | ||
|
|
||
| describe('BaseSelectionList', () => { | ||
| const onSelectRowMock = jest.fn(); | ||
|
|
||
| function BaseListItemRenderer<TItem extends ListItem>(props: BaseSelectionListSections<TItem>) { | ||
| const {sections} = props; | ||
| const focusedKey = sections.find((item) => item.isSelected)?.keyForList; | ||
| return ( | ||
| <BaseSelectionList | ||
| sections={[{data: sections}]} | ||
| ListItem={RadioListItem} | ||
| onSelectRow={onSelectRowMock} | ||
| shouldSingleExecuteRowSelect | ||
| initiallyFocusedOptionKey={focusedKey} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| it('should handle item press correctly', () => { | ||
| render(<BaseListItemRenderer sections={mockSections} />); | ||
| fireEvent.press(screen.getByTestId(`${CONST.BASE_LIST_ITEM_TEST_ID}1`)); | ||
| expect(onSelectRowMock).toHaveBeenCalledWith({ | ||
| ...mockSections.at(1), | ||
| shouldAnimateInHighlight: false, | ||
| }); | ||
| }); | ||
|
|
||
| it('should update focused item when sections are updated from BE', () => { | ||
| const updatedMockSections = mockSections.map((section) => ({ | ||
| ...section, | ||
| isSelected: section.keyForList === '2', | ||
| })); | ||
| const {rerender} = render(<BaseListItemRenderer sections={mockSections} />); | ||
| expect(screen.getByTestId(`${CONST.BASE_LIST_ITEM_TEST_ID}1`)).toHaveAccessibilityState({ | ||
| selected: true, | ||
| }); | ||
| rerender(<BaseListItemRenderer sections={updatedMockSections} />); | ||
| expect(screen.getByTestId(`${CONST.BASE_LIST_ITEM_TEST_ID}2`)).toHaveAccessibilityState({ | ||
| selected: true, | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from here #58017, when the search text contains letters from the currently selected item, and the selected item is
initiallyFocusedOptionKey, thesetFocusedIndexwill call two times to focus index 1 then focusinitiallyFocusedOptionKeyindex. We fixed it by add new condition to the early return logic to return early when the user is searching and keep callingsetFocusedIndexonly for background updates