Skip to content

Fix: line height issues of button#5464

Merged
chiragsalian merged 1 commit into
Expensify:mainfrom
parasharrajat:ui-fixes
Sep 23, 2021
Merged

Fix: line height issues of button#5464
chiragsalian merged 1 commit into
Expensify:mainfrom
parasharrajat:ui-fixes

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Sep 23, 2021

Copy link
Copy Markdown
Member

Details

  1. Allow the Text component to override the default line-height.
  2. Removed the Line-height from Button Text to vertically center any size button.

Fixed Issues

$ #5333

Tests | QA Steps

  1. Create a workspace.
  2. Enter Expensify Card tab.
  3. See the "Get Started" and "Help" buttons are properly aligned on the vertical axis.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-09-24 00:24:09

iOS

Android

Screenshot 2021-09-24 00:12:25

@parasharrajat parasharrajat requested a review from a team as a code owner September 23, 2021 18:54
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 23, 2021 18:55

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 14238c2 into Expensify:main Sep 23, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico

Copy link
Copy Markdown

@parasharrajat @chiragsalian is it ok if we test this with the "Manage Cards" button?

@parasharrajat

Copy link
Copy Markdown
Member Author

Yeah @isagoico with any button in the app.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants