fix: border around workspace not matching hovered background by nkdengineer · Pull Request #54860 · Expensify/App

nkdengineer · 2025-01-07T09:01:31Z

Explanation of Change

Fixed Issues

$ #54387
PROPOSAL: #54387 (comment)

Tests

Navigate to a workspace chat
Hover the avatar
Observe the avatar
Verify that: Border around workspace avatar matching hovered background in chat log
Create an expense
Go to expense chat
Click header of this chat to return chat report
Verify that: When active border around workspace avatar matching hovered background in chat log

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios-mweb.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-08T15:16:13Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-01-09T10:19:28Z

@nkdengineer Can you include all the cases mentioned in the issue?

nkdengineer · 2025-01-13T03:15:19Z

I will update soon

nkdengineer · 2025-01-13T08:34:56Z

@shubham1206agra i updated active case

shubham1206agra · 2025-01-13T08:36:56Z

@nkdengineer How about the reply counter avatar shown in #54387 (comment)

nkdengineer · 2025-01-14T18:50:40Z

@shubham1206agra i updated

shawnborton · 2025-01-15T08:11:36Z

That screenshot looks like we're still using an incorrect border color around the small workspace avatar when the row is active:

shawnborton · 2025-01-15T08:12:14Z

From the screenshot in your original post above, I also see an incorrect border color:

nkdengineer · 2025-01-16T10:24:55Z

@shawnborton @shubham1206agra i updated

shawnborton · 2025-01-16T10:43:09Z

Much better, thanks!

shubham1206agra · 2025-01-16T17:06:58Z

@nkdengineer I am seeing wrong color here

shubham1206agra · 2025-01-16T17:09:21Z

See here too

Just highlight the message using link and then hover over it.

nkdengineer · 2025-01-21T07:26:55Z

@shubham1206agra I am having problem here is when isActive is true then isHover is also true even though we are not hovering. Will try to investigate and give an update soon.

nkdengineer · 2025-01-24T08:15:20Z

@shubham1206agra sorry for the delay, i updated, please check again

shubham1206agra · 2025-01-24T13:27:38Z

@nkdengineer I can still see the bug

nkdengineer · 2025-01-25T11:16:42Z

406657177-b7727cd6-b2f0-43a1-b16a-75af903fc064.mov

@shubham1206agra could you please share the steps? i can't reproduce this bug.

shubham1206agra · 2025-01-25T14:42:29Z

406657177-b7727cd6-b2f0-43a1-b16a-75af903fc064.mov

@shubham1206agra could you please share the steps? i can't reproduce this bug.

Click on thread to go into the thread
Click the header link to go back to same chat
Right-click on the comment you clicked in step 1
Remove your mouse from the comment.

nkdengineer · 2025-01-25T20:37:50Z

Click on thread to go into the thread
Click the header link to go back to same chat
Right-click on the comment you clicked in step 1
Remove your mouse from the comment.

it looks like the steps in my video
could you please pull the code and recheck it?

shubham1206agra · 2025-01-27T06:12:49Z

Click on thread to go into the thread
Click the header link to go back to same chat
Right-click on the comment you clicked in step 1
Remove your mouse from the comment.

it looks like the steps in my video could you please pull the code and recheck it?

You have not done the right-click on the comment.

mallenexpensify · 2025-01-28T20:03:39Z

@nkdengineer can you please prioritize getting this PR merged? It's been a few weeks. Thx

nkdengineer · 2025-01-29T15:50:39Z

I'm checking now

nkdengineer · 2025-01-29T18:56:10Z

@shubham1206agra i fixed, please check again

shubham1206agra · 2025-01-30T06:57:43Z

Screen.Recording.2025-01-30.at.12.27.10.PM.mov

This is still not fixed

shubham1206agra · 2025-01-30T18:02:39Z

@nkdengineer Bump on this

nkdengineer · 2025-02-01T16:50:35Z

I'm checking now

nkdengineer · 2025-02-01T17:20:05Z

Screen.Recording.2025-02-02.at.00.19.13.mov

@shubham1206agra sorry for the delay, I updated

shubham1206agra · 2025-02-02T19:33:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

shubham1206agra · 2025-02-05T16:48:33Z

@nkdengineer Merge main to fix the lint here

a commit message to explain why this merge is necessary, topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

OSBotify · 2025-02-06T17:53:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:00:49Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-11T02:12:08Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: border around workspace not matching hovered background

f250dcf

nkdengineer marked this pull request as ready for review January 8, 2025 15:16

nkdengineer requested a review from a team as a code owner January 8, 2025 15:16

melvin-bot Bot requested review from shubham1206agra and removed request for a team January 8, 2025 15:16

nkdengineer added 3 commits January 13, 2025 14:52

Merge branch 'main' into fix/54387

99ad8e9

Merge branch 'main' into fix/54387

c7e3b3e

Add active case

8542fd5

fix reply border when active

cacb979

nkdengineer requested a review from a team as a code owner January 14, 2025 18:49

nkdengineer added 2 commits January 16, 2025 16:41

Merge branch 'main' into fix/54387

8fcb5ba

fix border style

24ec202

nkdengineer added 2 commits January 24, 2025 14:26

Merge branch 'main' into fix/54387

ecd2d72

fix background color when hover

8e0e081

Merge branch 'main' into fix/54387

dc2343c

nkdengineer added 2 commits January 29, 2025 22:51

Merge branch 'main' into fix/54387

81827b0

fix bug

d4dfd05

nkdengineer added 2 commits February 2, 2025 00:07

Merge branch 'main' into fix/54387

ba9e946

fix background hover

02c54c3

shubham1206agra approved these changes Feb 2, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia February 2, 2025 19:33

git pushMerge branch 'main' into fix/54387 # Please enter

3718970

a commit message to explain why this merge is necessary, topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

grgia approved these changes Feb 6, 2025

View reviewed changes

grgia merged commit 93ef0ba into Expensify:main Feb 6, 2025

github-actions Bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

melvin-bot Bot mentioned this pull request Feb 11, 2025

[Due for payment 2025-02-18] [$250] Border around workspace not matching hovered background in chat log #54387

Closed

8 tasks

Conversation

nkdengineer commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 8, 2025

Uh oh!

shubham1206agra commented Jan 9, 2025

Uh oh!

nkdengineer commented Jan 13, 2025

Uh oh!

nkdengineer commented Jan 13, 2025

Uh oh!

shubham1206agra commented Jan 13, 2025

Uh oh!

nkdengineer commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Jan 15, 2025

Uh oh!

shawnborton commented Jan 15, 2025

Uh oh!

nkdengineer commented Jan 16, 2025

Uh oh!

shawnborton commented Jan 16, 2025

Uh oh!

shubham1206agra commented Jan 16, 2025

Uh oh!

shubham1206agra commented Jan 16, 2025

Uh oh!

nkdengineer commented Jan 21, 2025

Uh oh!

nkdengineer commented Jan 24, 2025

Uh oh!

shubham1206agra commented Jan 24, 2025

Uh oh!

nkdengineer commented Jan 25, 2025

Uh oh!

shubham1206agra commented Jan 25, 2025

Uh oh!

nkdengineer commented Jan 25, 2025

Uh oh!

shubham1206agra commented Jan 27, 2025

Uh oh!

mallenexpensify commented Jan 28, 2025

Uh oh!

nkdengineer commented Jan 29, 2025

Uh oh!

nkdengineer commented Jan 29, 2025

Uh oh!

shubham1206agra commented Jan 30, 2025

Uh oh!

shubham1206agra commented Jan 30, 2025

Uh oh!

nkdengineer commented Feb 1, 2025

Uh oh!

nkdengineer commented Feb 1, 2025

Uh oh!

shubham1206agra commented Feb 2, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Feb 5, 2025

Uh oh!

OSBotify commented Feb 6, 2025

Uh oh!

github-actions Bot commented Feb 6, 2025

Uh oh!

github-actions Bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

nkdengineer commented Jan 7, 2025 •

edited

Loading

nkdengineer commented Jan 14, 2025 •

edited

Loading