Skip to content

use phone-pad #5513

Merged
Jag96 merged 1 commit into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/vba-flow-inputs
Sep 27, 2021
Merged

use phone-pad #5513
Jag96 merged 1 commit into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/vba-flow-inputs

Conversation

@thesahindia

Copy link
Copy Markdown
Member

Details

Proposal: #5321 (comment)
Approval: #5321 (comment)

Fixed Issues

$ #5321

Tests

QA Steps

  1. Create workspace
  2. Go through VBA flow with test credentials
  3. Below inputs will have number pad for ios & android

Company Information Step

  • Zip Code

Personal Information Step

  • SSN
  • Zip Code

Can't test Personal Information Step & for IOS

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

test

@thesahindia thesahindia requested a review from a team as a code owner September 24, 2021 19:55
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team September 24, 2021 19:55
@Jag96 Jag96 added n6-hold and removed n6-hold labels Sep 24, 2021

@Jag96 Jag96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed no regressions on web/desktop and it works on ios/android

@Jag96 Jag96 merged commit b37e87e into Expensify:main Sep 27, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants