Skip to content

Remove password requirement for setting up withdrawal account #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jag96 merged 3 commits into from
Sep 30, 2021
Merged

Remove password requirement for setting up withdrawal account #5545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
632a062
Remove password field from CompanyStep VBA flow
Jag96 Sep 27, 2021
1512c5e
remove password requirement
Jag96 Sep 27, 2021
6417bb5
remove unused translation
Jag96 Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default {
isRequiredField: 'is a required field',
whatThis: 'What\'s this?',
iAcceptThe: 'I accept the ',
passwordCannotBeBlank: 'Password cannot be blank',
remove: 'Remove',
admin: 'Admin',
dateFormat: 'YYYY-MM-DD',
Expand Down
1 change: 0 additions & 1 deletion src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default {
isRequiredField: 'es un campo obligatorio',
whatThis: '¿Qué es esto?',
iAcceptThe: 'Acepto los ',
passwordCannotBeBlank: 'La contraseña no puede estar vacía',
remove: 'Eliminar',
admin: 'Administrador',
dateFormat: 'AAAA-MM-DD',
Expand Down
2 changes: 1 addition & 1 deletion src/libs/API.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ function BankAccount_SetupWithdrawal(parameters) {

requireParameters(['currentStep'], parameters, commandName);
return Network.post(
commandName, {additionalData: JSON.stringify(additionalData), password: parameters.password},
commandName, {additionalData: JSON.stringify(additionalData)},
CONST.NETWORK.METHOD.POST,
true,
);
Expand Down
20 changes: 0 additions & 20 deletions src/pages/ReimbursementAccount/CompanyStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class CompanyStep extends React.Component {
incorporationDate: ReimbursementAccountUtils.getDefaultStateForField(props, 'incorporationDate'),
incorporationState: ReimbursementAccountUtils.getDefaultStateForField(props, 'incorporationState'),
hasNoConnectionToCannabis: ReimbursementAccountUtils.getDefaultStateForField(props, 'hasNoConnectionToCannabis', false),
password: '',
};

// These fields need to be filled out in order to submit the form
Expand All @@ -73,7 +72,6 @@ class CompanyStep extends React.Component {
'incorporationDate',
'incorporationState',
'incorporationType',
'password',
'companyPhone',
'hasNoConnectionToCannabis',
];
Expand All @@ -89,7 +87,6 @@ class CompanyStep extends React.Component {
companyTaxID: 'bankAccount.error.taxID',
incorporationDate: 'bankAccount.error.incorporationDate',
incorporationType: 'bankAccount.error.companyType',
password: 'common.passwordCannotBeBlank',
Comment thread
Jag96 marked this conversation as resolved.
hasNoConnectionToCannabis: 'bankAccount.error.restrictedBusiness',
};

Expand Down Expand Up @@ -274,23 +271,6 @@ class CompanyStep extends React.Component {
/>
</View>
</View>
<ExpensiTextInput
label={`Expensify ${this.props.translate('common.password')}`}
containerStyles={[styles.mt4]}
secureTextEntry
textContentType="password"
onChangeText={(value) => {
this.setState({password: value});
this.clearError('password');
}}
value={this.state.password}
onSubmitEditing={this.submit}
errorText={this.getErrorText('password')}

// Use new-password to prevent an autoComplete bug https://github.com/Expensify/Expensify/issues/173177
// eslint-disable-next-line react/jsx-props-no-multi-spaces
autoCompleteType="new-password"
/>
<CheckboxWithLabel
isChecked={this.state.hasNoConnectionToCannabis}
onPress={() => {
Expand Down