Fix submit button when there is only non-reimbursable expenses by shubham1206agra · Pull Request #55610 · Expensify/App

shubham1206agra · 2025-01-22T15:21:40Z

Explanation of Change

Fixed Issues

$ #55086
PROPOSAL: #55086 (comment)

Tests

Go to NewDot, create a workspace.
Go to Settings > Workspaces > [Click the workspace] > Enable Workflows
Go to Workflows > Enable delayed submission and set it to Manually > Enable approvals.
Go to Members > invite a member to the workspace
[Member] Click the green plus icon > Create expense > choose the workspace > confirm
Observe the Submit button on the report preview, in the report header, and on the search page.
[Member] Click Settings > Domains (to transition over to OldDot)
[Member] Go to the Expenses page > click into the expense > uncheck the reimbursable checkmark
[Member] open the NewDot tab > refresh
Observe the Submit button is still visible on the report preview, report header or search page.

Additional cases

Have a one expense report and the only expense is a pending ECard transition, we shouldn’t show the Submit button
Have a one expense report and the only expense is a scanning receipt, we shouldn’t show the Submit button
Have a batch/multi-expense report and all the expenses are scanning/pending, we shouldn’t show the Submit button
Have a batch/multi-expexpense report and only some of the expenses are scanning/pending should show the Submit button
Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

shubham1206agra · 2025-01-22T15:22:57Z

@ishpaul777 Can you start testing this PR please?

Please test the scanning / fail receipt cases in this PR.

github-actions · 2025-01-22T15:42:56Z

🚧 @trjExpensify has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-22T16:09:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55610/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55610/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55610/NewExpensify.dmg	https://55610.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2025-01-23T09:49:02Z

on it today!

ishpaul777

Seems to work well for all case mentioned 👍

Have a one expense report and the only expense is a pending ECard transition, we shouldn’t show the Submit button

I am not sure how to test this does this requires ECard setup? can you provide steps?

ishpaul777 · 2025-01-23T22:18:10Z

we have conflicts! @shubham1206agra

ishpaul777 · 2025-01-27T09:01:36Z

BUMP! @shubham1206agra

melvin-bot · 2025-01-27T16:25:00Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-01-28T12:15:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-29.at.8.04.14.PM.mov

Screen.Recording.2025-01-29.at.8.07.30.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-29.at.8.15.59.PM.mov

iOS: Native

Screen.Recording.2025-01-29.at.7.52.41.PM.mov

Screen.Recording.2025-01-29.at.8.04.14.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-29.at.7.57.04.PM.mov

Screen.Recording.2025-01-29.at.7.54.56.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-29.at.6.26.13.PM.mov

Screen.Recording.2025-01-29.at.7.33.02.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-29.at.8.35.44.PM.mov

ishpaul777 · 2025-01-28T20:30:21Z

~~Completing checklist in couple hours~~

will finish this one tmrw

ishpaul777 · 2025-01-29T13:22:23Z

Have a one expense report and the only expense is a scanning receipt, we shouldn’t show the Submit button

this test seems to be failing now before it was working

Screen.Recording.2025-01-29.at.6.51.56.PM.mov

shubham1206agra · 2025-01-29T13:34:58Z

@ishpaul777 You may have uploaded the wrong video. Can you please recheck?

ishpaul777 · 2025-01-29T13:38:45Z

my bad! corrected it

shubham1206agra · 2025-01-29T13:44:49Z

@ishpaul777 Let me take a look into this. Since no logic changed.

shubham1206agra · 2025-01-29T14:01:47Z

@ishpaul777 Fixed

OSBotify · 2025-01-29T15:48:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-30T01:59:12Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2025-01-30T19:25:15Z

@ishpaul777 all the steps are passed except the below one. We can't have a Ecard transaction.

Additional cases:
Have a one expense report and the only expense is a pending ECard transition, we shouldn’t show the Submit button

github-actions · 2025-01-31T06:49:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

ishpaul777 · 2025-02-17T13:12:15Z

-        reimbursableSpend !== 0 &&
+        !hasOnlyPendingCardOrScanFailTransactions &&
        !hasAllPendingRTERViolations &&
        !hasBrokenConnectionViolation &&


coming from #56044, there was a regression, we should have added a transactions.length > 0 here

Fix submit button when there is only non-reimbursable expenses

cb72d57

trjExpensify added the Ready To Build label Jan 22, 2025

ishpaul777 reviewed Jan 23, 2025

View reviewed changes

shubham1206agra added 2 commits January 27, 2025 19:42

Merge main

f7be2a7

Fix lint

c598d0c

shubham1206agra marked this pull request as ready for review January 27, 2025 16:24

shubham1206agra requested a review from a team as a code owner January 27, 2025 16:24

melvin-bot Bot requested review from ishpaul777 and removed request for a team January 27, 2025 16:24

Merge main

8243704

Fix filtering condition

9fd6d90

ishpaul777 approved these changes Jan 29, 2025

View reviewed changes

melvin-bot Bot requested a review from lakchote January 29, 2025 15:10

lakchote approved these changes Jan 29, 2025

View reviewed changes

lakchote merged commit bbe73a2 into Expensify:main Jan 29, 2025

github-actions Bot mentioned this pull request Jan 30, 2025

Deploy Checklist: New Expensify 2025-01-30 #56018

Closed

48 tasks

grgia mentioned this pull request Jan 30, 2025

[Due for payment 2025-02-10] [HOLD for payment 2025-02-07] All - Approvers Flow - Empty report created in OD is displayed in ND with the Submit button #56044

Closed

8 tasks

melvin-bot Bot mentioned this pull request Jan 31, 2025

[HOLD for payment 2025-02-07] [$250] Users can't submit a report that contains no reimbursable expenses #55086

Closed

8 tasks

shubham1206agra deleted the fix-submit-button branch February 3, 2025 17:50

ishpaul777 reviewed Feb 17, 2025

View reviewed changes

Conversation

shubham1206agra commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Jan 22, 2025

Uh oh!

github-actions Bot commented Jan 22, 2025

Uh oh!

github-actions Bot commented Jan 22, 2025

Uh oh!

ishpaul777 commented Jan 23, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Jan 23, 2025

Uh oh!

ishpaul777 commented Jan 27, 2025

Uh oh!

melvin-bot Bot commented Jan 27, 2025

Uh oh!

ishpaul777 commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jan 29, 2025

Uh oh!

ishpaul777 commented Jan 29, 2025

Uh oh!

shubham1206agra commented Jan 29, 2025

Uh oh!

shubham1206agra commented Jan 29, 2025

Uh oh!

OSBotify commented Jan 29, 2025

Uh oh!

github-actions Bot commented Jan 30, 2025

Uh oh!

kavimuru commented Jan 30, 2025

Uh oh!

github-actions Bot commented Jan 31, 2025

Uh oh!

ishpaul777 Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shubham1206agra commented Jan 22, 2025 •

edited

Loading

ishpaul777 commented Jan 28, 2025 •

edited

Loading

ishpaul777 commented Jan 28, 2025 •

edited

Loading

ishpaul777 commented Jan 29, 2025 •

edited

Loading