Skip to content

Auto-fill company website in VBA flow#5576

Merged
jasperhuangg merged 4 commits into
mainfrom
cmartins-autoFillDomain
Sep 29, 2021
Merged

Auto-fill company website in VBA flow#5576
jasperhuangg merged 4 commits into
mainfrom
cmartins-autoFillDomain

Conversation

@luacmartins

@luacmartins luacmartins commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Details

This PR makes the protocol in the company website optional, as well as auto fills the website field based on the current session domain.

Fixed Issues

$ #5341

Tests

  1. Login with an account with a Workspace and without a bank account setup.
  2. Go through the flow until you reach the company step.
  3. Verify that the website field is auto-filled with your current user's domain.
  4. Verify that clicking Save & continue does not return an error for that field.
  5. Edit the website removing the protocol, i.e. https:// or http:// and click Save & continue
  6. Verify that there is no error shown for the website field.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Sep 28, 2021
@luacmartins luacmartins marked this pull request as ready for review September 28, 2021 23:32
@luacmartins luacmartins requested a review from a team as a code owner September 28, 2021 23:32
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team September 28, 2021 23:32
@jasperhuangg jasperhuangg merged commit e3e02c9 into main Sep 29, 2021
@jasperhuangg jasperhuangg deleted the cmartins-autoFillDomain branch September 29, 2021 18:23
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants